function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
srikanth cheera 6srikanth cheera 6 

please check my code is proper way or not....and please write test code for my program

/* Write a batch apex to fetch all the tasks assigned to the user and set the status as closed with test class.*/

global class Task19 implements database.Batchable<sobject>{

    global database.QueryLocator start(database.BatchableContext bc){
        return database.getQueryLocator('select id,name,status from task');
    }
    global void execute(database.BatchableContext bc,list<Task> ta){
        user u=[select id from user where alias='sec'];
        for(Task t:ta){
            t.status='closed';
            t.id=u.id;
        }
        update ta;
    }
    global void finish(database.BatchableContext bc){
        
    }
    
}
Amit Chaudhary 8Amit Chaudhary 8
Try to update your code like below
global class Task19 implements database.Batchable<sobject>{

    global database.QueryLocator start(database.BatchableContext bc){
        return database.getQueryLocator('select id,name,status from task');
    }
    global void execute(database.BatchableContext bc,list<Task> ta){
		
        List<user> listU=[select id from user where alias='sec'];
        for(Task t:ta){
			if(listU.size() > 0 ){
				t.status='closed';
				t.id=listU[0].id;
			}	
        }
        update ta;
    }
    global void finish(database.BatchableContext bc){
    }
}
I will recommend you to start using trailhead to learn about test classes
1) https://trailhead.salesforce.com/modules/apex_testing

Also please check below post
1) https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_qs_test.htm
2) https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_testing_example.htm
3) http://amitsalesforce.blogspot.com/2015/06/best-practice-for-test-classes-sample.html

Sample test class to start
@isTest 
public class Task19Test 
{
    static testMethod void testMethod1()
    {
		Account acc = new Account();
		acc.name ='Test';
		insert acc;	
			
		task t1=new task();
		t1.status='Completed';
		t1.Priority='low';
		t1.subject=' has not completed the task within 1 day';
		t1.whatid=acc.id;
		insert t1;
        
        Test.startTest();

            Task19   obj = new Task19();
            DataBase.executeBatch(obj); 
            
        Test.stopTest();
    }
}



Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .

Let us know if this will help you
 
srikanth cheera 6srikanth cheera 6
getting only 20% of code coverege...
Amit Chaudhary 8Amit Chaudhary 8
Issue is in your apex class remove the name field
global class Task19 implements database.Batchable<sobject>{

    global database.QueryLocator start(database.BatchableContext bc){
        return database.getQueryLocator('select id,status from task');
    }
    global void execute(database.BatchableContext bc,list<Task> ta){
		
        List<user> listU=[select id from user where alias='sec'];
        for(Task t:ta){
			if(listU.size() > 0 ){
				t.status='closed';
				t.id=listU[0].id;
			}	
        }
        update ta;
    }
    global void finish(database.BatchableContext bc){
    }
}

Then execute the same test class you will get 80%

 
chanchal jain 7chanchal jain 7
please write the test class for this code
please help me:
============================================================
public class TriggerAccount {
    public static void beforinsert(list<account> acc){
        for(account a: acc){
            if(a.industry=='education'){
                a.phone='9926230435';
            }
        }
    }
    public static void afterinsert(list<account> accs){
        List<accountteamMember>ac=new List<accountteammember>();
        user u=[select id from user where alias='ajain'];
        for(account a :accs){
            if(a.AnnualRevenue > 300000){
               AccountteamMember atm=new AccountTeamMember();
                atm.AccountAccessLevel='all';
                atm.UserId=u.id;
                atm.AccountId=a.id;
                atm.TeamMemberRole='Account Manager';
                ac.add(atm);
            }   
        }
         insert ac;
    }
    public static void beforeupdate(map<id,account>oldmap, Map<id,account>newmap){
        set<id>keys=oldmap.keyset();
        for(id k:keys){
            account old=oldmap.get(k);
            account newac=newmap.get(k);
            if(old.Industry!='energy' && newac.Industry=='energy'){
                newac.Phone='235698';
                newac.Rating='hot';
            }
        }
    }
    public static void Afterupdate(Map<id,account>oldmap, map<id,Account>newmap){
        user u=[select id from user where alias='ajain'];
        List<Accountshare> share=new List<Accountshare>();
        set<id>keys=oldmap.keyset();
        for(id k:keys){
            account oldac1=oldmap.get(k);
            account newacc1=newmap.get(k);
            if(oldac1.Rating !='warm' && newacc1.Rating=='warm'){
                Accountshare as1=new Accountshare();
                as1.UserOrGroupId=u.id;
                as1.AccountId=k;
                as1.AccountAccessLevel='all';
                as1.RowCause='manual';
                share.add(as1);
            }
        }
        insert share;
    }
}
Trigger code:
=============================================================
trigger Apexclasstrigger on Account (before insert,after insert,before update, after update) {
    if(trigger.isbefore && Trigger.isInsert){
        TriggerAccount.beforinsert(trigger.new);
    }else if(Trigger.isAfter && Trigger.isinsert){
        TriggerAccount.afterinsert(Trigger.new);
    }else if(Trigger.isBefore && Trigger.isUpdate){
        TriggerAccount.beforeupdate(Trigger.oldmap, trigger.newmap);
    }if(Trigger.isAfter && Trigger.isupdate){
        TriggerAccount.Afterupdate(Trigger.oldmap, trigger.newmap);
    }
}

plese help me 
thanks