+ Start a Discussion
Adriana Reyes 26Adriana Reyes 26 

Business Hours Apex Trigger Help

trigger AfterHoursTrigger on Service_Call__c (after insert) {
    //Get the default business hours
    BusinessHours bh = [Select Id From BusinessHours Where isDefault = true];
    
    Datetime CreatedTime = System.Today();
    
    //Find whether CreatedDate is whithin those business hours
    for (Service_Call__C Calls : Trigger.new){

    Boolean isWithin = BusinessHours.isWithin(bh.id, CreatedTime);
        if (isWithin = FALSE)
        Calls.After_Hours__c = True;
    }

}

So this is my very first attempt to write a trigger in Salesforce so be patient with me. Basically I want something that will check a checkbox called "After Hours" if the created date of the record doesn't fall within the business hours set up in Salesforce. It's not working, and I have no idea why. Any help is appreciated. Thanks
Dev_AryaDev_Arya
Hi Adriana,

2 Things:
  1. the logical conditional statement like (FALSE = FALSE) is never true. SO in your case even if isWIthin false, the statement will always return false. You can verify this by following code
    Boolean Test = FALSE; 
    if (Test = FALSE) { 
    System.debug('FALSE = FALSE'); 
    } 
    else { 
    System.debug('FALSE = FALSE was not TRUE'); 
    }
    The output will be 'FALSE = FALSE was not TRUE'​. Hence you should change your logic line 11 to 
    if (!isWithin) { 
    //Something here 
    }
  2. you are trying to check the Created date for Service_Call__c, but in line number 10,
Boolean isWithin = BusinessHours.isWithin(bh.id, CreatedTime);

 
You are checking the current time, you should have this check against the created time of Service_call__c record.
Boolean isWithin = BusinessHours.isWithin(bh.id, Calls.CreatedDate);
Try this out. I hope this helps.

Cheers,
Dev
Adriana Reyes 26Adriana Reyes 26
Dev,

Thank you so much! That definitely makes sense. I made the changes you're suggesting, but now I'm getting a Before Insert error. Do you know how I can correct this?
Prashant Pandey07Prashant Pandey07
Hi Adriana,

You may try something like this..and make sure you have business hours is already set up.
 
trigger AfterHoursTrigger on Service_Call__c  (before insert) {

 
 For(Service_Call__c wc:trigger.new){

   
    Datetime CreatedTime = System.Today();
    
    
    BusinessHours bh = [Select
         SundayStartTime, MondayStartTime, TuesdayStartTime,
         WednesdayStartTime, ThursdayStartTime, FridayStartTime,
         SaturdayStartTime, SundayEndTime, MondayEndTime,TuesdayEndTime,
         WednesdayEndTime, ThursdayEndTime, FridayEndTime,SaturdayEndTime
       From BusinessHours 
       Where IsDefault=true];
  
    Boolean isWithin = BusinessHours.isWithin(bh.id, CreatedTime);
      system.debug('#######'+isWithin);
    
        if (!isWithin)
        wc.After_Hours__c = True;
       
    }
    

}


--
Thanks,
Prashant
Adriana Reyes 26Adriana Reyes 26
Prashant,

Thank you for your suggestion, but the after hours check box is getting checked everytime even though it is within the business hours that I have set up. I'm scared that there's some weird time zone thing going on. I have no idea.
Prashant Pandey07Prashant Pandey07
@Adriana,
Could you please check the debug at line 19...and see what are you getting and you can also set the debug for today business hour.

--
Thanks,
Prashant
Adriana Reyes 26Adriana Reyes 26
Prashant,
I changed System.Today() to System.Now() and it seems to be working! Thank you! Now I just need to deploy it into production from my sandbox. Do you know how I would write a test class for this trigger?
Prashant Pandey07Prashant Pandey07
Great that it worked for you.. You can use below code to test your trigger.
 
@IsTest
public class BusinesshrsTestclass {
  public  static testMethod void BusinesshrsTestmethod()
    {
        List<BusinessHours> bhs=[select id from BusinessHours where IsDefault=true];
        System.assert(bhs.size()==1);
        Service_Call__c sc =new Service_Call__c();
        sc.name='Test';
        sc.After_Hours__c=False;
       //add other required field if needed
        insert sc;
        
        accs.After_Hours__c=true;
        update accs;
        System.assert(accs.After_Hours__c,true);      
    
    }
}

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .

Let us know if this will help you


--
Thanks,
Prashant
Adriana Reyes 26Adriana Reyes 26
Prashant,

I am getting these errors
"System.DmlException: Insert failed. First exception on row 0; first error: CANNOT_INSERT_UPDATE_ACTIVATE_ENTITY, scUpdate: execution of BeforeInsert"
and 
"EXCEPTION_THROWN caused by: System.QueryException: List has no rows for assignment to SObject"
Prashant Pandey07Prashant Pandey07
Are you trying to run same test class or this is something else..
--
Thanks,
Prashant
Adriana Reyes 26Adriana Reyes 26
Yes it's the same test class
Prashant Pandey07Prashant Pandey07
I see..try this..
@IsTest
public class BusinesshrsTestclass {
  public  static testMethod void BusinesshrsTestmethod()
    {
        List<BusinessHours> bhs=[select id from BusinessHours where IsDefault=true];
        System.assert(bhs.size()==1);
        Service_Call__c sc =new Service_Call__c();
        sc.name='Test';
        sc.After_Hours__c=False;
       //add other required field if needed
        insert sc;
        
        sc.After_Hours__c=true;
        update sc;
        System.assert(sc.After_Hours__c,true);      
    
    }
}

--
Thanks,
Prashant