+ Start a Discussion
Collen Mayer 6Collen Mayer 6 

Not getting inside for loop in test class

Greetings all,
I'm working on a test class and can't figure out why when I run the test I am not getting inside the for loop.  (I assume the test record I'm creating doesn't meet the criteria but can't figure out why).  Could someone kindly help me troubleshoot?  Thanks in advance!

Test class:
@istest
public class TestClassforInvoice {
 public static testMethod void testmyInvoices(){
	Account testAccount = new Account (Name = 'MyHousehold');
    Insert testAccount; 
    Contact testContact = new Contact (LastName= 'smith');
    insert testContact;
    AECaseMgmt__Program__c programNew = new AECaseMgmt__Program__c(Name= 'test prg'); 
	insert programNew; 
    AECaseMgmt__Program_Case__c testCase = new 	AECaseMgmt__Program_Case__c 
        (AECaseMgmt__Open_Date__c = System.now().date(), 	
         Program__c = programNew.Id, BypassValidationForProcessBuilder__c = true); 
     testCase.AECaseMgmt__Household__c = testAccount.id; 
    insert testCase;
    Case_Member_Enrollments__c testmember = new 
        Case_Member_Enrollments__c (Name = 'testCM', Case_ID__c = testCase.id, BypassValidationForProcessBuilder__c=true );
    
    testmember.Case_Member__c = testContact.id;
     insert testmember; 
    
     Client_Billing__c clientbill = new Client_Billing__c 
         (Entry_Type__c = 'Billed Expense', Billing_Item__c = 'Court Report', Client_Case__c = testCase.Id);
     
     PageReference pageRef = Page.SingleInvoice;
        Test.setCurrentPage(pageRef);
     ApexPages.StandardController sc = new ApexPages.StandardController(testcase);
		Invoice  controller = new Invoice(sc);
     pageRef = Page.MultipleInvoices;
        Test.setCurrentPage(pageRef);
		controller = new Invoice(sc);

 }
}
The for loop in my controller extension:

            for (AECaseMgmt__Program_Case__c  record: [Select ID, AECaseMgmt__Household__r.BillingSTreet, AECaseMgmt__Household__r.BillingCity,
                                                   AECaseMgmt__Household__r.BillingState,AECaseMgmt__Household__r.BillingPostalCode,
                                                   AECaseMgmt__Household__r.npe01__One2OneContact__r.name,
                                                   Program__r.name, Name,Account_Balance__c from  AECaseMgmt__Program_Case__c
                                                   where Id IN (SELECT Client_Case__c FROM Client_Billing__c)])  
            {
                caselist.add(New CasewInvoices (record));    
            }


Again, when I run the test, I'm not covering inside the for loop, and since "caselist" is not being populated, I'm not able to cover a large amount of the rest of my code.

And the entire controller:
public class Invoice {
    public ApexPages.StandardController stdCntrlr {get; set;}
    public list <CasewInvoices> caselist {get; set;}
    public list <Client_Billing__c> tempinvoicelist {get; set;}
    public String currentRecordId {get;set;}
    public decimal thirtydayold {get; set;}
    public decimal sixtydayold {get;set;}
    public decimal ninetydayold {get;set;}
    
    public Invoice(ApexPages.StandardController controller) {
        stdCntrlr = controller;
        if (caselist==null){
            caselist = new List <CasewInvoices>();
            }
        
        tempinvoicelist = [Select ID, Client_Case__c, Name, Amount__c, Date__c,Transaction_Description__c, Amount_Credit_Debit__c 
                           from Client_Billing__c Where Include_on_Invoice__c = true ]; 
		currentRecordId  = ApexPages.CurrentPage().getparameters().get('id');      
     	
        String pageName = ApexPages.currentPage().getUrl().substringAfter('apex/');
		system.debug('-----current ID name----'+currentRecordID);

// populate case list; if from single invoice, just get one case; otherwise get all        
        
            for (AECaseMgmt__Program_Case__c  record: [Select ID, AECaseMgmt__Household__r.BillingSTreet, AECaseMgmt__Household__r.BillingCity,
                                                   AECaseMgmt__Household__r.BillingState,AECaseMgmt__Household__r.BillingPostalCode,
                                                   AECaseMgmt__Household__r.npe01__One2OneContact__r.name,
                                                   Program__r.name, Name,Account_Balance__c from  AECaseMgmt__Program_Case__c 
                                                   where Id IN (SELECT Client_Case__c FROM Client_Billing__c)])  
        	{
            	caselist.add(New CasewInvoices (record));	
        	}
        
        
        for (CasewInvoices caseincrement:caselist)
        {
            Decimal thirtydayold = 3;
            for(Integer i = 0; i <tempinvoicelist.size(); i++){
            	if (tempinvoicelist[i].client_case__c ==caseincrement.clientcase.id)
                    {
                        caseincrement.billinglist.add (tempinvoicelist[i]);
                        If (tempinvoicelist[i].Amount_Credit_Debit__c>0)
                        {
                        	If (tempinvoicelist[i].date__c.daysBetween(date.today())> 90)
                        		caseincrement.ninetydayold = caseincrement.thirtydayold + tempinvoicelist[i].Amount_Credit_Debit__c;
                        
                            If (tempinvoicelist[i].date__c.daysBetween(date.today())> 60)
                        		caseincrement.sixtydayold = caseincrement.thirtydayold + tempinvoicelist[i].Amount_Credit_Debit__c;
                        
                            If (tempinvoicelist[i].date__c.daysBetween(date.today())> 30)
                        		caseincrement.thirtydayold = caseincrement.thirtydayold + tempinvoicelist[i].Amount_Credit_Debit__c;
                        }
                        Else 
                        {
                            caseincrement.ninetydayold = caseincrement.ninetydayold + tempinvoicelist[i].Amount_Credit_Debit__c;
                            caseincrement.sixtydayold = caseincrement.sixtydayold + tempinvoicelist[i].Amount_Credit_Debit__c;
                            caseincrement.thirtydayold = caseincrement.thirtydayold + tempinvoicelist[i].Amount_Credit_Debit__c;
                        }
                    }
            }
        }
 }

	Public class CasewInvoices
    {
        public List<Client_Billing__c> billingList {get;set;}
        public AECaseMgmt__Program_Case__c Clientcase {get;set;}
        public decimal thirtydayold {get;set;}
        public decimal sixtydayold {get;set;}
        public decimal ninetydayold {get;set;}
        
        public CasewInvoices (AECaseMgmt__Program_Case__c cc)
        {
            Clientcase = cc;
            billingList = new list<Client_Billing__c>();
            thirtydayold = 0;
            sixtydayold = 0;
            ninetydayold = 0;
        }
	}
}
Best Answer chosen by Collen Mayer 6
Amit Chaudhary 8Amit Chaudhary 8
Hi Collen Mayer 6,

Look like you forget to add "Client_Billing__c clientbill" record in test class. Please try below code
 
insert clientbill
Like below code
@istest
public class TestClassforInvoice {
	public static testMethod void testmyInvoices()
	{
		Account testAccount = new Account (Name = 'MyHousehold');
		Insert testAccount; 
		
		Contact testContact = new Contact (LastName= 'smith');
		insert testContact;
		
		AECaseMgmt__Program__c programNew = new AECaseMgmt__Program__c(Name= 'test prg'); 
		insert programNew; 
		
		AECaseMgmt__Program_Case__c testCase = new 	AECaseMgmt__Program_Case__c 
			(AECaseMgmt__Open_Date__c = System.now().date(), 	
			 Program__c = programNew.Id, BypassValidationForProcessBuilder__c = true); 
		testCase.AECaseMgmt__Household__c = testAccount.id; 
		insert testCase;
		
		Case_Member_Enrollments__c testmember = new 
		Case_Member_Enrollments__c (Name = 'testCM', Case_ID__c = testCase.id, BypassValidationForProcessBuilder__c=true );

		testmember.Case_Member__c = testContact.id;
		insert testmember; 

		Client_Billing__c clientbill = new Client_Billing__c 
		 (Entry_Type__c = 'Billed Expense', Billing_Item__c = 'Court Report', Client_Case__c = testCase.Id);

		insert  clientbill;

		Test.StartTest();
		
			PageReference pageRef = Page.SingleInvoice;
			Test.setCurrentPage(pageRef);
			ApexPages.StandardController sc = new ApexPages.StandardController(testcase);
			Invoice  controller = new Invoice(sc);
			pageRef = Page.MultipleInvoices;
			Test.setCurrentPage(pageRef);
			controller = new Invoice(sc);
				
			System.assert(controller.caselist != null);	
		
		Test.StopTest();
		
	}
}

NOTE:- Dnt forget to add assert. Without assert you will get code coverage only. but as per best practice you should add assert



Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you
 
 

All Answers

PawanKumarPawanKumar
Hi Collen,

Everything is fine in your code except insert clientBilling as highlighted in bold. Please try below code.

@istest
public class TestClassforInvoice {
 public static testMethod void testmyInvoices(){
    Account testAccount = new Account (Name = 'MyHousehold');
    Insert testAccount; 
    Contact testContact = new Contact (LastName= 'smith');
    insert testContact;
    AECaseMgmt__Program__c programNew = new AECaseMgmt__Program__c(Name= 'test prg'); 
    insert programNew; 
    AECaseMgmt__Program_Case__c testCase = new     AECaseMgmt__Program_Case__c 
        (AECaseMgmt__Open_Date__c = System.now().date(),     
         Program__c = programNew.Id, BypassValidationForProcessBuilder__c = true); 
     testCase.AECaseMgmt__Household__c = testAccount.id; 
    insert testCase;
    Case_Member_Enrollments__c testmember = new 
        Case_Member_Enrollments__c (Name = 'testCM', Case_ID__c = testCase.id, BypassValidationForProcessBuilder__c=true );
    
    testmember.Case_Member__c = testContact.id;
     insert testmember; 
    
     Client_Billing__c clientbill = new Client_Billing__c 
         (Entry_Type__c = 'Billed Expense', Billing_Item__c = 'Court Report', Client_Case__c = testCase.Id);
 
    insert clientbill;
    
     PageReference pageRef = Page.SingleInvoice;
        Test.setCurrentPage(pageRef);
     ApexPages.StandardController sc = new ApexPages.StandardController(testcase);
        Invoice  controller = new Invoice(sc);
     pageRef = Page.MultipleInvoices;
        Test.setCurrentPage(pageRef);
        controller = new Invoice(sc);

 }
}

 
Amit Chaudhary 8Amit Chaudhary 8
Hi Collen Mayer 6,

Look like you forget to add "Client_Billing__c clientbill" record in test class. Please try below code
 
insert clientbill
Like below code
@istest
public class TestClassforInvoice {
	public static testMethod void testmyInvoices()
	{
		Account testAccount = new Account (Name = 'MyHousehold');
		Insert testAccount; 
		
		Contact testContact = new Contact (LastName= 'smith');
		insert testContact;
		
		AECaseMgmt__Program__c programNew = new AECaseMgmt__Program__c(Name= 'test prg'); 
		insert programNew; 
		
		AECaseMgmt__Program_Case__c testCase = new 	AECaseMgmt__Program_Case__c 
			(AECaseMgmt__Open_Date__c = System.now().date(), 	
			 Program__c = programNew.Id, BypassValidationForProcessBuilder__c = true); 
		testCase.AECaseMgmt__Household__c = testAccount.id; 
		insert testCase;
		
		Case_Member_Enrollments__c testmember = new 
		Case_Member_Enrollments__c (Name = 'testCM', Case_ID__c = testCase.id, BypassValidationForProcessBuilder__c=true );

		testmember.Case_Member__c = testContact.id;
		insert testmember; 

		Client_Billing__c clientbill = new Client_Billing__c 
		 (Entry_Type__c = 'Billed Expense', Billing_Item__c = 'Court Report', Client_Case__c = testCase.Id);

		insert  clientbill;

		Test.StartTest();
		
			PageReference pageRef = Page.SingleInvoice;
			Test.setCurrentPage(pageRef);
			ApexPages.StandardController sc = new ApexPages.StandardController(testcase);
			Invoice  controller = new Invoice(sc);
			pageRef = Page.MultipleInvoices;
			Test.setCurrentPage(pageRef);
			controller = new Invoice(sc);
				
			System.assert(controller.caselist != null);	
		
		Test.StopTest();
		
	}
}

NOTE:- Dnt forget to add assert. Without assert you will get code coverage only. but as per best practice you should add assert



Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you
 
 
This was selected as the best answer