+ Start a Discussion
SUMIT BANERJEESUMIT BANERJEE 

Bulkify Issue On my trigger where I need to change change

Please check my trigger where I need to change for pass bulkifying issue.


trigger Noofcontacts on Contact (after insert,after delete) {
    
    Set<id>accid    =   new Set<id>();
    List<contact>contactlist =  new List<contact>();
    List<contact>listcon    =   new List<contact>();
    List<account>acclist    =   new List<account>();
    List<account>listacc    =   new List<account>();
    Map<id,integer>mapCount =   new Map<id,integer>();

    if(trigger.isinsert){
        for(contact con:trigger.new){
            accid.add(con.accountid);
        }
    }

    if (trigger.isdelete){
        for(contact con:trigger.old){
            accid.add(con.accountid);
        }
    }

    acclist=[SELECT id,name FROM account WHERE id in:accid];
    contactlist=[SELECT id,name,accountid FROM contact WHERE accountid in:accid];

    for(account acc:acclist){
        listcon.clear();
        for(contact c:contactlist){
            if(c.accountid==acc.id){
                listcon.add(c);
                mapCount.put(c.accountid,listcon.size());
            }
        }
    }

    if(acclist.size()>0){
        for(Account a:acclist){
            if(mapCount.get(a.id)==null)
                a.No_of_Contacts__c=0;
            else
                a.No_of_Contacts__c=mapCount.get(a.id);
                listacc.add(a);
        }
    }

    if(listacc.size()>0)
    update listacc;
}
Best Answer chosen by SUMIT BANERJEE
Amit Chaudhary 8Amit Chaudhary 8
Please update your code like below
trigger Noofcontacts on Contact (after insert,after delete) 
{
    Set<id> accid = new Set<id>();

    if(trigger.isinsert)
	{
        for(contact con:trigger.new)
		{
            accid.add(con.accountid);
        }
    }

    if (trigger.isdelete)
	{
        for(contact con:trigger.old)
		{
            accid.add(con.accountid);
        }
    }
	
	if( accid.size() > 0  )
	{
		List<Account> ListAccount = [select id,No_of_Contacts__c, (select id from contacts) where id in :accid  ] ; 
		
		list<Account> lstAccToUpdate = new list<Account>();
		for(Account ACC:ListAccount)
		{
			List<Contact> lstCont = ACC.contacts;
			ACC.No_of_Contacts__c=lstCont.size();
			lstAccToUpdate.add(ACC);
			
		}
		
		if(lstAccToUpdate.size()>0)
		{
			update lstAccToUpdate;
		}	
	}
	

}


Trigger Best Practices | Sample Trigger Example | Implementing Trigger Framework

1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org.

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers


4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail
 

All Answers

bob_buzzardbob_buzzard
I can't see any bulkification issues there - you don't have any SOQL or DML inside for loops. When you say 'pass bulkifying issue', what is the actual issue?
Amit Chaudhary 8Amit Chaudhary 8
Please update your code like below
trigger Noofcontacts on Contact (after insert,after delete) 
{
    Set<id> accid = new Set<id>();

    if(trigger.isinsert)
	{
        for(contact con:trigger.new)
		{
            accid.add(con.accountid);
        }
    }

    if (trigger.isdelete)
	{
        for(contact con:trigger.old)
		{
            accid.add(con.accountid);
        }
    }
	
	if( accid.size() > 0  )
	{
		List<Account> ListAccount = [select id,No_of_Contacts__c, (select id from contacts) where id in :accid  ] ; 
		
		list<Account> lstAccToUpdate = new list<Account>();
		for(Account ACC:ListAccount)
		{
			List<Contact> lstCont = ACC.contacts;
			ACC.No_of_Contacts__c=lstCont.size();
			lstAccToUpdate.add(ACC);
			
		}
		
		if(lstAccToUpdate.size()>0)
		{
			update lstAccToUpdate;
		}	
	}
	

}


Trigger Best Practices | Sample Trigger Example | Implementing Trigger Framework

1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org.

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers


4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail
 
This was selected as the best answer