+ Start a Discussion
sachitanand kumarsachitanand kumar 

hello can anybody help me to write Test class for this Trigger. i m new at salesforce

trigger opportunitytocontactstageupdate on Opportunity (after insert, after update) {
     if(Trigger.isafter){


        List<contact> thisContact1=new List<contact>();
        set<id> thisContact=new set<id>();
        map<id,id> oppContactMap  = new map<id,id>(); 
        map<id,contact> ContactMap  = new map<id,contact>();

 List<OpportunityContactRole> oppContact = [SELECT id,OpportunityID,ContactId FROM OpportunityContactRole WHERE OpportunityID = :trigger.newmap.keyset() ];
                 
                 if(oppContact.size()>0){

                    for(OpportunityContactRole oppContacObj : oppContact){
                        oppContactMap.put(oppContacObj.OpportunityId,oppContacObj.ContactId);
                        thisContact.add(oppContacObj.Contactid);
                    }
                        for(Contact conObj :[Select Name,opportunityStageName__c from Contact Where id IN :thisContact] ){
                            ContactMap.put(conObj.id,conObj);
                        }
                            for(opportunity oppObj : trigger.new){
                                ContactMap.get(oppContactMap.get(oppObj.id)).opportunityStageName__c = oppObj.StageName;
                                thisContact1.add(contactMap.get(oppContactMap.get(oppObj.id)));
                            }
                                update thisContact1;
                 }
     }
}
DeveloperSudDeveloperSud
Hi ,

Can you explain how this trigger will work for after insert event? As I have checked this trigger will only work once if there is OpportunityContactRole record present for a opportunity record and the trigger is not creating any contact role during insertion.So this will only work for update trigger.
 
@isTest
public class opportunitytocontactstageupdateTest {
    
   
    static testmethod void myUnitTest1(){
        //create contact records
        contact c=new contact();
        c.LastName='Test Contact Name';
        insert c;
        
        //create Opportunity Records
        Date clsedte=Date.today();
        opportunity op=new opportunity();
        op.name='Test Opportunity';
        op.stageName='Test Stage Name1';
        op.closeDate=clsedte;
        insert op;
       
        //update the opportunity
        op.StageName='Test stage Name2';
        update op;
        
        //create opportunity contact role
        OpportunityContactRole ocr=new OpportunityContactRole();
        ocr.ContactId=c.Id;
        ocr.OpportunityId=op.id;
        insert ocr;
        // update contact
        c.opportunityStageName__c=op.StageName;
        update c;
       
        
        // check the value of the contact field opportunityStageName__c
        Contact cAfterInsert=[select name,id,opportunityStageName__c from contact where id=:c.Id];
        system.debug(cAfterInsert);
        system.assertEquals('Test stage Name2', cAfterInsert.opportunityStageName__c);
        
    }
    
    
    

}

 
sachitanand kumarsachitanand kumar
DeveloperSud
hi,

i executed above test class but it cover only 43%  of code coverage. so you can please help me how can i will achived the code coverage above 75%.
when i executed the test class i found some part of trigger code is not cover that was this

 for(OpportunityContactRole oppContacObj : oppContact){
                        oppContactMap.put(oppContacObj.OpportunityId,oppContacObj.ContactId);
                        thisContact.add(oppContacObj.Contactid);
                    }
                        for(Contact conObj :[Select Name,opportunityStageName__c from Contact Where id IN :thisContact] ){
                            ContactMap.put(conObj.id,conObj);
                        }
                            for(opportunity oppObj : trigger.new){
                                ContactMap.get(oppContactMap.get(oppObj.id)).opportunityStageName__c = oppObj.StageName;
                                thisContact1.add(contactMap.get(oppContactMap.get(oppObj.id)));
                            }
                                update thisContact1;
                      }

 
Amit Chaudhary 8Amit Chaudhary 8
I will recommend you to start using trailhead to learn about test classes
1) https://trailhead.salesforce.com/modules/apex_testing

Also please check below post
1) https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_qs_test.htm
2) https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_testing_example.htm
3) http://amitsalesforce.blogspot.com/2015/06/best-practice-for-test-classes-sample.html

You write a test class for this the same way that you would any other:

- Set up some data for the Trigger(in this case it looks like Account ,Contact Opportunity and OpportunityContactRolerecords)
- Instantiate the Trigger-by update the opportunity
- Verify the behaviour with asserts.

Sample test class to start :-
 
@isTest
public class opportunitytocontactstageupdateTest 
{
    static testmethod void myUnitTest()
	{

		Account acc = new Account();
			acc.Name = 'Test Account';
		insert acc;
		
		
        Contact con = new Contact();
			con.AccountId = acc.id;
			con.FirstName = 'FirstName';
			con.LastName = 'LastName';
		insret con;
		
        
        Opportunity oppt = new Opportunity(Name ='New mAWS Deal',
                            AccountID = acc.id,
                            StageName = 'Customer Won',
                            Amount = 3000,
                            CloseDate = System.today()
                            );
		insert oppt;
			
			
		OpportunityContactRole ocr1 = new OpportunityContactRole(opportunityid=oppt.id,contactid=con.Id,IsPrimary=true);
		insert ocr1;

		
		Test.startTest();
		
			update oppt;
			
		Test.stopTest();
    }
}

Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you