function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
Patrick Sluck 5Patrick Sluck 5 

Issue populating Contact Email with Trigger

Here is the code I am working with.  I am already at 15 relationship on the Opportunity Object otherwise I would do this with a formula field.

trigger SetPrimaryContactEmail on Opportunity (before insert, before update) {
  Set<ID> setConIds = new Set<ID>();
    for(Opportunity obj : trigger.new)
   {
         if(obj.Primary_Contact__c != null)
            setConIds.add(obj.Primary_Contact__c);
   }

  MAP<ID , Contact> mapCon = new MAP<ID , Contact>([Select Email from Contact where id in: setConIds]);

   for(Case obj : trigger.new)
   {
        if(obj.Primary_Contact__c != null)
          {
            Contact c = mapCon.add(obj.Primary_Contact__c);
            obj.Primary_Contact_Email__c = c.Email;
          }
       
   }
}
Best Answer chosen by Patrick Sluck 5
Paul S.Paul S.
Try this, starting at MAP<ID , Contact>:
Map<Id,String> mapCon = new Map<Id,String>();
for(Contact c : [select id, email from contact where id in :setConIds]){
  mapCon.add(c.id,c.email);
}

for(Opportunity obj : trigger.new){
  if(obj.Primary_Contact__c != null){
    obj.Primary_Contact_Email__c = mapCon.get(obj.Primary_Contact__c);
  }
}

 

All Answers

Paul S.Paul S.
Try this, starting at MAP<ID , Contact>:
Map<Id,String> mapCon = new Map<Id,String>();
for(Contact c : [select id, email from contact where id in :setConIds]){
  mapCon.add(c.id,c.email);
}

for(Opportunity obj : trigger.new){
  if(obj.Primary_Contact__c != null){
    obj.Primary_Contact_Email__c = mapCon.get(obj.Primary_Contact__c);
  }
}

 
This was selected as the best answer
Patrick Sluck 5Patrick Sluck 5
Paul, you rock!!!  I cannot thank you enough!!!  I did make 1 minor change to your code.  

Instead of mapCon.add(c.id,c.email);

I used mapCon.put(c.id,c.email);

Thank you so mucch for putting me on the right path!!!
 
Patrick Sluck 5Patrick Sluck 5
Now my next challenge is trying to write my test class for this code.  Any suggestions?  I have never been a ddeveloper but I now find myself having to play one at work.

Thanks for any suggestions!!!!
Paul S.Paul S.
Put, right. Must have been going too fast. Nice catch - glad it worked for you.
Paul S.Paul S.
For the test class, try this.  Test classes should always test in bulk, which this doesn't, but it should get you started.  For some great Apex tutorials, try sfdc99.com.
 
@isTest
public class testOppEmail{
	
	public static testmethod void updateEmail(){
	
		//Set up test data first, we'll insert an account, contact, and opportunity
		
		//Add a test account record
		
		account a = new account(
			name = 'Test Account'
		);
			
		insert a;
		
		//Do the same for a test contact record
		
		contact c = new contact(
			firstname = 'Test',
			lastname = 'Contact',
			email = 'tcontact@test.com',
			accountid = a.id
		);
			
		insert c;
		
		//Finally, add an opportunity
		
		opportunity o = new opportunity(
			name = 'Test Opportunity',
			amount = 10000,
			primary_contact__c = c.id,
			//add other required fields
		);
			
		test.startTest();
		
		insert o;
		
		test.stopTest();
		
		//We'll then check to make sure that the email address on the opportunity record
		//got updated.
		
		opportunity oUpdated = [select id, primary_contact__r.email, primary_contact_email__c from opportunity limit 1];
		
		system.assertEquals(oUpdated.primary_contact__r.email,oUpdated.primary_contact_email__c);
		
	}
	
}

 
Patrick Sluck 5Patrick Sluck 5
Hi Paul, 

I am getting the following error on line 34

unexpected token: ')'

Thanks, 
Patrick
Amit Chaudhary 8Amit Chaudhary 8

Hi Patrick Sluck 5,

I found below issue in your Trigger
1) Use containsKey before using Map
2) use Get method to get value from map (you was using the add)
3) You used Case Object with Trigger.new
trigger SetPrimaryContactEmail on Opportunity (before insert, before update) 
{
	Set<ID> setConIds = new Set<ID>();
    for(Opportunity obj : trigger.new)
	{
         if(obj.Primary_Contact__c != null)
            setConIds.add(obj.Primary_Contact__c);
	}

	MAP<ID ,Contact> mapCon = new MAP<ID , Contact>([Select Email from Contact where id in: setConIds]);

	for(Opportunity obj : trigger.new)
	{
        if(obj.Primary_Contact__c != null && mapCon.containsKey(obj.Primary_Contact__c) )
        {
            Contact c = mapCon.get(obj.Primary_Contact__c);
            obj.Primary_Contact_Email__c = c.Email;
        }
	}
}


Please update your code like below

I will recommend you to start using trailhead to learn about test classes
1) https://trailhead.salesforce.com/modules/apex_testing

Also please check below post
1) https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_qs_test.htm
2) https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_testing_example.htm
3) http://amitsalesforce.blogspot.com/2015/06/best-practice-for-test-classes-sample.html
4) http://amitsalesforce.blogspot.com/2017/02/salesforce-tutorial-how-to-learn-test.html

You write a test class for this the same way that you would any other:

- Set up some data for the controller to access (in this case it looks like Account Contact and Opportunity records)
- Instantiate the Trigger-Perform DML
- Execute a method/methods
- Verify the behaviour with asserts.

Sample test class to start :-
@isTest
public class testOppEmail{
	
	public static testmethod void updateEmail(){
	
		
		account a = new account(name = 'Test Account');
		insert a;
		
		contact c = new contact(
			firstname = 'Test',
			lastname = 'Contact',
			email = 'tcontact@test.com',
			accountid = a.id
		);
			
		insert c;
		
		
		Opportunity oppt = new Opportunity(Name ='New mAWS Deal',
                            AccountID = accId,
                            StageName = 'Customer Won',
                            Amount = 3000,
							primary_contact__c = c.id,
                            CloseDate = System.today()
                            );
							
		test.startTest();
		
		insert oppt;
		
		test.stopTest();
		
		//We'll then check to make sure that the email address on the opportunity record
		//got updated.
		
		opportunity oUpdated = [select id, primary_contact__r.email, primary_contact_email__c from opportunity where id = :oppt.id ];
		
		system.assertEquals(oUpdated.primary_contact__r.email,oUpdated.primary_contact_email__c);
		
	}
	
}
Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

 
Paul S.Paul S.
I put three fields there by example when creating the opportunity, assuming you'd have more fields to add.  That error - as my code stands above - is because there is a "," after the "primary_contact__c = c.id"  (line 32).  There should not be a comma after whatever is the last field value you set.