+ Start a Discussion
Laura BrockLaura Brock 

How do I move a Task trigger into Production?

I have never created a new trigger before.  I have it working beautifully in UAT :-) but when I went to replicate in Production, it seems you can't just 'add' a new trigger.  It has to be moved or pushed?  And, it needs to account for testing coverage?  The code I need to move is below:

trigger TaskCompletion on Task (after insert,after update) {
    
    list<task> lst_Task = new list<task>(); 
    set<id> cID = new set<id>();
    
    Map<id,Payroll_Checklist__c> MP_chklst;
    
        for(task task_obj :trigger.new)
    {
            cID.add(task_obj.whatid);
    }

    MP_chklst = new Map<id,Payroll_Checklist__c>([SELECT ID,Checklist_Complete__c FROM Payroll_Checklist__c WHERE ID IN : cID ]);
    
    for(task task_obj :trigger.new)
    {
        if(task_obj.status == 'Completed')
        {
          MP_chklst.get(task_obj.whatid).Checklist_Complete__c = true;
        }
    }
    
        update MP_chklst.values();
}


Does anyone have some quick/easy steps to move it to Production?  And, do I need to do anything to the code to account for the testing coverage?  I'm sure this is basic, but development of triggers is new for me!
Best Answer chosen by Laura Brock
Krishnamoorthi PeriasamyKrishnamoorthi Periasamy
Laura,

Please use below code in your test class.

@isTest 
public class TriggerTestClass 
{
    static testMethod void testMethodOne() 
    {
 
        Payroll_Checklist__c pc = new Payroll_Checklist__c();
        pc.Checklist_Complete__c=false;
        pc.Name = 'Test';
        pc.Year__c = '2017';
        pc.Quarter__c = '1';
        insert pc;
            
        task e = new task();
        e.Subject = 'Demo ';
        e.Description = 'Event created through Showing/Viewing';
        e.WhatId = pc.Id;
        e.status = 'Completed';
 
        insert e;

    }
}
 

All Answers

Krishnamoorthi PeriasamyKrishnamoorthi Periasamy
@isTest 
public class TriggerTestClass 
{
    static testMethod void testMethodOne() 
    {
 
        Payroll_Checklist__c pc = new Payroll_Checklist__c();
        pc.Checklist_Complete__c=false;
        pc.Name = 'Test';
        insert pc;
            
        task e = new task();
        e.Subject = 'Demo ';
        e.Description = 'Event created through Showing/Viewing';
        e.WhatId = pc.Id;
        e.status = 'Completed';
 
        insert e;

    }
}

Use above class for testing Trigger. You will get 100%  test coverage for this Trigger. You have to make sure overall Test coverage minimum 75% for whole organization. You can use Change sets for Production deployment.

https://trailhead.salesforce.com/modules/app_deployment/units/app_deployment_changesets
https://developer.salesforce.com/docs/atlas.en-us.dev_lifecycle.meta/dev_lifecycle/creating_outbound_changeset.htm

Hopefully the above answer will help you to deploy the above trigger to Production. Still you need any help, please let me know... If above answer is enough to solve your issue, please mark it as Solved. Thanks
Amit Chaudhary 8Amit Chaudhary 8
Hi Laura Brock,

I will suggest to do one change in your trigger code like below. Its better to check containsKey method before get value from Map.


        if(task_obj.status == 'Completed' && MP_chklst.containsKey(task_obj.whatid) )
        {
             MP_chklst.get(task_obj.whatid).Checklist_Complete__c = true;
        }

NOTE:- Task can be create on other object in that case may be your code will fail.
 
trigger TaskCompletion on Task (after insert,after update) {
    
    list<task> lst_Task = new list<task>(); 
    set<id> cID = new set<id>();
    
    Map<id,Payroll_Checklist__c> MP_chklst;
    
        for(task task_obj :trigger.new)
    {
            cID.add(task_obj.whatid);
    }

	If(cID.size() > 0 )
	{
		MP_chklst = new Map<id,Payroll_Checklist__c>([SELECT ID,Checklist_Complete__c FROM Payroll_Checklist__c WHERE ID IN : cID ]);
		
		List<Payroll_Checklist__c> lstCheckListToUpdate = new List<Payroll_Checklist__c>();
		
		for(task task_obj :trigger.new)
		{
			if(task_obj.status == 'Completed' && MP_chklst.containsKey(task_obj.whatid) )
			{
				Payroll_Checklist__c pc = MP_chklst.get(task_obj.whatid) ;
				pc.Checklist_Complete__c = true;
				lstCheckListToUpdate.add(pc);
			}
		}
		if(lstCheckListToUpdate.size() > 0)
		{
			update lstCheckListToUpdate;
			//update MP_chklst.values(); No need to update full map
		}	
	}		
}
I will recommend you to start using trailhead to learn about test classes
1) https://trailhead.salesforce.com/modules/apex_testing

Also please check below post
1) https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_qs_test.htm
2) https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_testing_example.htm
3) http://amitsalesforce.blogspot.com/2015/06/best-practice-for-test-classes-sample.html

You write a test class for this the same way that you would any other:

- Set up some data for the Trigger to access (in this case it looks like Payroll_Checklist__c, Task)
- Instantiate the Trigger- by DML
- Verify the behaviour with asserts.

Please try below sample code
@isTest 
public class TaskCompletionTest 
{
    static testMethod void testMethodOne() 
    {
 
        Payroll_Checklist__c pc = new Payroll_Checklist__c();
			pc.Checklist_Complete__c=false;
			pc.Name = 'Test';
			// add all required field
        insert pc;
            
			
        task t = new task();
			t.Subject = 'Demo ';
			t.Description = 'Event created through Showing/Viewing';
			t.WhatId = pc.Id;
			t.status = 'Completed';
			t.Priority='Normal';
			t.whatId = pc.id;
			// add all required field here
        insert t;
		
    }
}
Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

 
Laura BrockLaura Brock
Hi Krishnamoorthi – I tried to add this to the trigger, but it is giving me errors and won’t let me save? How do I incorporate/build the test code coverage into the original trigger?
Krishnamoorthi PeriasamyKrishnamoorthi Periasamy
Laura,

Create a seperate class - please don't add the above mentioned code into the trigger.
Laura BrockLaura Brock
I feel like I’m so close! I added the new Apex Class but when I run the test, it is failing: System.DmlException: Insert failed. First exception on row 0; first error: REQUIRED_FIELD_MISSING, Required fields are missing: [Year__c, Quarter__c]: [Year__c, Quarter__c] Class.TriggerTestClass.testMethodOne: line 10, column 1 I’m sure I’m missing something simple/easy…!?
Krishnamoorthi PeriasamyKrishnamoorthi Periasamy
Laura,

Looks like you have mandatory custom fields Year__c, Quarter__c in custom object Payroll_Checklist__c.  can i know what is datatype of these fields? 

 
Laura BrockLaura Brock
They are both text fields. Year is limited to 4 digits and quarter is limited to 1 digit.
Krishnamoorthi PeriasamyKrishnamoorthi Periasamy
Laura,

Please use below code in your test class.

@isTest 
public class TriggerTestClass 
{
    static testMethod void testMethodOne() 
    {
 
        Payroll_Checklist__c pc = new Payroll_Checklist__c();
        pc.Checklist_Complete__c=false;
        pc.Name = 'Test';
        pc.Year__c = '2017';
        pc.Quarter__c = '1';
        insert pc;
            
        task e = new task();
        e.Subject = 'Demo ';
        e.Description = 'Event created through Showing/Viewing';
        e.WhatId = pc.Id;
        e.status = 'Completed';
 
        insert e;

    }
}
 
This was selected as the best answer
Laura BrockLaura Brock
IT WORKED! Thank you so much!
Krishnamoorthi PeriasamyKrishnamoorthi Periasamy
could you please mark it as solved. Thanks