+ Start a Discussion
Claire SunderlandClaire Sunderland 

I need to build an Apex Class based on the following Trigger. I have never written an Apex Class and did not write the trigger. I am new to all this. I want it to delete any task that is status 'Completed' and subject 'Callback'.

trigger DeleteCompletedCallbackTaskTrigger on Task (after update) {
    for (Task task: Trigger.new) {
      if(task.status == 'Completed' && task.subject == 'Callback') {
        delete Task;
    }
  }
}
Best Answer chosen by Claire Sunderland
Amit Chaudhary 8Amit Chaudhary 8
Please post your full code and test class if any you created.

I will recommend you to start using trailhead to learn about test classes
1) https://trailhead.salesforce.com/modules/apex_testing

Also please check below post
1) https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_qs_test.htm
2) https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_testing_example.htm

Pleasse check below post sample test class
1) http://amitsalesforce.blogspot.com/2015/06/best-practice-for-test-classes-sample.html

You write a test class for this the same way that you would any other:
- Set up some data for the controller to access (Account, Contact etc)
- Execute a method/methods:- search
- Verify the behaviour with asserts.
 

Please update your Batch job like below
global class DeleteAllTask implements Database.Batchable<Sobject>,schedulable{
         
    global Database.queryLocator start(Database.BatchableContext bc)
	{
		String sSOQL = 'Select Id,Name,Status,Subject From Task Where status =\'Completed\' and subject=\'callback\' ' ;  
		if(test.isRunningTest()){
			sSOQL += ' limit 5 ';
		}
		return Database.getQueryLocator(sSOQL);
    }
    global void execute(Database.BatchableContext bc, List<Task> scope){
		Delete scope;
    }      
        
    global void finish(Database.BatchableContext bc){
    }
    
    global void execute(SchedulableContext sc){
        DeleteAllTask oDeleteAllTask = new DeleteAllTask();
        Database.executeBatch(oDeleteAllTask,50);
    }
}

Your test class should be like below
@isTest 
public class DeleteAllTaskBatchJob 
{
    static testMethod void testMethod1() 
    {
        List<Task> lstTask= new List<Task>();
        for(Integer i=0 ;i <200;i++)
        {
            Task oTask = new Task();
            oTask.Subject ='callback';
			oTask.Status = 'Completed';
			oTask.Priority='low';
			//OTHER REQUIRED FIELDS
            lstTask.add(oTask);
        }
        insert lstTask;
        
        Test.startTest();
		
            DeleteAllTask  obj = new DeleteAllTask ();
            DataBase.executeBatch(obj); 
			
        Test.stopTest();
        // Add Assert here to check result
    }
}

Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you
 

All Answers

Hemant_SoniHemant_Soni
Hi Claire Sunderland,

You need to delete perticuler task or all taks where stauts == completed and subject == callback.please tell me.

Thanks
Hemant
Claire SunderlandClaire Sunderland
All tasks where status == completed and subject == callback. Thanks!
Amit Chaudhary 8Amit Chaudhary 8
Please check below post for trigger framework
1) http://amitsalesforce.blogspot.com/2015/06/trigger-best-practices-sample-trigger.html


Create Apex class like below
public with sharing class TaskTriggerHandler
{
    public Static void OnAfterUpdate(List<Task > newTask )
    {
        List<Task> lstTaskToDelete = new List<Task>();
        
        for (Task task: Trigger.new)
        {
            if(task.status == 'Completed' && task.subject == 'Callback')
            {
                lstTaskToDelete.add(task);
            }    
        }
        
        if(lstTaskToDelete.size() > 0 )
        {
            delete lstTaskToDelete;
        }
        
    }
}    
Trigger should be like below
trigger DeleteCompletedCallbackTaskTrigger on Task (after update) 
{
	TaskTriggerHandler.OnAfterUpdate(Trigger.new);
}

Let us know if this will help you
 
Hemant_SoniHemant_Soni
Hi,
I think according to your requirment you need a batch which executes every night and delete all task where status and subject are according to your requirement.
For Example:
global class DeleteAllTask implements Database.Batchable<Sobject>,schedulable{
         
    global DeleteAllTask(){
        System.debug('@Developer --> DeleteAllTask -->');
        }
         
    global Database.queryLocator start(Database.BatchableContext bc){
        System.debug('@Developer --> DeleteAllTask --> start --> timestamp:' + system.now());
                 
                 String sSOQL = 'Select Id,Name,Status,Subject From Task Where status ='+'Completed'+' and subject='+'callback'+'';     
                 if(test.isRunningTest()){
                                  sSOQL += ' limit 5 ';
                 }
                         
                 System.debug('@Developer --> sSOQL:' + sSOQL);   
                 return Database.getQueryLocator(sSOQL);
    }
    global void execute(Database.BatchableContext bc, List<Task> scope){
        System.debug('@Developer --> DeleteAllTask --> execute --> timestamp:' + system.now());
        System.debug('@developer -- > scope:'+scope);
        if(scope.size()>0){
                list<Task> lstTask = new list<Task>();
        for(Task oTask:scope){
            lstTask.add(oTask);
        }
        if(lstTask.size()>0){
                delete lstTask;
           }
        }
    }      
        
    global void finish(Database.BatchableContext bc){
        System.debug('@Developer --> batchName --> finish --> timestamp:' + system.now());   
                  
    }
    
    global void execute(SchedulableContext sc){
        DeleteAllTask oDeleteAllTask = new DeleteAllTask();
        Database.executeBatch(oDeleteAllTask,50);
    }
}
Let me know if it not solve your problem.
If This helps you please mark it solved.
Thanks
Hemant
 
jigarshahjigarshah
Claire,

Any specific reason why you want to accomplish this as a Trigger. If this is just a cleanup activity to delete all the Completed Tasks with a specific Subject, I would recommend writing a batch job that runs daily at a specific time and deletes all the qualifyign tasks. If you have a specific reason which mandates you to use a trigger, you can use the code specified by Amit, only that it needs a minor update as shown below.
public with sharing class TaskTriggerHandler{

	public static void OnAfterUpdate(List<Task> newTask){

		List<Task> lstTaskToDelete = new List<Task>();
		
		for (Task task: newTask){
		
			if(task.status == 'Completed' && task.subject == 'Callback'){
				lstTaskToDelete.add(task)
			}
		}
		
		if(lstTaskToDelete.size() > 0 ){
			delete lstTaskToDelete;
		}
		
	}
}

@Amit, The only thing I want to modify in the specified Apex Trigger code is to use the newTask List variable within your for loop or not pass it at all since Trigger context variables are available throughout the execution context.

Please do not forget to mark this thread as SOLVED and answer as the BEST ANSWER if this answer helps address your issue.
Claire SunderlandClaire Sunderland
Ok thank you for all your help.  I am working on writing the test class now to test the code.  As I said I am new to all of this, it's my first time coding.  I am using the batch udpate class.  Here's what I have for the test so far but I don't know if I'm even on the right track.  Does anyone have feedback for the test?

@isTest
private class TestDeleteAllCompletedCallbackTask {

//-- Tests DeleteAllCompletedCallbackTask.class.isbatch
    static testMethod void validateDeleteAllCompletedCallbackTask(){
        is delete Task ; delete Task (Status = 'Completed', Subject = 'Callback')
        
        //Insert new task
            insert Task;
                new task (Status = 'Open', Subject = 'Callback')
        
        //Update task
            update Task;
                task = (Status = 'Completed', Subject = 'Callback')
        
        //Delete task
            delete Task;
                task = (Status = 'Completed', Subject = 'Callback')
Hemant_SoniHemant_Soni
Hi Clair,
Please try below code.
@isTest 
public class DeleteAllTaskBatchJob 
{
    static testMethod void testMethod1() 
    {
        List<Task> lstTask= new List<Task>();
        for(Integer i=0 ;i <200;i++)
        {
            Task oTask = new Task();
            oTask.Subject ='callback'+i;
												oTask.Status = 'Completed';
            lstTask.add(oTask);
        }
        
        insert lstTask;
        
        Test.startTest();

            DeleteAllTask  obj = new DeleteAllTask ();
            DataBase.executeBatch(obj); 
            
        Test.stopTest();
    }
}
And Please mark it solved.
Thanks
Hemant
 
Claire SunderlandClaire Sunderland
This is the error I'm getting when I run the test then:

User-added image
Amit Chaudhary 8Amit Chaudhary 8
Please post your full code and test class if any you created.

I will recommend you to start using trailhead to learn about test classes
1) https://trailhead.salesforce.com/modules/apex_testing

Also please check below post
1) https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_qs_test.htm
2) https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_testing_example.htm

Pleasse check below post sample test class
1) http://amitsalesforce.blogspot.com/2015/06/best-practice-for-test-classes-sample.html

You write a test class for this the same way that you would any other:
- Set up some data for the controller to access (Account, Contact etc)
- Execute a method/methods:- search
- Verify the behaviour with asserts.
 

Please update your Batch job like below
global class DeleteAllTask implements Database.Batchable<Sobject>,schedulable{
         
    global Database.queryLocator start(Database.BatchableContext bc)
	{
		String sSOQL = 'Select Id,Name,Status,Subject From Task Where status =\'Completed\' and subject=\'callback\' ' ;  
		if(test.isRunningTest()){
			sSOQL += ' limit 5 ';
		}
		return Database.getQueryLocator(sSOQL);
    }
    global void execute(Database.BatchableContext bc, List<Task> scope){
		Delete scope;
    }      
        
    global void finish(Database.BatchableContext bc){
    }
    
    global void execute(SchedulableContext sc){
        DeleteAllTask oDeleteAllTask = new DeleteAllTask();
        Database.executeBatch(oDeleteAllTask,50);
    }
}

Your test class should be like below
@isTest 
public class DeleteAllTaskBatchJob 
{
    static testMethod void testMethod1() 
    {
        List<Task> lstTask= new List<Task>();
        for(Integer i=0 ;i <200;i++)
        {
            Task oTask = new Task();
            oTask.Subject ='callback';
			oTask.Status = 'Completed';
			oTask.Priority='low';
			//OTHER REQUIRED FIELDS
            lstTask.add(oTask);
        }
        insert lstTask;
        
        Test.startTest();
		
            DeleteAllTask  obj = new DeleteAllTask ();
            DataBase.executeBatch(obj); 
			
        Test.stopTest();
        // Add Assert here to check result
    }
}

Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you
 
This was selected as the best answer
Claire SunderlandClaire Sunderland
Great thank you - I have looked some into Trailhead but need to do more definitely.  I will check out all those resources.  Let me know if you have any other recommendations for training on Apex triggers, classes, and tests.
Hemant_SoniHemant_Soni
Hi,
I had made mistake in batch.
Try below
global class DeleteAllTask implements Database.Batchable<Sobject>{
         
    global DeleteAllTask(){
        System.debug('@Developer --> DeleteAllTask -->');
        }
         
    global Database.queryLocator start(Database.BatchableContext bc){
        System.debug('@Developer --> DeleteAllTask --> start --> timestamp:' + system.now());
                 
                 String sSOQL = 'Select Id,Status,Subject From Task Where status =\''+'Completed'+'\' and subject=\''+'callback'+'\''; 
                 system.debug('sSOQL :'+sSOQL );    
                 if(test.isRunningTest()){
                                  sSOQL += ' limit 5 ';
                 }
                         
                 System.debug('@Developer --> sSOQL:' + sSOQL);   
                 return Database.getQueryLocator(sSOQL);
    }
    global void execute(Database.BatchableContext bc, List<Task> scope){
        System.debug('@Developer --> DeleteAllTask --> execute --> timestamp:' + system.now());
        System.debug('@developer -- > scope:'+scope);
        if(scope.size()>0){
                list<Task> lstTask = new list<Task>();
        for(Task oTask:scope){
            lstTask.add(oTask);
        }
        if(lstTask.size()>0){
                delete lstTask;
           }
        }
    }      
        
    global void finish(Database.BatchableContext bc){
        System.debug('@Developer --> batchName --> finish --> timestamp:' + system.now());   
                  
    }
}
And Test CLass is Same as Above.
And please dont forgot to Marked as solved.
Thanks
Hemant


 
jigarshahjigarshah
Claire,

Trailhead is the best way to get your self started and become mroe handson with Apex coding and custom development. You can try the Developer - Beginner trail to get started and then progress through the Intermediate and Advanced Levels as you progress and become more comfortable.
Claire SunderlandClaire Sunderland
Amit - I'm not able to get code coverage with this.  It is passing the test but I'm only at 72% code coverage.  Do you have any suggestions?
Amit Chaudhary 8Amit Chaudhary 8
Please check below post to write test class for scheduler
1) http://amitsalesforce.blogspot.com/2017/07/how-to-write-test-class-for-scheduler.html

Try below code
@isTest 
public class DeleteAllTaskBatchJob 
{
    static testMethod void testMethod1() 
    {
        List<Task> lstTask= new List<Task>();
        for(Integer i=0 ;i <200;i++)
        {
            Task oTask = new Task();
            oTask.Subject ='callback';
			oTask.Status = 'Completed';
			oTask.Priority='low';
			//OTHER REQUIRED FIELDS
            lstTask.add(oTask);
        }
        insert lstTask;
        
        Test.startTest();
			
			String CRON_EXP = '0 0 0 15 3 ? *';


            String jobId = System.schedule('DeleteAllTaskTest1',  CRON_EXP, new DeleteAllTask());
            CronTrigger ct = [SELECT Id, CronExpression, TimesTriggered, NextFireTime FROM CronTrigger WHERE id = :jobId];
            System.assertEquals(CRON_EXP, ct.CronExpression);
            System.assertEquals(0, ct.TimesTriggered);

			
        Test.stopTest();
        // Add Assert here to check result
    }
}

 
Claire SunderlandClaire Sunderland
Awesome - thanks, Amit!  That seemed to work.  Thanks for your help!