+ Start a Discussion
learn_sfdclearn_sfdc 

Error: Compile Error: Variable does not exist: Id at line 9 column 9

Hi,

I am new to Trigger, i have tried writing simple trigger, but don't know what is the problem.

trigger Contact on Account (after update) {

for(Account acc : Trigger.new){
         
    Contact con = new Contact();
    con.FirstName = 'test';
    con.Lastname  = 'name';
    con.AccountID  = acc.id;
    
      insert con;

     }

}
Gokula KrishnanGokula Krishnan
Correct your syntax, trigger can be written in one object only. In your code, you used contact and account, i think you need to write trigger on Account.
And
you should not do DML operation inside loop(Insert/delete/update operation should not happen inside loop).

Syntax:
trigger TriggerName on ObjectName (trigger_events) {
code_block
}

Rewrite code as:

trigger AccountTrigger on Account (after update) {

    List<contact> UpdateCont = new List<contact>();
    for(Account acc : Trigger.new){
        Contact con = new Contact();
        con.FirstName = 'test';
        con.Lastname  = 'name';
        con.AccountID  = acc.id;
        UpdateCont.add(con);
    }
    
    if(UpdateCont.size()>0)
        insert UpdateCont;

}


Referencehttps://trailhead.salesforce.com/en/modules/apex_triggers/units/apex_triggers_intro

If this helps you, mark it as best answer, so other developers can follow.
learn_sfdclearn_sfdc
Hello Gokul,

Thank you for response but for some reason its not working, its same error.


Error: Compile Error: Variable does not exist: id at line 8 column 30
Amit Chaudhary 8Amit Chaudhary 8
Hi Learn_sfdc,

It look like you created any Apex class with Account or Contact Name ?
If yes then please rename the same or delete same and try below code
trigger Contact on Account (after update) {


	List<Contact> lstContact = new List<Contact>();

    for(Account acc : Trigger.new)
    {
        Contact con = new Contact();
        con.FirstName = 'test';
        con.Lastname  = 'name';
        con.AccountID  = acc.id;

		lstContact.add(con);
    }
	
	if(lstContact.size() > 0 )
	{
		insert lstContact;
	}
}

Trigger Best Practices | Sample Trigger Example | Implementing Trigger Framework
http://amitsalesforce.blogspot.com/2015/06/trigger-best-practices-sample-trigger.html
1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org. 

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers

4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail

Let us know if this will help you

 
Gokula KrishnanGokula Krishnan
Check this,
con.Account.id  = acc.id;
 
Sharad SoniSharad Soni
Hi Learn_sfdc

The following code is running correctly

trigger Trigger_Account on Account (after update) {

        
        List<Contact> conList = new List<Contact>();
        for(Account acc: Trigger.new) {
            
            Contact con = new Contact();
            con.FirstName = 'Test';
            con.LastName = 'Demo';
            con.AccountId = acc.Id;
            conList.add(con);
            
        }
        if(conList != null && conList.size() > 0)
            insert conList;
    
}

Please mark it best answer if you find it helpful.
Thanks.
Akshay_DhimanAkshay_Dhiman
Hi learn_sfdc,
Below is the Code.
//--------------------------------Trigger-------------------------------------------

trigger ContactTri on Account (after update) 
{
	List<Contact> conlist = new List<Contact>();
	for(Account acc:Trigger.New)
   	{
        Contact con = new Contact();
        con.LastName = 'test';
        con.AccountId = acc.Id;
        conlist.add(con);
    }
  	if(conlist.size() > 0)
    {
		Insert conlist;
    }
}
Hope It will help you!
If this answers your query please mark this question as a solved so that it can be filtered out from unsolved questions.

Regards,
Akshay