function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
Cameron HouserCameron Houser 

Help! Attempting to dereference a null object. in test class

I am getting a Attempting to dereference a null object in my test. I am new to Test writing and have not ficured out how to pass the test account into the test controller. 
 
public class CustomerInfoSheet {
    public String PrintOut { get; set; }
    public String LookupID;
    public String LookupType;
    
    
     public CustomerInfoSheet() {
        LookupID = ApexPages.currentPage().getParameters().get('id');
        LookupType = ApexPages.currentPage().getParameters().get('l');
        List<Account> a;
        
        PrintOut = '';      
        
                  
        if (LookupType == 'a' ){
            a = [select Name,  Industry, Type from Account where Id = :LookupID];
        } 
        if (LookupType == 'z' ) {
            a = [select Name, Industry, Type from Account where Zone__c = :LookupID];
        }
 
       //Industry
         {myPicklist.clear();
             Schema.DescribeFieldResult field = Account.Industry.getDescribe();
            for (Schema.PicklistEntry f : field.getPicklistValues()){
             myPicklist.add(f.getLabel());}
             }
         string test104 = '';
         for (String str : myPicklist)
         {test104 += str + ' -/- ';}
         test104 = test104.removeEnd(' -/- ');
         String Industrylist = String.valueOf('No Value Selected - Please Select one now: '+ test104);
         
         
               
        String CustomerName = '';
        
        String Industry = '';
      
        if (!a.isEmpty()){
            for (Account CustomerInfo : a) {
                
                CustomerName = CustomerInfo.Name;
                              
                 if (!(CustomerInfo.Industry == null)) { Industry = CustomerInfo.Industry; } else { Industry = Industrylist;}
                              
                PrintOut += '<div style="page-break-after:always;">';
                PrintOut += '<strong>Company: </strong>';
                PrintOut += CustomerName;
                 PrintOut += '<br/>';
                PrintOut += '<br/>';
                PrintOut += '<strong>Industry: </strong>';
                PrintOut += Industry;
              }
        }
    }    
}
​@IsTest
    public class CustomerInfoSheetTest {
        
     static testMethod void testCustomerInfoSheet() {

                          Account acct = (Account)Account.sObjectType.newSObject(null, true);
                         acct.Name='TestAccount';                 
                         acct.Industry = 'AG';
                          insert acct;
                         system.debug('account inserted '+acct.Id);
                     ApexPages.currentPage().getParameters().put('id', acct.Id);
                 system.debug('Account Fields '+acct);

                  CustomerInfoSheet ac = new CustomerInfoSheet(); // attempting to dereference a null object here. 
    system.debug('CustomerInfoSheet'+ac);
 }    
}

 
Best Answer chosen by Cameron Houser
Amit Chaudhary 8Amit Chaudhary 8
Please try below test class
​@IsTest
public class CustomerInfoSheetTest 
{
	static testMethod void testCustomerInfoSheet() 
	{
		Account acct = new Account();
		acct.Name='TestAccount';                 
		acct.Industry = 'AG';
		insert acct;
		system.debug('account inserted '+acct.Id);
		

		Test.StartTest();	


			PageReference pageRef = Page.customerinfosheet; 
			pageRef.getParameters().put('id', String.valueOf(acct.Id));
			pageRef.getParameters().put('l', 'a');
			Test.setCurrentPage(pageRef);

			CustomerInfoSheet ac = new CustomerInfoSheet();

		Test.StopTest();
	}    
}

Let us know if this will help you
 

All Answers

Heather ThompsonHeather Thompson
You are calling the custom class which gets a parameter from the page without setting the parameter.

You should add something like:
pageRef.getParameters().put('id',acct.ID);
pageRef.getParameters().put('l','parameter for l');



 
Amit Chaudhary 8Amit Chaudhary 8
I will recommend you to start using trailhead to learn about test classes
1) https://trailhead.salesforce.com/modules/apex_testing

Also please check below post
1) https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_qs_test.htm
2) https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_testing_example.htm

Please check below for sample test classes
1) http://amitsalesforce.blogspot.com/2015/06/best-practice-for-test-classes-sample.html

Sample text class to start
​@IsTest
    public class CustomerInfoSheetTest {
        
	static testMethod void testCustomerInfoSheet() {

			Account acct = new Account();
			acct.Name='TestAccount';                 
			acct.Industry = 'AG';
			insert acct;
			
			system.debug('account inserted '+acct.Id);
			ApexPages.currentPage().getParameters().put('id', acct.Id);
			ApexPages.currentPage().getParameters().put('l', 'a'); // You need to set this


			CustomerInfoSheet ac = new CustomerInfoSheet();
			system.debug('CustomerInfoSheet'+ac);
			
	}    
}


Please follow below salesforce Best Practice for Test Classes :-
1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .

Please let us know if this post will help you
Cameron HouserCameron Houser
I worked this out to the same result result :(. Other thing I should point out, the VF page does not take input in its fields. 
the url the test class is producing: 
DEBUG|pageRef: System.PageReference[/apex/customerinfosheet?id=0010S000008LqvZQAS&l=TestAccount]
sample VF page of a rendered PDF: https://c.cs54.visual.force.com/apex/CustomerInfoSheet?l=a&id=0010S000008LYFv
Test.startTest();
         PageReference pageRef = Page.CustomerInfoSheet; 

			system.debug('account inserted '+acct.Id);
			pageRef.getParameters().put('id', acct.Id);
			pageRef.getParameters().put('l', acct.Name); 
			system.debug('ID: '+acct.Id + ' Name: '+acct.Name);
        Test.setCurrentPage(pageRef);
        system.debug('pageRef: '+pageRef);

			CustomerInfoSheet ac = new CustomerInfoSheet();
			system.debug('CustomerInfoSheet'+ac);
		Test.stopTest();

 
Cameron HouserCameron Houser
VF:
<apex:page sidebar="false" showHeader="false" controller="CustomerInfoSheet" renderAs="pdf">
  <apex:outputText value="{!PrintOut}" escape="false" />
</apex:page>

 
Amit Chaudhary 8Amit Chaudhary 8
Please try below test class
​@IsTest
public class CustomerInfoSheetTest 
{
	static testMethod void testCustomerInfoSheet() 
	{
		Account acct = new Account();
		acct.Name='TestAccount';                 
		acct.Industry = 'AG';
		insert acct;
		system.debug('account inserted '+acct.Id);
		

		Test.StartTest();	


			PageReference pageRef = Page.customerinfosheet; 
			pageRef.getParameters().put('id', String.valueOf(acct.Id));
			pageRef.getParameters().put('l', 'a');
			Test.setCurrentPage(pageRef);

			CustomerInfoSheet ac = new CustomerInfoSheet();

		Test.StopTest();
	}    
}

Let us know if this will help you
 
This was selected as the best answer
Cameron HouserCameron Houser
Amit, That worked! Thank you so much! I have been working on this for 3 days. Could you explain to me why you used String.valueOf(String.valueOf(acct.Id)) vs acct.Id. And why the 'a' (was that for the first if statement?)