function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
Tasia Demuth 4Tasia Demuth 4 

Help with Test Class for Lead Conversion and Case Update

Hello!

In our org, we associate customer service cases to leads. I wrote a trigger to update a case associated with a lead with contact information when a lead is converted. However, I am having trouble with the test class. Any help is greatly appreciated. Below is the code. 

Trigger: 

trigger UpdateCaseWhenLeadConverted on Lead (after update) {
    if(Trigger.isAfter && Trigger.isUpdate)
    {
       List<Case> lstCase = new List<Case>();
        Set<Id> convertedLeads = new Set<Id>();
        id convertcontact;
        for(Lead objLead : Trigger.new)
        {
            if(objLead.isConverted)
                convertedLeads.add(objLead.Id);
                convertcontact = objLead.ConvertedContactId;
        }
        for(Case objCase : [SELECT Lead__c FROM Case WHERE Lead__c IN : convertedLeads])    
        {
            objCase.Lead__c = null;
            objCase.ContactId = convertcontact;
            lstCase.add(objCase);
        }
        update lstCase;
    }
}

Test Class:
@isTest
public class UpdateCaseWhenLeadConvertedTest {

    private static testMethod void LeadConvertedTest(){
        //create a Lead
        Lead lead=new Lead(LastName='Test',FirstName='Tester',Status='Known');
        insert lead;
        lead= [SELECT Id, Status FROM Lead Where Id = :lead.Id];
        // create a Case
        Id RecordTypeIdCase = Schema.SObjectType.Case.getRecordTypeInfosByName().get('Customer_Service_Record_Type').getRecordTypeId();
        Case cscase=new Case(RecordTypeId= RecordTypeIdCase, Lead__c = lead.Id);
        //update Lead
        Database.LeadConvert convertlead = new database.LeadConvert();
        convertlead.setLeadId(lead.Id);
        LeadStatus convertStatus = [SELECT Id, MasterLabel FROM LeadStatus WHERE IsConverted=true];
        convertlead.setConvertedStatus(convertStatus.MasterLabel);
        Database.LeadConvertResult lcr = Database.convertLead(convertlead);
        System.assert(lcr.isSuccess());
        //test if case is updated
        lead= [SELECT ConvertedContactId, Id FROM Lead Where Id = :lead.Id];
        cscase= [SELECT ContactId FROM Case WHERE Lead__c = :lead.Id];
        System.assertEquals('lead.ConvertedContactId','cscase.ContactId' );
    }
}
 
Best Answer chosen by Tasia Demuth 4
Amit Chaudhary 8Amit Chaudhary 8
Hi Tasia Demuth 4 ,

I will recommend you to bulky your Trigger like below as your trigger was handling the single convertcontact only
trigger UpdateCaseWhenLeadConverted on Lead (after update) {
    if(Trigger.isAfter && Trigger.isUpdate)
    {
       List<Case> lstCase = new List<Case>();
        Set<Id> convertedLeads = new Set<Id>();
        id convertcontact;
        Map<String,String> mapLeadWiseCont = new Map<String,String>();
        for(Lead objLead : Trigger.new)
        {
            if(objLead.isConverted)
            {
                convertedLeads.add(objLead.Id);
                //convertcontact = objLead.ConvertedContactId;
                mapLeadWiseCont.put( objLead.Id , objLead.ConvertedContactId);
            }    
        }
        
        for(Case objCase : [SELECT Lead__c,ContactId FROM Case WHERE Lead__c IN : convertedLeads])    
        {
            
            if(mapLeadWiseCont.containsKey(objCase.Lead__c))
            {
                String strContId = mapLeadWiseCont.get(objCase.Lead__c);
                objCase.Lead__c = null;
                //objCase.ContactId = convertcontact;
                objCase.ContactId = strContId;
                lstCase.add(objCase);
            }
        }    
        update lstCase;
    }
}

Always add Assert in Test Class

Please update your test class like below
@isTest
public class UpdateCaseWhenLeadConvertedTest 
{
    private static testMethod void LeadConvertedTest()
    {
        Lead olead = new Lead(LastName='Test',FirstName='Tester',Status='Known',Company='test');
        insert olead;

        Case c = new case (Status ='New', Priority = 'Medium', Origin = 'Email');
        c.Lead__c = olead.Id;

        insert c ;

        Database.LeadConvert lc = new database.LeadConvert();
        lc.setLeadId(olead.id);
        lc.setDoNotCreateOpportunity(false);
        lc.setConvertedStatus('Closed - Converted');

        Database.LeadConvertResult lcr = Database.convertLead(lc);
        System.assert(lcr.isSuccess());
        
        
        List<Case> lstCase = [Select id ,ContactId from Case where id =:c.id ];
        System.assert(lstCase.size() > 0 );
        System.assert(lstCase[0].ContactId !=null );
        
        
    }
}
I will recommend you to start using trailhead to learn about test classes
1) https://trailhead.salesforce.com/modules/apex_testing

Also please check below post
1) https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_qs_test.htm
2) https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_testing_example.htm

Please check below for sample test classes
1) http://amitsalesforce.blogspot.com/2015/06/best-practice-for-test-classes-sample.html

Please follow below salesforce Best Practice for Test Classes :-
1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .

Please let us know if this post will help you

All Answers

Amit Chaudhary 8Amit Chaudhary 8
Hi Tasia Demuth 4 ,

I will recommend you to bulky your Trigger like below as your trigger was handling the single convertcontact only
trigger UpdateCaseWhenLeadConverted on Lead (after update) {
    if(Trigger.isAfter && Trigger.isUpdate)
    {
       List<Case> lstCase = new List<Case>();
        Set<Id> convertedLeads = new Set<Id>();
        id convertcontact;
        Map<String,String> mapLeadWiseCont = new Map<String,String>();
        for(Lead objLead : Trigger.new)
        {
            if(objLead.isConverted)
            {
                convertedLeads.add(objLead.Id);
                //convertcontact = objLead.ConvertedContactId;
                mapLeadWiseCont.put( objLead.Id , objLead.ConvertedContactId);
            }    
        }
        
        for(Case objCase : [SELECT Lead__c,ContactId FROM Case WHERE Lead__c IN : convertedLeads])    
        {
            
            if(mapLeadWiseCont.containsKey(objCase.Lead__c))
            {
                String strContId = mapLeadWiseCont.get(objCase.Lead__c);
                objCase.Lead__c = null;
                //objCase.ContactId = convertcontact;
                objCase.ContactId = strContId;
                lstCase.add(objCase);
            }
        }    
        update lstCase;
    }
}

Always add Assert in Test Class

Please update your test class like below
@isTest
public class UpdateCaseWhenLeadConvertedTest 
{
    private static testMethod void LeadConvertedTest()
    {
        Lead olead = new Lead(LastName='Test',FirstName='Tester',Status='Known',Company='test');
        insert olead;

        Case c = new case (Status ='New', Priority = 'Medium', Origin = 'Email');
        c.Lead__c = olead.Id;

        insert c ;

        Database.LeadConvert lc = new database.LeadConvert();
        lc.setLeadId(olead.id);
        lc.setDoNotCreateOpportunity(false);
        lc.setConvertedStatus('Closed - Converted');

        Database.LeadConvertResult lcr = Database.convertLead(lc);
        System.assert(lcr.isSuccess());
        
        
        List<Case> lstCase = [Select id ,ContactId from Case where id =:c.id ];
        System.assert(lstCase.size() > 0 );
        System.assert(lstCase[0].ContactId !=null );
        
        
    }
}
I will recommend you to start using trailhead to learn about test classes
1) https://trailhead.salesforce.com/modules/apex_testing

Also please check below post
1) https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_qs_test.htm
2) https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_testing_example.htm

Please check below for sample test classes
1) http://amitsalesforce.blogspot.com/2015/06/best-practice-for-test-classes-sample.html

Please follow below salesforce Best Practice for Test Classes :-
1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .

Please let us know if this post will help you
This was selected as the best answer
Tasia Demuth 4Tasia Demuth 4
Thank you both for your help. I am still consistently getting 66% code coverage. Maybe there is something wrong with how we are testing if the lead is converted?

The lines not covered are: 

convertedLeads.add(objLead.Id)

{
objCase.Lead__c = null;
objCase.ContactId = convertcontact;
lstCase.add(objCase);
}

 
Amit Chaudhary 8Amit Chaudhary 8
did you updated your Trigger like above code which i posted ?
Tasia Demuth 4Tasia Demuth 4
Yes so when I updated my trigger and my class to the code you provided, I received only 55% coverage. The lines not covered are below. So then I was trying to figure out if maybe there was a middle ground and started playing with the trigger again with some of the pieces I had written and some that you had written.  

convertedLeads.add(objLead.Id);
mapLeadWiseCont.put(objLead.Id, objLead.ConvertContactId);


{
if(mapLeadWiseCont.containsKey(objCase.Lead__c))
{
String strContId = mapLeadWiseCont.get(objCase.Lead__c);
objCase.Lead__c = null;
objCase.ContactId = strContId;
lstCase.add(objCase);
}
}
Amit Chaudhary 8Amit Chaudhary 8
I tested the sam trigger and test class i am getting 100% code coverage

User-added image
Test class
@isTest
public class UpdateCaseWhenLeadConvertedTest 
{
    private static testMethod void LeadConvertedTest()
    {
        Lead olead = new Lead(LastName='Test',FirstName='Tester',Status='Known',Company='test');
        insert olead;

        Case c = new case (Status ='New', Priority = 'Medium', Origin = 'Email');
        c.Lead__c = olead.Id;

        insert c ;

        Database.LeadConvert lc = new database.LeadConvert();
        lc.setLeadId(olead.id);
        lc.setDoNotCreateOpportunity(false);
        lc.setConvertedStatus('Closed - Converted');

        Database.LeadConvertResult lcr = Database.convertLead(lc);
        System.assert(lcr.isSuccess());
        
        
        List<Case> lstCase = [Select id ,ContactId from Case where id =:c.id ];
        System.assert(lstCase.size() > 0 );
        System.assert(lstCase[0].ContactId !=null );
        
        
    }
}


You are getting any error in test class
 
Tasia Demuth 4Tasia Demuth 4
I found the error! I was receiving an error because I had mis-typed my ConvertedStatus. 

Thanks you so much for your help!

I now have 100% coverage. 

Tasia