function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
SFDC Admin 56SFDC Admin 56 

how to bulkify trigger.

I am trying to Bulkify this trigger as we will use data loader in future to insert value in Primary sales rep field and with this existing code this trigger will fail, can you please hepl me in changing the code so that it will not hit governer limits.\

Here i am deleting the sharing permission for the previous assigned user and giving sharing permission to new user.

trigger Sharingupdate on Account (after update) {

    

     

        if(trigger.isUpdate){
            for (Account a : Trigger.old ){
                List<Legal_Doc__c> legaldocu = [Select id From Legal_Doc__c where Accounts__c= : a.id];
                List<Legal_Doc__Share> legdoc = [Select UserOrGroupId From Legal_Doc__Share Where UserOrGroupId =: a.Primary_Sales_Rep2__c and ParentId = :legaldocu ];
        
                                            
                    if(legdoc!= null){
        
                         Delete legdoc;
                                     }
                                    }     
                              } 
        
        
                                    
        
        
         Legal_Doc__Share PrimarysalesrepShr;
         PrimarysalesrepShr = new Legal_Doc__Share();
                   

        
    List<Legal_Doc__Share> legalShrs  = new List<Legal_Doc__Share>();
        for (Account an : Trigger.new ){
        
       
          Legal_Doc__c legaldocum = [Select id From Legal_Doc__c where Accounts__c= :an.id];
               

                    PrimarysalesrepShr.ParentId = legaldocum.Id;
                    PrimarysalesrepShr.UserOrGroupId = an.Primary_Sales_Rep2__c ;
                    PrimarysalesrepShr.AccessLevel = 'edit';

         
                                        }
                          insert PrimarysalesrepShr ;
                                                     }
Best Answer chosen by SFDC Admin 56
Amit Chaudhary 8Amit Chaudhary 8
Please try below code
trigger Sharingupdate on Account (after update) 
{

	if(trigger.isUpdate)
	{
		Set<Id> setAcc = new Set<Id>();
		Set<String> setPrimSal= new Set<String>();
		for (Account a : Trigger.old )
		{
			setAcc.add(a.id);
			setPrimSal.add(a.Primary_Sales_Rep2__c);
		}
		
		List<Legal_Doc__c> legaldocu = [Select id From Legal_Doc__c where Accounts__c in : setAcc];
		List<Legal_Doc__Share> legdoc = [Select UserOrGroupId From Legal_Doc__Share Where UserOrGroupId in :setPrimSal and ParentId = :legaldocu ];
	
		if(legdoc!= null)
		{
			Delete legdoc;
		}
	} 
        
	List<Legal_Doc__Share> ListPrimarysalesrepShr = new List<Legal_Doc__Share>();
                   
    Set<ID> setAccId = new Set<Id>();
	for (Account an : Trigger.new )
	{
		setAccId.add(an.id);
	}
    List<Legal_Doc__c> Listlegaldocum = [Select id,Accounts__c From Legal_Doc__c where Accounts__c in :setAccId];
    Map<Id,Legal_Doc__c> mapAccWiseLegalIDoc = new Map<Id,Legal_Doc__c>();           
	for(Legal_Doc__c leg : Listlegaldocum)
	{
		mapAccWiseLegalIDoc.put(leg.Accounts__c,leg);
	}
	
	for (Account an : Trigger.new )
	{
		
		If(mapAccWiseLegalIDoc.containsKey(an.Id))
		{
			Legal_Doc__Share PrimarysalesrepShr = new Legal_Doc__Share();
			PrimarysalesrepShr.ParentId = mapAccWiseLegalIDoc.get(an.Id).Id;
			PrimarysalesrepShr.UserOrGroupId = an.Primary_Sales_Rep2__c ;
			PrimarysalesrepShr.AccessLevel = 'edit';
			
			ListPrimarysalesrepShr.add(PrimarysalesrepShr);
		}
    }
	
	if(ListPrimarysalesrepShr.size() > 0 )
	{
		insert ListPrimarysalesrepShr ;
	}
}

Please check below post to learn about trigger best pratice
1) http://amitsalesforce.blogspot.com/2015/06/trigger-best-practices-sample-trigger.html

1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org.

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers

4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail

Let us know if this will help you

All Answers

Amit Chaudhary 8Amit Chaudhary 8
Please try below code
trigger Sharingupdate on Account (after update) 
{

	if(trigger.isUpdate)
	{
		Set<Id> setAcc = new Set<Id>();
		Set<String> setPrimSal= new Set<String>();
		for (Account a : Trigger.old )
		{
			setAcc.add(a.id);
			setPrimSal.add(a.Primary_Sales_Rep2__c);
		}
		
		List<Legal_Doc__c> legaldocu = [Select id From Legal_Doc__c where Accounts__c in : setAcc];
		List<Legal_Doc__Share> legdoc = [Select UserOrGroupId From Legal_Doc__Share Where UserOrGroupId in :setPrimSal and ParentId = :legaldocu ];
	
		if(legdoc!= null)
		{
			Delete legdoc;
		}
	} 
        
	List<Legal_Doc__Share> ListPrimarysalesrepShr = new List<Legal_Doc__Share>();
                   
    Set<ID> setAccId = new Set<Id>();
	for (Account an : Trigger.new )
	{
		setAccId.add(an.id);
	}
    List<Legal_Doc__c> Listlegaldocum = [Select id,Accounts__c From Legal_Doc__c where Accounts__c in :setAccId];
    Map<Id,Legal_Doc__c> mapAccWiseLegalIDoc = new Map<Id,Legal_Doc__c>();           
	for(Legal_Doc__c leg : Listlegaldocum)
	{
		mapAccWiseLegalIDoc.put(leg.Accounts__c,leg);
	}
	
	for (Account an : Trigger.new )
	{
		
		If(mapAccWiseLegalIDoc.containsKey(an.Id))
		{
			Legal_Doc__Share PrimarysalesrepShr = new Legal_Doc__Share();
			PrimarysalesrepShr.ParentId = mapAccWiseLegalIDoc.get(an.Id).Id;
			PrimarysalesrepShr.UserOrGroupId = an.Primary_Sales_Rep2__c ;
			PrimarysalesrepShr.AccessLevel = 'edit';
			
			ListPrimarysalesrepShr.add(PrimarysalesrepShr);
		}
    }
	
	if(ListPrimarysalesrepShr.size() > 0 )
	{
		insert ListPrimarysalesrepShr ;
	}
}

Please check below post to learn about trigger best pratice
1) http://amitsalesforce.blogspot.com/2015/06/trigger-best-practices-sample-trigger.html

1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org.

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers

4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail

Let us know if this will help you
This was selected as the best answer
SFDC Admin 56SFDC Admin 56
Hi Amit, 

there is one issue, when the Primary sales rep field is changed to blank, it is giving an error.
Sharingupdate: execution of AfterUpdate caused by: System.DmlException: Insert failed. First exception on row 0; first error: REQUIRED_FIELD_MISSING, Required fields are missing: [User/Group]: [User/Group]: ()
Amit Chaudhary 8Amit Chaudhary 8
Please add the null check in your code for Primary_Sales_Rep2__c  
SFDC Admin 56SFDC Admin 56
i did that but still throwing the same error.