function readOnly(count){ }
Sign Up ›
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
Learn More

Browse by Topic
ShowAll Questionssorted byDate Posted
+ Start a Discussion
Joshua MeyerJoshua Meyer 

Did I Bulkify This Code Correctly?

Hi Awesome Developers!

This is my first trigger (first one for a my job anyways) and I want to make sure I wrote it efficiently. My test class is yeidling the expected results. I'm basically putting a list of products families from active opportunities (closed won and in the subscription date range) on the Account object. I'm also putting Active MRR (monthly recurring revenue) on the account.

The part I have the question about is each time I go through the loop, I loop through every opportunity to ensure I only calculate on the opportunities related to the current account. It seems inefficient to me. Is there a better way to do this. Please don't hold back and critiques or observations as I am learning and appreciative! Thanks so much!
  
trigger UpdateProductMix on Account (before update) {
    //System.debug('Trigger Account ID: ' + acct.Id);
            
    List<Opportunity> opps = [SELECT id, Account.Id, Opportunity_MRR__c, (SELECT Id, PricebookEntry.Product2.Family FROM OpportunityLineItems) FROM Opportunity 
                              WHERE AccountId IN :Trigger.New AND StageName = 'Closed Won' 
                              AND Subscription_Start_Date__c <= TODAY 
                              AND Subscription_Current_Expiration_Date__c >= TODAY];
    
    for(Account acct:Trigger.New){
        //Initialize variables
        String prodMix = '';
        Set<String> families = new Set<String>();
        Decimal mrr = 0.00;
        
        // Process the query results
        for(Opportunity o:opps){
            if(acct.Id == o.AccountId){
                //System.debug('o.Opportunity_MRR__c' + o.Opportunity_MRR__c);
                mrr += o.Opportunity_MRR__c; //Add opp MRR of all active opps
                for(OpportunityLineItem oli:o.OpportunityLineItems){
                    if(!families.contains(oli.PricebookEntry.Product2.Family)){
                        //System.debug('oli.PricebookEntry.Product2.Family: ' + oli.PricebookEntry.Product2.Family);
                        families.add(oli.PricebookEntry.Product2.Family); //Add each unique product family to the set
                    }
                }
            }
        }
        
        acct.Active_MRR__c = mrr; //Set the MRR on the account
        
        List<String> famList = new List<String>(families); //Convert set to list so we can sort that bad boy
        famList.sort(); // Sort magic
        
        //Create the product mix string
        for(String family:famList){
            prodMix += family + ', ';
        }
        System.debug('prodMix.length: ' + prodMix.length());   
        if (prodMix.length() > 0){
            acct.Current_Products__c = prodMix.substring(0,prodMix.length()-2); //Trim the final comma and space and set
        } else{
            acct.Current_Products__c = 'No active products';
        }
        
    }
}

 
Best Answer chosen by Joshua Meyer
Amit Chaudhary 8Amit Chaudhary 8

Try to update your code like below 
trigger UpdateProductMix on Account (before update) 
{
    //System.debug('Trigger Account ID: ' + acct.Id);
    
	
	// Amit:- Query only required Opp record.
    List<Opportunity> opps = [SELECT id, AccountId, Opportunity_MRR__c, (SELECT Id, PricebookEntry.Product2.Family FROM OpportunityLineItems) FROM Opportunity 
                              WHERE AccountId IN :Trigger.New AND StageName = 'Closed Won' 
                              AND Subscription_Start_Date__c <= TODAY 
                              AND Subscription_Current_Expiration_Date__c >= TODAY AccountID IN : Trigger.newMap.keySet()];
    
	// Amit:- Use map to avoid for loop inside for loop
	Map<ID,List<Opportunity> > mapAccWiseOpp = new Map<ID,List<Opportunity> >();
	
	for(Opportunity opp : opps )
	{
		if(mapAccWiseOpp.containsKey(opp.AccountId))
		{
			List<Opportunity> lstOpp = mapAccWiseOpp.get(opp.AccountId);
			lstOpp.add(opp);
		}
		else{
			List<Opportunity> lstOpp = new List<Opportunity>();
			lstOpp.add(opp);
			mapAccWiseOpp.put(opp.AccountId,lstOpp );
		}
	}
	
	
    for(Account acct:Trigger.New)
	{
        String prodMix = '';
        Set<String> families = new Set<String>();
        Decimal mrr = 0.00;

		If(mapAccWiseOpp.containsKey(acct.id))
        {   //Amit:- Get related opp only.
			List<Opportunity> lstOpp = mapAccWiseOpp.get(acct.id);
			// Process the query results
			for(Opportunity o: lstOpp )
			{
					//System.debug('o.Opportunity_MRR__c' + o.Opportunity_MRR__c);
					mrr += o.Opportunity_MRR__c; //Add opp MRR of all active opps
					for(OpportunityLineItem oli:o.OpportunityLineItems)
					{
						if(!families.contains(oli.PricebookEntry.Product2.Family))
						{
							//System.debug('oli.PricebookEntry.Product2.Family: ' + oli.PricebookEntry.Product2.Family);
							families.add(oli.PricebookEntry.Product2.Family); //Add each unique product family to the set
						}
					}
			}
			
		}
		
        acct.Active_MRR__c = mrr; //Set the MRR on the account
        
        List<String> famList = new List<String>(families); //Convert set to list so we can sort that bad boy
        famList.sort(); // Sort magic
        
        //Create the product mix string
        for(String family:famList){
            prodMix += family + ', ';
        }
        System.debug('prodMix.length: ' + prodMix.length());   
        if (prodMix.length() > 0){
            acct.Current_Products__c = prodMix.substring(0,prodMix.length()-2); //Trim the final comma and space and set
        } else{
            acct.Current_Products__c = 'No active products';
        }
    }
}

Trigger Best Practices | Sample Trigger Example | Implementing Trigger Framework

1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org.

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers

4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail
http://amitsalesforce.blogspot.com/2015/06/trigger-best-practices-sample-trigger.html

Let us know if this will help you
 

All Answers

Raj VakatiRaj Vakati
Hi , Please modify your code as per the below code , See my comments also  
trigger UpdateProductMix on Account (before update) {
    //System.debug('Trigger Account ID: ' + acct.Id);
       // Query only what is required . Added Account ID Where Condiction     
    List<Opportunity> opps = [SELECT id, Account.Id, Opportunity_MRR__c, (SELECT Id, PricebookEntry.Product2.Family FROM OpportunityLineItems) FROM Opportunity 
                              WHERE AccountId IN :Trigger.New AND StageName = 'Closed Won' 
                              AND Subscription_Start_Date__c <= TODAY 
                              AND Subscription_Current_Expiration_Date__c >= TODAY AND AccountID IN : Trigger.newMap.keySet()];
							  
							  Map<Id ,Decimal> mrrMap = new Map<Id ,Decimal>();
							  Map<Id ,List<OpportunityLineItem>> mapOfLis = new Map<Id ,List<OpportunityLineItem>>();
							  
							  for(Opportunity o: opps){
								  if(mrrMap.contains(o.id)){
									  mrrMap.get(o.id)+  o.Opportunity_MRR__c ; 
								  }else{
									mrrMap.put(o.id ,  o.Opportunity_MRR__c )
								  }
								  if(mapOfLis.contains(o.id)){
									  mapOfLis.get(o.id).add(o.OpportunityLineItem) ; 
								  }else{
									mapOfLis.put(o.id ,  o.OpportunityLineItem )
								  }
							  }
							  
    
    for(Account acct:Trigger.New){
        //Initialize variables
        String prodMix = '';
        Set<String> families = new Set<String>();
        Decimal mrr = 0.00;
        acct.Active_MRR__c = mrrMap.get(acct.Id); //Set the MRR on the account
// Move this also to out side of the loop - OpportunityLineItem iteration 
// Whihc can be done with collection - Refer my code from 11 - 20 
        List<OpportunityLineItem> oliItems  =mapOfLis.get(acct.Id) ;
		  for( OpportunityLineItem oli: oliItems){
                    if(!families.contains(oli.PricebookEntry.Product2.Family)){
                        //System.debug('oli.PricebookEntry.Product2.Family: ' + oli.PricebookEntry.Product2.Family);
                        families.add(oli.PricebookEntry.Product2.Family); //Add each unique product family to the set
                    }
                }
        
		List<String> famList = new List<String>(families); //Convert set to list so we can sort that bad boy
        famList.sort(); // Sort magic
        //Create the product mix string
        for(String family:famList){
            prodMix += family + ', ';
        }
        System.debug('prodMix.length: ' + prodMix.length());   
        if (prodMix.length() > 0){
            acct.Current_Products__c = prodMix.substring(0,prodMix.length()-2); //Trim the final comma and space and set
        } else{
            acct.Current_Products__c = 'No active products';
        }
        
    }
}
Amit Chaudhary 8Amit Chaudhary 8

Try to update your code like below 
trigger UpdateProductMix on Account (before update) 
{
    //System.debug('Trigger Account ID: ' + acct.Id);
    
	
	// Amit:- Query only required Opp record.
    List<Opportunity> opps = [SELECT id, AccountId, Opportunity_MRR__c, (SELECT Id, PricebookEntry.Product2.Family FROM OpportunityLineItems) FROM Opportunity 
                              WHERE AccountId IN :Trigger.New AND StageName = 'Closed Won' 
                              AND Subscription_Start_Date__c <= TODAY 
                              AND Subscription_Current_Expiration_Date__c >= TODAY AccountID IN : Trigger.newMap.keySet()];
    
	// Amit:- Use map to avoid for loop inside for loop
	Map<ID,List<Opportunity> > mapAccWiseOpp = new Map<ID,List<Opportunity> >();
	
	for(Opportunity opp : opps )
	{
		if(mapAccWiseOpp.containsKey(opp.AccountId))
		{
			List<Opportunity> lstOpp = mapAccWiseOpp.get(opp.AccountId);
			lstOpp.add(opp);
		}
		else{
			List<Opportunity> lstOpp = new List<Opportunity>();
			lstOpp.add(opp);
			mapAccWiseOpp.put(opp.AccountId,lstOpp );
		}
	}
	
	
    for(Account acct:Trigger.New)
	{
        String prodMix = '';
        Set<String> families = new Set<String>();
        Decimal mrr = 0.00;

		If(mapAccWiseOpp.containsKey(acct.id))
        {   //Amit:- Get related opp only.
			List<Opportunity> lstOpp = mapAccWiseOpp.get(acct.id);
			// Process the query results
			for(Opportunity o: lstOpp )
			{
					//System.debug('o.Opportunity_MRR__c' + o.Opportunity_MRR__c);
					mrr += o.Opportunity_MRR__c; //Add opp MRR of all active opps
					for(OpportunityLineItem oli:o.OpportunityLineItems)
					{
						if(!families.contains(oli.PricebookEntry.Product2.Family))
						{
							//System.debug('oli.PricebookEntry.Product2.Family: ' + oli.PricebookEntry.Product2.Family);
							families.add(oli.PricebookEntry.Product2.Family); //Add each unique product family to the set
						}
					}
			}
			
		}
		
        acct.Active_MRR__c = mrr; //Set the MRR on the account
        
        List<String> famList = new List<String>(families); //Convert set to list so we can sort that bad boy
        famList.sort(); // Sort magic
        
        //Create the product mix string
        for(String family:famList){
            prodMix += family + ', ';
        }
        System.debug('prodMix.length: ' + prodMix.length());   
        if (prodMix.length() > 0){
            acct.Current_Products__c = prodMix.substring(0,prodMix.length()-2); //Trim the final comma and space and set
        } else{
            acct.Current_Products__c = 'No active products';
        }
    }
}

Trigger Best Practices | Sample Trigger Example | Implementing Trigger Framework

1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org.

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers

4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail
http://amitsalesforce.blogspot.com/2015/06/trigger-best-practices-sample-trigger.html

Let us know if this will help you
 
This was selected as the best answer
Joshua MeyerJoshua Meyer
Excellent and thank you to both of you. I will implement a map. I do have a question though. In the query I already have:
  
WHERE AccountId IN :Trigger.New

and you both added
  
AccountID IN : Trigger.newMap.keySet()
Aren't these redundant?
 
Amit Chaudhary 8Amit Chaudhary 8
Yes you can remove that. That id duplicate 
List<Opportunity> opps = [SELECT id, AccountId, Opportunity_MRR__c, (SELECT Id, PricebookEntry.Product2.Family FROM OpportunityLineItems) FROM Opportunity 
                              WHERE AccountId IN :Trigger.New AND StageName = 'Closed Won' 
                              AND Subscription_Start_Date__c <= TODAY 
                              AND Subscription_Current_Expiration_Date__c >= TODAY ];