+ Start a Discussion
Oliver Jones RajkumarOliver Jones Rajkumar 

Bulkified Code for my Apex Trigger

Hi All, 

I have the following code. I want a bulkified version for it. This trigger updates Opprtunity_Email__c custom field on Account with a recently inserted email from Opportunity_Email__c custom field in Opportunity.

trigger opportunityEmailonAccount_AT on Opportunity (after insert) {
    for(Opportunity opp : Trigger.new){
        Set<ID> accids = new Set<ID>();
        accids.add(opp.AccountId);
        Account acc = [Select Id,Name,Opportunity_Email__c From Account where Id in : accids];
        if(opp.Opportunity_Email__c != null && accids != null ) {
            acc.Opportunity_Email__c = opp.Opportunity_Email__c;
        }
        update acc;
    }
}
Best Answer chosen by Oliver Jones Rajkumar
Amit Chaudhary 8Amit Chaudhary 8
Hi Oilver,

I found below issue in your code
1) SOQL inside the for loop
2) DML inside the for loop

Please try below code.
trigger opportunityEmailonAccount_AT on Opportunity (after insert) 
{
	Set<ID> accids = new Set<ID>();
	for(Opportunity opp : trigger.new)
	{
		accids.add(opp.AccountId);
	}
		
	Map<Id,Account> mapAcc = new Map<Id,Account>( [Select Id,Name,Opportunity_Email__c From Account where Id in : accids ] ) ;
	List<account> lstForUpdate = new List<account>();
	
	for(opportunity opp : trigger.new)
	{
        if(opp.Opportunity_Email__c != null && mapAcc.containsKey(opp.AccountId) )
		{
			Account acc = mapAcc.get(opp.AccountId);
            acc.Opportunity_Email__c = opp.Opportunity_Email__c;
			
			lstForUpdate.add(acc); 
        }
	}
	if(lstForUpdate.size() > 0 )
	{
		update lstForUpdate;
	}
}

Please check below post for trigger best pratice
1) http://amitsalesforce.blogspot.com/2015/06/trigger-best-practices-sample-trigger.html

1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org.

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers

4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail

Let us know if this will help you
 

All Answers

Ankur Saini 9Ankur Saini 9
Hi Oliver Jones Rajkumar

try this: 
 
trigger opportunityEmailonAccount_AT on Opportunity (after insert, after update) {
   Set<ID> accids = new Set<ID>();
   List<Account> accList = new List<Account>();
    for(Opportunity opp : Trigger.new){
        
        accids.add(opp.AccountId);
        }
        
        for(Account acc : [Select Id,Name,AnnualRevenue,(select Amount from Opportunities) From Account where Id in : accids]){
        
            for(Opportunity opp : acc.Opportunities){
                    acc.AnnualRevenue = opp.Amount;
                    accList.add(acc);
        }
        
    }
    update accList;
}

Ankur Saini
http://mirketa.com
sfdcMonkey.comsfdcMonkey.com
hi Oilver
use below trigger codes
trigger opportunityEmailonAccount_AT on Opportunity (after insert) {
     Set<ID> accids = new Set<ID>();
	    for(Opportunity opp : trigger.new){
		      accids.add(opp.AccountId);
		}
	 List<Account> accList = [Select Id,Name,Opportunity_Email__c From Account where Id in : accids];
	 List<account> lstForUpdate = new List<account>();
	for(opportunity opp : trigger.new){
	for(Account acc : accList){
        if(opp.Opportunity_Email__c != null ) {
            acc.Opportunity_Email__c = opp.Opportunity_Email__c;
        }
        lstForUpdate.add(acc); 
       }
	}
	update lstForUpdate;
}
thanks
let me inform if any issue with it and mark it best answer if my answer helps you
:)

 
Amit Chaudhary 8Amit Chaudhary 8
Hi Oilver,

I found below issue in your code
1) SOQL inside the for loop
2) DML inside the for loop

Please try below code.
trigger opportunityEmailonAccount_AT on Opportunity (after insert) 
{
	Set<ID> accids = new Set<ID>();
	for(Opportunity opp : trigger.new)
	{
		accids.add(opp.AccountId);
	}
		
	Map<Id,Account> mapAcc = new Map<Id,Account>( [Select Id,Name,Opportunity_Email__c From Account where Id in : accids ] ) ;
	List<account> lstForUpdate = new List<account>();
	
	for(opportunity opp : trigger.new)
	{
        if(opp.Opportunity_Email__c != null && mapAcc.containsKey(opp.AccountId) )
		{
			Account acc = mapAcc.get(opp.AccountId);
            acc.Opportunity_Email__c = opp.Opportunity_Email__c;
			
			lstForUpdate.add(acc); 
        }
	}
	if(lstForUpdate.size() > 0 )
	{
		update lstForUpdate;
	}
}

Please check below post for trigger best pratice
1) http://amitsalesforce.blogspot.com/2015/06/trigger-best-practices-sample-trigger.html

1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org.

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers

4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail

Let us know if this will help you
 
This was selected as the best answer
Oliver Jones RajkumarOliver Jones Rajkumar
Thank you Ankur, Piyush, Amit all three of your codes works perfectly. By the way Im Oliver not Oilver.

Regards.