function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
vijayabakarareddy yarrabothulavijayabakarareddy yarrabothula 

pls help me to write test class for this trigger

rigger FindDuplicateContact on Contact (before insert, before update) {
  for (Contact con : Trigger.new) {
    if (con.Email != null && con.Phone !=null) {
      List<contact> dupes = [SELECT Id FROM Contact
                               WHERE Email = :con.Email AND Phone=:con.phone];
      if (dupes != null && dupes.size() > 0) {
        String errorMessage = 'Duplicate contact found! ';
        errorMessage += 'Record ID is ' + dupes[0].Id;
        con.addError(errorMessage);
      }
    }
  }
}
Best Answer chosen by vijayabakarareddy yarrabothula
sfdcMonkey.comsfdcMonkey.com
hi in my org its work and give 100% code coverage
User-added image

copy and past below code with your trigger and test class
/*Test Class*/
@isTest
public class bookscontrollertest{

public static testmethod void testvalidate1(){

        contact obj = new contact();
       obj.LastName = 'test';
       obj.phone = '1236547891';
       obj.email = 'test@gmail.com';
       insert obj;
   
     contact obj2 = new contact();
       obj2.LastName = 'test2';
       obj2.phone = '1236547891';
       obj2.email = 'test@gmail.com';
     
    Database.SaveResult result = Database.insert(obj2, false);
    System.assertEquals('Duplicate contact found! Record ID is ' + obj.Id ,result.getErrors()[0].getMessage());  
    //  insert obj2;
    
     
       
  }
}
trigger FindDuplicateContact on Contact (before insert, before update) {
  for (Contact con : Trigger.new) {
    if (con.Email != null && con.Phone !=null) {
      List<contact> dupes = [SELECT Id FROM Contact
                               WHERE Email = :con.Email AND Phone=:con.phone];
      if (dupes != null && dupes.size() > 0) {
        String errorMessage = 'Duplicate contact found! ';
        errorMessage += 'Record ID is ' + dupes[0].Id;
        con.addError(errorMessage);
      }
    }
  }
}
thanks
let me inform if it helps you



 

All Answers

vijayabakarareddy yarrabothulavijayabakarareddy yarrabothula
hi piyush_soni,

when i run this it showing error code 
=============================
  ........Fail
Error MessageSystem.ListException: List index out of bounds: 0
Stack TraceClass.bookscontrollertest.testvalidate1: line 19, column 1
sfdcMonkey.comsfdcMonkey.com
hi in my org its work and give 100% code coverage
User-added image

copy and past below code with your trigger and test class
/*Test Class*/
@isTest
public class bookscontrollertest{

public static testmethod void testvalidate1(){

        contact obj = new contact();
       obj.LastName = 'test';
       obj.phone = '1236547891';
       obj.email = 'test@gmail.com';
       insert obj;
   
     contact obj2 = new contact();
       obj2.LastName = 'test2';
       obj2.phone = '1236547891';
       obj2.email = 'test@gmail.com';
     
    Database.SaveResult result = Database.insert(obj2, false);
    System.assertEquals('Duplicate contact found! Record ID is ' + obj.Id ,result.getErrors()[0].getMessage());  
    //  insert obj2;
    
     
       
  }
}
trigger FindDuplicateContact on Contact (before insert, before update) {
  for (Contact con : Trigger.new) {
    if (con.Email != null && con.Phone !=null) {
      List<contact> dupes = [SELECT Id FROM Contact
                               WHERE Email = :con.Email AND Phone=:con.phone];
      if (dupes != null && dupes.size() > 0) {
        String errorMessage = 'Duplicate contact found! ';
        errorMessage += 'Record ID is ' + dupes[0].Id;
        con.addError(errorMessage);
      }
    }
  }
}
thanks
let me inform if it helps you



 
This was selected as the best answer
vijayabakarareddy yarrabothulavijayabakarareddy yarrabothula
hi piyush_soni,

Its working fine... Thank u  so much


can  u please explain about  ====> Database.SaveResult result = Database.insert(obj2, false);

what happen if i use  insert obj2 instead of above statement
sfdcMonkey.comsfdcMonkey.com
Amit Chaudhary 8Amit Chaudhary 8
HI vijayabakarareddy yarrabothula,

I found some issue in your trigger itself
1) Logic is not good in exisiting Trigger. Create one contact and then edit same record again then that will give you duplicate trigger Error because in SOQL you will get same record again
2) SOQL inside the for loop is not a good practice
http://amitsalesforce.blogspot.com/2015/06/trigger-best-practices-sample-trigger.html

Please update your trigger like below
Trigger FindDuplicateContact on Contact (before insert, before update) 
{
    Set<ID> setId = new Set<ID>();
    set<String> setEmail = new Set<String>();
    set<String> setPhone = new Set<String>();
    
    for (Contact con : Trigger.new) 
    {
        if (con.Email != null && con.Phone !=null) 
        {
            setId.add(con.id);
            setEmail.add(con.Email );
            setPhone.add(con.Phone );
            
        }
    }
    
    if(setId.size() > 0 )
    {
        List<Contact> lstOldContact  = [select email,phone,id from contact where email in :setEmail and phone in :setPhone and Id not in :setId ];
        Map<String ,Contact> MapStringWiseCont = new Map<String,Contact>();
        
        for(Contact cont : lstOldContact  )
        {
            String key = cont.Email +'_'+cont.Phone;
            MapStringWiseCont.put(key,cont);
        }

        for (Contact con : Trigger.new) 
        {
            if (con.Email != null && con.Phone !=null) 
            {
                String key = con.Email +'_'+con.Phone;
                 if(MapStringWiseCont.containsKey(key))
                 {
                    Contact contOld = MapStringWiseCont.get(key);
                    
                    String errorMessage = 'Duplicate contact found! Record ID is ' + contOld.Id;
                    con.addError(errorMessage);
                 }
                        
            }
        }    
        
            
    }   
     

}
Your test class should be like below
@isTest
public class FindDuplicateContactTest
{
    public static testmethod void testvalidate1()
    {
        contact obj = new contact();
        obj.LastName = 'test';
        obj.phone = '1236547891';
        obj.email = 'test@gmail.com';
        insert obj;
        
        contact obj2 = new contact();
        obj2.LastName = 'test2';
        obj2.phone = '1236547891';
        obj2.email = 'test@gmail.com';
        
        try
        {
            insert obj2;
        }Catch(Exception ee)
        {
            Boolean expectedExceptionThrown =  ee.getMessage().contains('Duplicate contact found! Record ID is ') ? true : false;
            System.AssertEquals(expectedExceptionThrown, true);       
        }
        
        
        Database.SaveResult result = Database.insert(obj2, false);
    }
}
http://amitsalesforce.blogspot.com/2015/06/best-practice-for-test-classes-sample.html


Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you
vijayabakarareddy yarrabothulavijayabakarareddy yarrabothula
Hi@piyush_soni 

I have a requiremt for writing test class  will u please help me to write test class
share your email id here  i will send the code 
baskarsfdc8297@gmail.com