function readOnly(count){ }
Sign Up ›
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
Learn More

Browse by Topic
ShowAll Questionssorted byDate Posted
+ Start a Discussion
Fayyad ZahidFayyad Zahid 

Trigger: Invalid loop variable type expected SObject was Case

Hello,

I am simply trying to access a few Case fields of a Case that has been created after an Apex trigger. However, I keep getting this error: "Invalid loop variable type expected SObject was Case". I am not sure what the problem is, as other sources online that I have looked at seem to be using the same syntax/declarations that I am using. As a sidenote, I am fairly new to Apex and am still learning as I go. Please bear with me.

Here is my code:

trigger Ticket_Trigger on Case (after insert) {

    List<Id> listId = new List<Id>();
    for(Case c : Trigger.new){
        listId.add(c.Id);
    }
    
    List<Case> caseList = [SELECT Case.Id, Case.Origin, Case.ContactId, Case.AccountId, Case.Status,
                           Case.Priority, Case.Subject, Case.LastModifiedById, Case.OwnerId,
                           Case.CreatedById, Case.CreatedDate, Case.Description 
                           FROM Case 
                           WHERE Case.id IN :setId];
    
    System.debug(caseList);
}
Best Answer chosen by Fayyad Zahid
Ajay K DubediAjay K Dubedi
Hi Fayyad,
Follow these steps:
1. Try to separate trigger and it's handler class.
2. Always try to put the null check condition in your code.
3. Never put query inside for loop.
4. In your code, inside query use listId instead of setId.
5. While you are store Id of any record use Set<Id>.
6. In your code when the case list comes in the "trigger.new" why you are query this?
Try this Code:
Trigger: 
trigger Ticket_Trigger on Case (after insert) {
    if(trigger.IsInsert && trigger.IsAfter) {
        Ticket_Trigger_handler.showCase(trigger.new);
    }
}
Handler: 
public class Ticket_Trigger_handler {
    public static void showCase(List<Case> caseList) {
        try
        {
            Set<Id> caseIdSet = new Set<Id>();
            List<Case> caList = new List<Case>();
           
            if(caseList.size() > 0) {
                for(Case c : caseList)
                {
                    caseIdSet.add(c.Id);
                }
            }
             caList = [SELECT Case.Id, Case.Origin, Case.ContactId, Case.AccountId, Case.Status,
                           Case.Priority, Case.Subject, Case.LastModifiedById, Case.OwnerId,
                           Case.CreatedById, Case.CreatedDate, Case.Description
                           FROM Case
                           WHERE Case.Id IN : caseIdSet];
            System.debug(caseList);
        }
        catch(Exception e)
        {
            system.debug('The following exception has occured:' +e.getMessage());
            system.debug('The following Line:' + e.getLineNumber());
        }
    }
}

I hope you find the above solution helpful. If it does, please mark as Best Answer to help others too.
Thanks,
Ajay Dubedi

All Answers

Ajay K DubediAjay K Dubedi
Hi Fayyad,
Follow these steps:
1. Try to separate trigger and it's handler class.
2. Always try to put the null check condition in your code.
3. Never put query inside for loop.
4. In your code, inside query use listId instead of setId.
5. While you are store Id of any record use Set<Id>.
6. In your code when the case list comes in the "trigger.new" why you are query this?
Try this Code:
Trigger: 
trigger Ticket_Trigger on Case (after insert) {
    if(trigger.IsInsert && trigger.IsAfter) {
        Ticket_Trigger_handler.showCase(trigger.new);
    }
}
Handler: 
public class Ticket_Trigger_handler {
    public static void showCase(List<Case> caseList) {
        try
        {
            Set<Id> caseIdSet = new Set<Id>();
            List<Case> caList = new List<Case>();
           
            if(caseList.size() > 0) {
                for(Case c : caseList)
                {
                    caseIdSet.add(c.Id);
                }
            }
             caList = [SELECT Case.Id, Case.Origin, Case.ContactId, Case.AccountId, Case.Status,
                           Case.Priority, Case.Subject, Case.LastModifiedById, Case.OwnerId,
                           Case.CreatedById, Case.CreatedDate, Case.Description
                           FROM Case
                           WHERE Case.Id IN : caseIdSet];
            System.debug(caseList);
        }
        catch(Exception e)
        {
            system.debug('The following exception has occured:' +e.getMessage());
            system.debug('The following Line:' + e.getLineNumber());
        }
    }
}

I hope you find the above solution helpful. If it does, please mark as Best Answer to help others too.
Thanks,
Ajay Dubedi
This was selected as the best answer
Fayyad ZahidFayyad Zahid
Ajay,

Thank you for the quick response, your answer was very helpful and does almost exactly what I needed my trigger to do! As I said, I am new to Apex and have been trying to understand how to use Apex Triggers and make SOQL queries.

I have been tasked with a Jira-Salesforce Integration, and I have managed to successfully make REST API calls to Jira in Apex. I have been trying to create a trigger that will add Salesforce cases to Jira upon the case creation, but I was struggling with how to access new cases on their creation and their fields. Currently I have been simply trying to test whether I could do it or not, and your answer has put me ahead. 

I appreciate the time and effort you have put in for your response!

Thanks,
Fayyad