function readOnly(count){ }
Sign Up ›
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
Learn More

Browse by Topic
ShowAll Questionssorted byDate Posted
+ Start a Discussion
Heidi Brose 19Heidi Brose 19 

Why a particular record type?

I'm using Simple Asset Manager by Salesforce Labs and one of the test classes is causing some problems when deploying new code.    

This is the error: 

Class NameMethod NameError MessageAM_HomeControllerTesttestRecordTypeSelectionSystem.AssertException: Assertion Failed: Expected: 0121R000001M5bAQAS, Actual: null
Stack Trace: Class.AM_HomeControllerTest.testRecordTypeSelection: line 99, column 1 
/*

Copyright (c) 2011, salesforce.com, Inc.
All rights reserved.

Redistribution and use in source and binary forms, with or without modification, 
are permitted provided that the following conditions are met:

    * Redistributions of source code must retain the above copyright notice, 
    this list of conditions and the following disclaimer.
    * Redistributions in binary form must reproduce the above copyright notice, 
    this list of conditions and the following disclaimer in the documentation 
    and/or other materials provided with the distribution.
    * Neither the name of the salesforce.com, Inc. nor the names of its contributors 
    may be used to endorse or promote products derived from this software 
    without specific prior written permission.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND 
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED 
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. 
IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, 
INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, 
BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF 
LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE 
OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED 
OF THE POSSIBILITY OF SUCH DAMAGE.

*/

/* Description: This class is the controller for the app's home page */

public with sharing class AM_HomeController {

    /*---- Variables ----*/
    //Variable for errormessage
    public List<ApexPages.Message> errormessages 
    {
        get
        {
            //Get only error messages
            return AM_SettingsUtil.prepareMessages(ApexPages.getMessages());
        }

        private set;
    }

    //List of available asset record types
    private List<RecordType> rtList= [select Id, 
                                             DeveloperName,
                                             Name 
                                      from RecordType
                                      where sObjectType =: AM_Constants.AM_ASSET_API_NAME];  

    //List of selectOptions to display record types on the page
    public List<SelectOption> recordTypeOptions {
        get 
        {
            List<SelectOption> options = new List<SelectOption>();
            for (RecordType rt : rtList) 
            {
                //Populate SelectList
                options.add(new SelectOption(rt.Id, rt.Name));
            }
            return options;           
        }
        private set;
    }                                     

    //Number of record types available
    public Integer recordTypeCount {
        get
        {
            return recordTypeOptions.size();
        }
        private set;
    }

    //Logged in user info
    private User loggedInUser = [select Id,
                                        Name,
                                        AM_Asset_Record_Type__c
                                 from User
                                 where Id = :UserInfo.getUserId() limit 1];

    //Record type selection on the home page
    public Id selectedRecordTypeId {get; set;}

    //Label for the object being managed.
    //This variable will be used for all labels and texts
    public String assetlabel {get; private set;}

    //Variable for Total Asset Count
    public Double totalCount {get; private set;}

    //Variable for Available Assets Count
    public Integer availableCount {get; private set;}

    //Variable for Available Assets Count, representing % as Integer
    public Double availablePercentage {get; private set;}
    
    //Variable for Assigned Assets Count
    public Integer assignedCount {get; private set;}

    //Variable for Assigned Assets Count, representing % as Integer
    public Double assignedPercentage {get; private set;}

    //Variable for Out Of Service Assets Count
    public Integer outOfServiceCount {get; private set;}

    //Variable for Out of Service Assets Count, representing % as Integer
    public Double outOfServicePercentage {get; private set;}

    //Variable for Case List
    public List<Case> caseList {get; private set;}                                 

    /*---- /Variables ----*/

    /*---- Constructors ----*/

    public AM_HomeController() 
    {   
        //Initiate the home page
        this.init();
    }

    /*---- /Constructors ----*/

    /*---- Methods ----*/

    /*
    * Description: Method to initiate the homepage content
    */    
    public void init()
    {
        //Check if there are any Record Types created.
        if(rtList==null || rtList.isEmpty())
        {
            //If no record types are not created throw an error
            ApexPages.addMessage(new ApexPages.Message(ApexPages.Severity.ERROR, 
                                                       'E2: Did not find asset record types. Please contact administrator.'));                                                                                    
        }
        //Continue with the logic
        else
        {
            //Initialize counts
            this.availableCount = 0;
            this.assignedCount = 0;
            this.outOfServiceCount = 0;
            this.totalCount = 0;

            //Set the selectedRecordTypeId
            if(String.isEmpty(loggedInUser.AM_Asset_Record_Type__c))
            {
                //selectedRecordTypeId is the first row of the rt query result
                selectedRecordTypeId = rtList[0].Id;
            }
            else
            {
                //Test that the User field contains a valid Record ID
                if(!String.isEmpty(AM_SettingsUtil.setassetLabel(loggedInUser.AM_Asset_Record_Type__c)))
                {
                    //selectedRecordTypeId is the value set in User record
                    selectedRecordTypeId = loggedInUser.AM_Asset_Record_Type__c;                                                  
                }
                else
                {
                    //selectedRecordTypeId is the first row of the query result
                    selectedRecordTypeId = rtList[0].Id;                                                   
                }
            }

            //Set the Asset Label - Call the static method to set the asset label
            this.assetLabel = AM_SettingsUtil.setassetLabel(this.selectedRecordTypeId);

            //Get Counts
            this.getCounts();

            //Get Alerts list
            this.getCaseList();            
        }
    }

    /*
    *  Description: Method to set custom settings value
    */
    public void refreshHomepage()
    {
        //Set the value in User record
        loggedInUser.AM_Asset_Record_Type__c = this.selectedRecordTypeId; 

        //Change asset label as per selelction
        this.assetlabel = AM_SettingsUtil.setassetLabel(this.selectedRecordTypeId);    

        //Check if the field can be updated by the user
        if (Schema.sObjectType.User.fields.AM_Asset_Record_Type__c.isUpdateable())
        {
            //Update the user record
            update loggedInUser;
        }
        else
        {
            ApexPages.addMessage(new ApexPages.Message(ApexPages.Severity.WARNING,
                                                      'Insufficient access to update AM_Asset_Record_Type__c on User'));            
        }  
       
        //Get Counts
        this.getCounts();

        //Get Alerts List
        this.getCaseList();
    }

    /*
    * Method to get asset counts
    */
    public void getCounts()
    {
        //Reset all count to 0 before calculating counts
        this.availableCount = 0;
        this.assignedCount = 0;
        this.outOfServiceCount = 0;
        this.totalCount = 0;

        //Create a list for asset counts
        List<AggregateResult> assetCounts = new List<AggregateResult>();

        try
        {
            //Get the count for the different value of AM_Available_for_allocation__c checkbox based on the record type selected
            assetCounts = [SELECT AM_Available_for_allocation__c, 
                                  COUNT(Id) c
                           FROM AM_Asset__c 
                           WHERE RecordTypeId =: this.selectedRecordTypeId
                           GROUP BY AM_Available_for_allocation__c];            
        }
        catch (Exception e)
        {
            //Add a message that there was an error fetching records
            ApexPages.addMessage(new ApexPages.Message(ApexPages.Severity.ERROR, 
                                                       'E3: Error fetching Asset records. ( ' + e.getMessage() + ' )'));                                                                        
        }
                                       
                                                    
        //Loop through the list and assign Available and Assigned counts
        for(AggregateResult assetCount: assetCounts)
        {
            //Check if assetCount is null
            if( assetCount!=null )
            {

                //Variable for Count of asset status
                Integer statusCount = Integer.valueOf(assetCount.get('c'));

                //Count for Available assets
                if(assetCount.get('AM_Available_for_allocation__c')==true)
                {
                    this.availableCount = statusCount;
                }
                //Count for Assigned assets
                else if (assetCount.get('AM_Available_for_allocation__c')==false)
                {
                    this.assignedCount = statusCount;
                }
            }
            else
            {
                    //Add a message that assetcount is null
                    ApexPages.addMessage(new ApexPages.Message(ApexPages.Severity.ERROR, 
                                                               'E6: Asset count is 0.'));                                                            
            }
        }

        //Get the Out of Service counts
        this.outOfServiceCount = [select COUNT() from AM_Asset__c 
                                  where RecordTypeId =: this.selectedRecordTypeId 
                                  AND AM_Out_of_Service__c = :true];

        //Calculate the total count
        this.totalCount = this.availableCount + this.assignedCount;

        //Calculate the percentages for each variable if total is not 0 . 
        //Need to use Double versions of the int values for correct totals.
        if(totalCount>0)
        {
            //Available
            this.availablePercentage = (this.availableCount / this.totalCount) * 100;

            //Assigned
            this.assignedPercentage = (this.assignedCount / this.totalCount) * 100;

            //Out of Service
            this.outOfServicePercentage = (this.outOfServiceCount / this.totalCount) * 100;
        }
        //TotalCount = 0
        else
        {
            this.availablePercentage = 0.0;
            this.assignedPercentage = 0.0;
            this.outOfServicePercentage = 0.0;
        }
    }

    /*
    * Method to get the Alerts list (Cases Ordered by recently modified date)
    */
    public void getCaseList()
    {
        try
        {
            //Get the top 10 most recent list of cases for the selected record type
            this.caseList = [SELECT AM_Asset__r.Name,
                                    Owner.Name,
                                    CreatedBy.Name,
                                    Status,
                                    Subject,
                                    LastModifiedDate,
                                    AM_Asset__r.RecordTypeId
                             FROM Case
                             where AM_Asset__r.RecordTypeId = :this.selectedRecordTypeId
                             ORDER BY LastModifiedDate DESC
                             limit 10];            
        }
        catch (Exception e)
        {
            //Add a message that there was an error fetching records
            ApexPages.addMessage(new ApexPages.Message(ApexPages.Severity.ERROR, 
                                                       'E3: Error fetching Alert records. ( ' + e.getMessage() + ' )'));                                                            
        }
    }
    
    /*---- /Methods ----*/
}
Am I reading that error correctly? Any help would be appreciated.  
Andrew GAndrew G
Reading the error message
"Assertion Failed: Expected: 0121R000001M5bAQAS, Actual: null
Stack Trace: Class.AM_HomeControllerTest.testRecordTypeSelection: line 99, column 1"

The error is in your test class.  It may not be related to the code you are posting.

Possible issues:  since it appears you have a hard coded ID in the code, we need to ensure that RecordType with that ID exists in that environment. 
Alternately, rather than use the ID explicitly, do something like:
  
List<RecordType> expectedRT = [SELECT id FROM RecordType WHERE DeveloperName = 'expectedRecordTypeName];
System.assertEquals(expectedRT[0].Id, record.recordtype);

Regards
Andrew​​​​​​​
Heidi Brose 19Heidi Brose 19
THanks for the response Andrew!  I was wondering if it was something like that but I couldn't find anything in the code that references the hard coded ID.  I'll look through some of the other code to see if I can locate it.   
Heidi Brose 19Heidi Brose 19
I couldn't find the hardcoded ID, but the problem seems to be here.     AM_Asset_Record_Type__c    is that a hard coded reference?           
//Get the user record
      User updatedUser = [select Id, 
                     AM_Asset_Record_Type__c
                  from User
                  where Id = :newUser.Id];

      //Check that the AM_Asset_Record_Type__c field is set
      system.assertEquals(rtList[0].Id, updatedUser.AM_Asset_Record_Type__c);  

      //Check the label
      system.assertEquals(newController.assetlabel, rtList[0].Name);

 
Heidi Brose 19Heidi Brose 19
/*

Copyright (c) 2011, salesforce.com, Inc.
All rights reserved.

Redistribution and use in source and binary forms, with or without modification, 
are permitted provided that the following conditions are met:

    * Redistributions of source code must retain the above copyright notice, 
    this list of conditions and the following disclaimer.
    * Redistributions in binary form must reproduce the above copyright notice, 
    this list of conditions and the following disclaimer in the documentation 
    and/or other materials provided with the distribution.
    * Neither the name of the salesforce.com, Inc. nor the names of its contributors 
    may be used to endorse or promote products derived from this software 
    without specific prior written permission.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND 
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED 
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. 
IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, 
INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, 
BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF 
LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE 
OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED 
OF THE POSSIBILITY OF SUCH DAMAGE.

*/

/* Description: This class contains test methods to test Home Page functionality */


@isTest
private class AM_HomeControllerTest
{

  /**
  *   Test Case:
  *   1) Get a list of recordtypes
  *   2) Create an instance of AM_HomeController
  *   3) Check that the list of recordtype is identical to recordTypeOptions
  */   
  @isTest
  private static void testRecordTypeCount()
  {

  //Record Type List
  List<RecordType> rtList= [select Id, 
                                    DeveloperName,
                                    Name 
                              from RecordType
                              where sObjectType =: AM_Constants.AM_ASSET_API_NAME];
                                       
    //Create controller instance
    AM_HomeController newController = new AM_HomeController();

    //Test recordtypes 
    system.assertEquals(rtList.size(), newController.recordTypeCount);                                             
  }

  /**
  *   Test Case:
  *   1) Create a user with AM_Asset_Record_Type__c blank
  *   2) Select a record type
  *   3) AM_Asset_Record_Type__c field in user should be populated with the selected recordtype
  */   
  @isTest
  private static void testRecordTypeSelection()
  {
    //Create a user
    User newUser = AM_TestUtilities.createTestUser();

    //Run the test as new user
    system.runAs(newUser)
    {
      List<RecordType> rtList= [select Id, 
                                            DeveloperName,
                                            Name 
                                      from RecordType
                                      where sObjectType =: AM_Constants.AM_ASSET_API_NAME];

      //Create controller instance
      AM_HomeController newController = new AM_HomeController();

      //Set the recordtype
      newController.selectedRecordTypeId = rtList[0].Id;

      //Call the Refresh method
      newController.refreshHomepage();

      //Get the user record
      User updatedUser = [select Id, 
                     AM_Asset_Record_Type__c
                  from User
                  where Id = :newUser.Id];

      //Check that the AM_Asset_Record_Type__c field is set
      system.assertEquals(rtList[0].Id, updatedUser.AM_Asset_Record_Type__c);  

      //Check the label
      system.assertEquals(newController.assetlabel, rtList[0].Name);                

    }                                             
  }

  /**
  *   Test Case:
  *   1) Create 4 Available, 3 Assigned and 2 Out of Service Assets
  *   2) Check if correct count is obtained
  */   
  @isTest
  private static void testAssetCounts()
  {
    //Record Types
    List<RecordType> rtList= [select Id, 
                                            DeveloperName,
                                            Name 
                                      from RecordType
                                      where sObjectType =: AM_Constants.AM_ASSET_API_NAME];
    //Available assets
    List<AM_Asset__c> availableAssets = AM_TestUtilities.createTestAssets(4);

    //Assigned assets
    List<AM_Asset__c> assignedAssets = AM_TestUtilities.createTestAssets(3);
    
    //For each asset create an allocation
    for(AM_Asset__c assignAsset: assignedAssets)
    {
      AM_TestUtilities.createTestAllocation(assignAsset);
    }

    //Out of service assets
    List<AM_Asset__c> oosAssets = AM_TestUtilities.createTestAssets(2);  

    //Mark them OOS
    for(AM_Asset__c oos: oosAssets)
    {
      oos.AM_Out_of_Service__c = true;
    }      

    update oosAssets;

    //Create a new user
    User newUser = AM_TestUtilities.createTestUser();
    newuser.AM_Asset_Record_Type__c = rtList[0].Id;

    update newUser;

    system.runAs(newUser)
    {
      AM_HomeController newController = new AM_HomeController();
      system.assertEquals(newController.availableCount, 6);
      system.assertEquals(newController.assignedCount, 3);
      system.assertEquals(newController.outOfServiceCount, 2);
    }
  }

  /**
  *   Test Case:
  *   1) Create 5 cases
  *   2) Check if the cases are retrieved
  */   
  @isTest
  private static void testCaseCounts()
  {
    //Record Types
    List<RecordType> rtList= [select Id, 
                                            DeveloperName,
                                            Name 
                                      from RecordType
                                      where sObjectType =: AM_Constants.AM_ASSET_API_NAME];

    //Create a new user
    User newUser = AM_TestUtilities.createTestUser();
    newuser.AM_Asset_Record_Type__c = rtList[0].Id;

    update newUser;

    system.runAs(newUser)
    {
      //Available assets
      List<AM_Asset__c> availableAssets = AM_TestUtilities.createTestAssets(1);

      //Create Cases
      List<Case> newCases = AM_TestUtilities.createTestCases(4, availableAssets[0]);  
          
      //Create controller instance    
      AM_HomeController newController = new AM_HomeController();

      //Assert
      system.assertEquals(newController.caseList.size(), 4);

    }
  }      
}

Full code if that's helpful. 
Andrew GAndrew G
Hi Heidi

The full test code helps. It fills some blanks.  Ok - good news - there is no hardcoded ID.

The error message is failing because the User record does not have the field 'AM_Asset_Record_Type__c' set.

As I review the test code (that has been commented out), i believe the error is occuring due to a time issue / behaviour with test classes.  I would tweak the test code for the method "testRecordTypeSelection()" as follows: 
@isTest
  private static void testRecordTypeSelection()
  {
    //Create a user
    User newUser = AM_TestUtilities.createTestUser();

    //Run the test as new user
    system.runAs(newUser)
    {
     Test.startTest();
      List<RecordType> rtList= [select Id, 
                                            DeveloperName,
                                            Name 
                                      from RecordType
                                      where sObjectType =: AM_Constants.AM_ASSET_API_NAME];

      //Create controller instance
      AM_HomeController newController = new AM_HomeController();

      //Set the recordtype
      newController.selectedRecordTypeId = rtList[0].Id;

      //Call the Refresh method
      newController.refreshHomepage();

      Test.stopTest();

      //Get the user record
      User updatedUser = [select Id, 
                     AM_Asset_Record_Type__c
                  from User
                  where Id = :newUser.Id];

      //Check that the AM_Asset_Record_Type__c field is set
      system.assertEquals(rtList[0].Id, updatedUser.AM_Asset_Record_Type__c);  

      //Check the label
      system.assertEquals(newController.assetlabel, rtList[0].Name);                

    }                                             
  }

The use of Test.startTest and Test.stopTest ensure that the calls complete, (and also reset governance limits), but in this Case, it should ensure that any calls by the Controller are completed before we do a call via SOQL to test if the fields on the user record have been updated.

Regards

Andrew