function readOnly(count){ }
Sign Up ›
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
Learn More

Browse by Topic
ShowAll Questionssorted byDate Posted
+ Start a Discussion
Jonas JúniorJonas Júnior 

I need help with Map<Key,Value> use

Hey guys,

I need help with the code below. It work, but when the second for is running I`m afraid that it cause a system error because it's runing many times the same consult. What I need to do is change this to use a Map<key,value> and stay with only one for and a Map<key,value>. How I do this?
  
public static void stopAccountDelete (List<Account> listAcc){

        try{
            for(Account acc : listAcc){
                for(Opportunity opp : [SELECT AccountId FROM Opportunity WHERE IsWon = true]){
                    if(acc.Id == opp.AccountId){
                        acc.Id.adderror('Account cannot be deleted, because exists a Opportunity associated!');
                    }
                }
            }
        }

        catch (DmlException e) {
            System.debug('DML error: ' + e.getMessage());
        }

        catch (Exception ex) {
            System.debug('System error: ' + ex.getMessage());
        }

    }
Thanks,
Junior, Jonas C.
Best Answer chosen by Jonas Júnior
Mohd. KamranMohd. Kamran
Hi Jonas,

Please try this below code, It's more optimised...

public static void stopAccountDelete (List<Account> listAcc){
 Map<id, Account> mapAcctsWithOpps = new Map<id, Account>([SELECT Id,(SELECT AccountId, IsWon  FROM Opportunities WHERE IsWon = true) FROM Account WHERE ID IN: listAcc]);

    try{
        for(Account acc : listAcc){
            if(mapAcctsWithOpps.get(acc.id).Opportunities.size() > 0){
               acc.adderror('Account cannot be deleted, because exists a Opportunity associated!');
            }
        }
    }
    catch (DmlException e) {
        System.debug('DML error: ' + e.getMessage());
    }

    catch (Exception ex) {
    System.debug('System error: ' + ex.getMessage());
    }

}
 

All Answers

Raj VakatiRaj Vakati
try this
  
public static void stopAccountDelete (List<Account> listAcc){
Map<Id, Account> mapOfacc = new Map<Id, Account> ();

        try{
            for(Account acc : listAcc){
			Map<Id, Account> mapOfacc = new Map<Id, Account> ();
			mapOfacc.put(acc.Id,acc);
			      
            }
			
			for(Opportunity opp : [SELECT AccountId FROM Opportunity WHERE IsWon = true]){
                    if(mapOfacc.contains(opp.AccountId)){
                        mapOfacc.get(opp.AccountId).adderror('Account cannot be deleted, because exists a Opportunity associated!');
                    }
                }
				
				
        }

        catch (DmlException e) {
            System.debug('DML error: ' + e.getMessage());
        }

        catch (Exception ex) {
            System.debug('System error: ' + ex.getMessage());
        }

    }



You can even use trigger.oldMap if you are calling this code from the trigger 
Jonas JúniorJonas Júnior
Hey Ray,

I did some adjusts in your code and it worked! Thanks for your help! The new code looks like this: 
public static void stopAccountDelete (List <Account> listAcc) {

    try {

        Map <Id, Account> mapOldAcc = new Map <Id, Account> ();
        List <Opportunity> ListOpp = [SELECT AccountId FROM Opportunity WHERE IsWon = true];
        for (Account acc: listAcc) {
            mapOldAcc.put(acc.Id, acc);
        }

        for (Opportunity opp: ListOpp) {
            if (mapOldAcc.containsKey(opp.AccountId)) {
                mapOldAcc.get(opp.AccountId).adderror('Account cannot be deleted, because exists a Opportunity associated!');
            }
        }

    } catch (DmlException e) {
        System.debug('DML error: ' + e.getMessage());
    } catch (Exception ex) {
        System.debug('System error: ' + ex.getMessage());
    }

}
Thanks,
Junior, Jonas C.
Mohd. KamranMohd. Kamran
Hi Jonas,

Please try this below code, It's more optimised...

public static void stopAccountDelete (List<Account> listAcc){
 Map<id, Account> mapAcctsWithOpps = new Map<id, Account>([SELECT Id,(SELECT AccountId, IsWon  FROM Opportunities WHERE IsWon = true) FROM Account WHERE ID IN: listAcc]);

    try{
        for(Account acc : listAcc){
            if(mapAcctsWithOpps.get(acc.id).Opportunities.size() > 0){
               acc.adderror('Account cannot be deleted, because exists a Opportunity associated!');
            }
        }
    }
    catch (DmlException e) {
        System.debug('DML error: ' + e.getMessage());
    }

    catch (Exception ex) {
    System.debug('System error: ' + ex.getMessage());
    }

}
 
This was selected as the best answer
Jonas JúniorJonas Júnior
Hi Kamran!

It got better this way. Thanks for your help!

Thanks,
Junior, Jonas C.