Not able to get code coverage (only 47% get covered)

Hello,

I am trying to get more then 75% code coverage for my custom class but dont know why i am getting stucked.

Here is my class :

public class CreatePaymentController {
    
    String opportunityId = '';
    public String selectedInvoiceId {get; set;}
    public List<SelectOption> options {get; set;}
    List<Invoice__c> relatedInvoiceList = new List<Invoice__c>();
    
    public CreatePaymentController(){
        
        selectedInvoiceId = '';
        options = new List<SelectOption>();
        opportunityId = Apexpages.Currentpage().getparameters().get('opptyId');
        relatedInvoiceList = [select Id,Name from Invoice__c where Opportunity__c =:opportunityId];
    }
    
    public Pagereference redirectToPaymentDetail(){
        
        Payment__c payment;
        try{
            
            if(relatedInvoiceList <> null && relatedInvoiceList.size() == 1){
                List<Payment__c> paymentList = [Select Id,Name from Payment__c where Invoice__c =:relatedInvoiceList[0].Id];
                if(paymentList <> null && paymentList.size() > 0){
                    payment = new Payment__c(Id=paymentList[0].Id);
                }
                else{
                    payment = new Payment__c();
                    payment.Invoice__c = relatedInvoiceList[0].Id;
                    upsert payment;
                }
                Payment__c pay = [select Id, Name From Payment__c WHERE Id =:payment.Id];
                PageReference newPaymentDetailPage = new PageReference('/a08/e?CF00N2400000FhfdZ='+pay.Name+'&CF00N2400000FhfdZ_lkid='+pay.Id+'&saveURL=/'+opportunityId);
                newPaymentDetailPage.setRedirect(true);
                return newPaymentDetailPage;
            }
            else if(relatedInvoiceList <> null && relatedInvoiceList.size() > 1){
                
                for (Invoice__c inv : relatedInvoiceList) {
                    
                    options.add(new SelectOption(inv.Id, inv.Name));
                }
                system.debug('@@options : '+ options);
            }
        } catch(Exception ex){
            system.debug('@@ex : '+ ex.getMessage());
        }
        return null;
    }
    
    public PageReference paymentPage(){
        try{
            if(!String.isBlank(selectedInvoiceId)){
                Payment__c payment =  new Payment__c();
                payment.Invoice__c = selectedInvoiceId;
                insert payment;
                Payment__c pay = [select Id, Name From Payment__c WHERE Id =:payment.Id];
                PageReference newPaymentDetailPage = new PageReference('/a08/e?CF00N2400000FhfdZ='+pay.Name+'&CF00N2400000FhfdZ_lkid='+pay.Id+'&saveURL=/'+opportunityId);
                newPaymentDetailPage.setRedirect(true);
                return newPaymentDetailPage;
            }
        } catch(Exception ex){
            system.debug('@@ex : '+ ex.getMessage());
        }
        return null;
    }
}

Here is Test Class :

@isTest(SeeAllData=true)
public class CreatePaymentControllerTest{

    static testMethod void MyTest(){
        
        Account a = new Account();        
        a.Name = 'test';
        a.Email__c = 'test@test.com';
        a.CurrencyIsoCode = 'EUR';
        a.Phone = '789642';
        a.BillingCity= 'bhuj';
        a.BillingPostalCode = '370001';
        a.BillingCountry = 'india';
        a.BillingLatitude = 57.5 ;
        a.BillingLongitude = 67.7;
        a.BillingState = 'Gujarat';
        a.BillingStreet = 'Main';
        insert a;
         
        Opportunity opp = new Opportunity();
        opp.Name = 'Test Opportunity';
        opp.StageName = 'Stage 0';
        opp.CloseDate = system.today().addDays(10);
        opp.Accountid = a.id;
        opp.CurrencyIsoCode = 'GBP';
        insert opp;
        
        Invoice__c inv = new Invoice__c();
        inv.Account_Name__c = a.id;
        inv.Opportunity__c = opp.id;
        inv.CurrencyIsoCode = 'GBP';
        insert inv;
        
        Payment__c pm = new Payment__c();
        pm.Invoice__c = inv.id;
        pm.CurrencyIsoCode = 'GBP';
        insert pm;
        
        Payment__c pm1 = new Payment__c();
        pm1.Invoice__c = inv.id;
        pm1.CurrencyIsoCode = 'GBP';
        insert pm1;
        
        PageReference pageRef = new Pagereference('/a08/e?CF00N2400000FhfdZ=pm.Name&CF00N2400000FhfdZ_lkid=pm.Id&saveURL=/opp.Id');
        Test.setCurrentPage(pageRef);

        CreatePaymentController cnt = new CreatePaymentController();
        
        cnt.paymentPage();
        
        Apexpages.currentPage().getParameters().put('id',opp.Id); 
        
        cnt.redirectToPaymentDetail();
    
    }
}

Thanks in Advance..

November 6, 2015
·
Like
0
·
Follow
3

Best Answer chosen by Nihar Sharma

Amit Chaudhary 8
Please try below code. I hope that will provide you more then 75% code coverage.
Please check below post for test classes. I hope that will help u
http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html
@isTest public class CreatePaymentControllerTest { static testMethod void MyTest() { Account a = new Account(); a.Name = 'test'; a.Email__c = 'test@test.com'; a.CurrencyIsoCode = 'EUR'; a.Phone = '789642'; a.BillingCity= 'bhuj'; a.BillingPostalCode = '370001'; a.BillingCountry = 'india'; a.BillingLatitude = 57.5 ; a.BillingLongitude = 67.7; a.BillingState = 'Gujarat'; a.BillingStreet = 'Main'; insert a; Opportunity opp = new Opportunity(); opp.Name = 'Test Opportunity'; opp.StageName = 'Stage 0'; opp.CloseDate = system.today().addDays(10); opp.Accountid = a.id; opp.CurrencyIsoCode = 'GBP'; insert opp; Invoice__c inv = new Invoice__c(); inv.Account_Name__c = a.id; inv.Opportunity__c = opp.id; inv.CurrencyIsoCode = 'GBP'; insert inv; Payment__c pm = new Payment__c(); pm.Invoice__c = inv.id; pm.CurrencyIsoCode = 'GBP'; insert pm; Payment__c pm1 = new Payment__c(); pm1.Invoice__c = inv.id; pm1.CurrencyIsoCode = 'GBP'; insert pm1; Test.StartTest(); PageReference pageRef = Page.YOUR_PAGENAME; // Add your VF page Name here pageRef.getParameters().put('opptyId', String.valueOf(opp.Id)); Test.setCurrentPage(pageRef); CreatePaymentController cnt = new CreatePaymentController(); cnt.redirectToPaymentDetail(); cnt.selectedInvoiceId = pm1.id; cnt.paymentPage(); Test.StopTest(); } static testMethod void MyTest1() { Account a = new Account(); a.Name = 'test'; a.Email__c = 'test@test.com'; a.CurrencyIsoCode = 'EUR'; a.Phone = '789642'; a.BillingCity= 'bhuj'; a.BillingPostalCode = '370001'; a.BillingCountry = 'india'; a.BillingLatitude = 57.5 ; a.BillingLongitude = 67.7; a.BillingState = 'Gujarat'; a.BillingStreet = 'Main'; insert a; Opportunity opp = new Opportunity(); opp.Name = 'Test Opportunity'; opp.StageName = 'Stage 0'; opp.CloseDate = system.today().addDays(10); opp.Accountid = a.id; opp.CurrencyIsoCode = 'GBP'; insert opp; Invoice__c inv = new Invoice__c(); inv.Account_Name__c = a.id; inv.Opportunity__c = opp.id; inv.CurrencyIsoCode = 'GBP'; insert inv; Invoice__c inv1 = new Invoice__c(); inv1.Account_Name__c = a.id; inv1.Opportunity__c = opp.id; inv1.CurrencyIsoCode = 'GBP'; insert inv1; Payment__c pm = new Payment__c(); pm.Invoice__c = inv.id; pm.CurrencyIsoCode = 'GBP'; insert pm; Payment__c pm1 = new Payment__c(); pm1.Invoice__c = inv.id; pm1.CurrencyIsoCode = 'GBP'; insert pm1; Test.StartTest(); PageReference pageRef = Page.YOUR_PAGENAME; // Add your VF page Name here pageRef.getParameters().put('opptyId', String.valueOf(opp.Id)); Test.setCurrentPage(pageRef); CreatePaymentController cnt = new CreatePaymentController(); cnt.redirectToPaymentDetail(); cnt.selectedInvoiceId = pm1.id; cnt.paymentPage(); Test.StopTest(); } }
Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .

Please let us know if this post will help you

November 7, 2015
·
Like
0
·
Dislike
0

Fred B
My best guess is that you have an error in one of your methods.
For debuging add throw ex; to both of your catch statements.
Also can you post your debug log?

} catch(Exception ex){
system.debug('@@ex : '+ ex.getMessage());
throw ex;
}

November 6, 2015
·
Like
1
·
Dislike
0

Antonio Manente
Either what Fred said, or it's possible that because you have so many conditionals (if, else if, etc..) you have to make sure you address every possible condition (for 100% coverage). Also, it doesn't appear you're actually testing any expected behavior. Your test class is just there for the sake of coverage.

November 6, 2015
·
Like
1
·
Dislike
0

This was selected as the best answer

Nihar Sharma
Hi Amit,

Thanks for your reply.

I have stadard page that i am redirecting on, how can i put that stadard page URL to Page.YOUR_page ?

Here is the standard URL :

/a08/e?CF00N2400000FhfdZ='+pay.Name+'&CF00N2400000FhfdZ_lkid='+pay.Id+'&saveURL=/'+opportunityId

-Nihar

November 7, 2015
·
Like
1
·
Dislike
0

Amit Chaudhary 8
You have any VF page from Where you are using above Apex class ? From where you are calling above Apex class ?

November 7, 2015
·
Like
0
·
Dislike
0

Nihar Sharma
Oh. Okay. Got your point. it's working and got 80% coverage.
Thanks once again Amit.

November 7, 2015
·
Like
1
·
Dislike
0

You need to sign in to do that.

Need an account? Sign Up

Have an account? Sign In

Dismiss

Browse by Topic

Welcome to Support!

Show

sorted by

Not able to get code coverage (only 47% get covered)

All Answers

You need to sign in to do that.