+ Start a Discussion
Shivdeep KumarShivdeep Kumar 

Test Class for custom controller!!!!

Can anyone Please help me out for this Apex Class to create a test class......


public with sharing class ListContactDetailOnCallController {     
public List<Contact> contacts {get;set;}       
public Integer contactsCount {get;set;}     
public List<Case> cases {get;set;}      
public string cPhone {get;set;}
         
Public ListContactDetailOnCallController(){         
cphone=ApexPages.currentPage().getParameters().get('phone');         
String orderId=ApexPages.currentPage().getParameters().get('orderId');         cases = [Select Id, Order_Id__c, SuppliedPhone From Case where Order_Id__c =:orderId];         
if(cphone!='' && cphone!=null){            
contacts = [Select  Name, mobilephone, ( Select Id, Order_Id__c, SuppliedPhone From Cases where Order_Id__c =:orderId  ) , Email,customer_id__c,birthdate,phone,title,ownerid,source__c                 from contact where phone like :('%' + cphone + '%')  OR MobilePhone like :('%' + cphone + '%') ORDER BY lastModifieddate]; 
                                        if(contacts.size()==0){  
               contactsCount=0;                           
 }else if(contacts.size()==1){   
              contactsCount=1;           
  }        
 }else{  
           contactsCount=0;      
   }    
 }         

 public PageReference redirPage(){     
    PageReference pR;        
 if(contactsCount==0){          
  pR=new PageReference('/003/e?retURL=%2F003%2Fo&con12='+cPhone);        
      return pR;      
   }if(contactsCount==1){          
   pR= new PageReference('/'+contacts[0].Id);          
   return pR;      
   }else{           
  return null;       
  }    
 }     
     }
 
Best Answer chosen by Shivdeep Kumar
Amit Chaudhary 8Amit Chaudhary 8
Please check below post for test classes. i hope that will help u
1) http://amitsalesforce.blogspot.in/search/label/Test%20Class
2) http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html
Please try below test class. I hope that will help u
@isTest 
public class ControllerTestClass 
{
	 static testMethod void withPhoneNumber() 
	 {
		Account testAccount = new Account();
		testAccount.Name='Test Account' ;
		insert testAccount;

		Contact cont = new Contact ();
		cont.FirstName = 'FirstName';
		cont.LastName = 'LastName';
		cont.Email='email@email.com';
		cont.phone='12345678';
		insert cont;
		
		Test.StartTest(); 

			PageReference pageRef = Page.AccountPlan; // Add your VF page Name here
			pageRef.getParameters().put('phone', '234567');
			pageRef.getParameters().put('orderId', String.valueOf(testAccount.Id));
			Test.setCurrentPage(pageRef);

			ListContactDetailOnCallController testAccPlan = new ListContactDetailOnCallController();
			testAccPlan.redirPage();	
		Test.StopTest();
	 }

	 static testMethod void withoutPhoneNumber() 
	 {
		Account testAccount = new Account();
		testAccount.Name='Test Account' ;
		insert testAccount;

		Contact cont = new Contact ();
		cont.FirstName = 'FirstName';
		cont.LastName = 'LastName';
		cont.Email='email@email.com';
		cont.phone='12345678';
		insert cont;
		
		Test.StartTest(); 

			PageReference pageRef = Page.AccountPlan; // Add your VF page Name here
			pageRef.getParameters().put('phone', '');
			pageRef.getParameters().put('orderId', String.valueOf(testAccount.Id));
			Test.setCurrentPage(pageRef);

			ListContactDetailOnCallController testAccPlan = new ListContactDetailOnCallController();
			testAccPlan.redirPage();	
		Test.StopTest();
	 }
}



Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you
 

All Answers

pconpcon
Since writing a test class to cover all of the facets of this class is not something that anyone on here will do for you, I can give you some pointers and hopefully get you started.  I would recommend that you do some reading on testing [1] [2] [3] [4] to get a better understanding.  Each of your individual tests should only tests one specific portion of you class (ie a constructor test, redirPage test, etc).  You should also have both a postitive (everything works perfectly) and a negative (things are not right) test.

For testing controllers you should also read over this [5]

Each test should follow the following structure:
  • Setup of test data. This includes creation of any data needed by your class.  Account, Contacts etc
  • Starting the test. This is calling Test.startTest() to reset the governor limits
  • Calling your class / method
  • Stopping the test.This is calling Test.stopTest() to reset the governor limits and allow for any async jobs to finish
  • Asserting that your changes have worked
    • If you have inserted/updated/deleted data, you need to query for the updates
    • Run System.assert, System.assertEquals, System.assertNotEquals to verify that you got the correct data back
If you have any specific problems with your tests, feel free to create a new post with the part of the class you are trying to test and your current test method, and you will more likely get a better response then asking for someone to essentially write an entire test class for you.

[1] http://www.sfdc99.com/2013/05/14/how-to-write-a-test-class/
[2] http://pcon.github.io/presentations/testing/
[3] http://blog.deadlypenguin.com/blog/2014/07/23/intro-to-apex-auto-converting-leads-in-a-trigger/
[4] http://blog.deadlypenguin.com/blog/testing/strategies/
[5] https://developer.salesforce.com/docs/atlas.en-us.pages.meta/pages/pages_controller_error_handling.htm
Amit Chaudhary 8Amit Chaudhary 8
Please check below post for test classes. i hope that will help u
1) http://amitsalesforce.blogspot.in/search/label/Test%20Class
2) http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html
Please try below test class. I hope that will help u
@isTest 
public class ControllerTestClass 
{
	 static testMethod void withPhoneNumber() 
	 {
		Account testAccount = new Account();
		testAccount.Name='Test Account' ;
		insert testAccount;

		Contact cont = new Contact ();
		cont.FirstName = 'FirstName';
		cont.LastName = 'LastName';
		cont.Email='email@email.com';
		cont.phone='12345678';
		insert cont;
		
		Test.StartTest(); 

			PageReference pageRef = Page.AccountPlan; // Add your VF page Name here
			pageRef.getParameters().put('phone', '234567');
			pageRef.getParameters().put('orderId', String.valueOf(testAccount.Id));
			Test.setCurrentPage(pageRef);

			ListContactDetailOnCallController testAccPlan = new ListContactDetailOnCallController();
			testAccPlan.redirPage();	
		Test.StopTest();
	 }

	 static testMethod void withoutPhoneNumber() 
	 {
		Account testAccount = new Account();
		testAccount.Name='Test Account' ;
		insert testAccount;

		Contact cont = new Contact ();
		cont.FirstName = 'FirstName';
		cont.LastName = 'LastName';
		cont.Email='email@email.com';
		cont.phone='12345678';
		insert cont;
		
		Test.StartTest(); 

			PageReference pageRef = Page.AccountPlan; // Add your VF page Name here
			pageRef.getParameters().put('phone', '');
			pageRef.getParameters().put('orderId', String.valueOf(testAccount.Id));
			Test.setCurrentPage(pageRef);

			ListContactDetailOnCallController testAccPlan = new ListContactDetailOnCallController();
			testAccPlan.redirPage();	
		Test.StopTest();
	 }
}



Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you
 
This was selected as the best answer