+ Start a Discussion
Integration 39Integration 39 

Problem hitting code coverage level

Hello,
I am having trouble hitting the code coverage level on a event trigger, i am getting 57% at the moment.

I am guessing there is something small i am missing.

Any hits would be great.

===== Trigger =====
trigger CreateReminder on Enrolment__c (after insert) {
    List<Enrolment__c> Enrolment = new List<Enrolment__c>();
    List<Event> tasks = new List<Event>();  
    
    for (Enrolment__c e: trigger.new) {
        Product2[] PD = [select Agent_Reminder__c,Enrolment_Support_Reminder__c from Product2 where Id = :e.Product__c and IsActive = TRUE];
        Group GP = [SELECT Id FROM Group where Name = 'Enrolment Support Reminders'];
        GroupMember GM = [SELECT UserOrGroupId FROM GroupMember where GroupId = :GP.id limit 1];
        String enrolment_support = GM.UserOrGroupId;
        
        for(Product2 ipd: PD ) {
       
            if (ipd.Agent_Reminder__c == true) {
                tasks.add(new Event(
                    Whatid = e.id,  
                    OwnerID = UserInfo.getUserId(),
                    Engagement__c = 'Follow Up Pending ',
                    Subject = '48 hour enrolment follow-up call',
                    Description = 'Please call your enrolled student and ensure they have successfully submitted all relevant documentation and have accepted their offer.\n\nPlease ensure they are happy with the process so far, and overcome any issues they may have.\n\nPlease send Lode Careers email and encourage the student to opt-in now.',
                    ReminderDateTime = System.now().addHours(47),
                    IsReminderSet = true,
                    DurationInMinutes = 5,
                    StartDateTime = System.now().addHours(48)
                    )
                );
            }
            
            if (ipd.Enrolment_Support_Reminder__c == true) {
                tasks.add(new Event(
                    Whatid = e.id,
                    OwnerID = enrolment_support,
                    Engagement__c = 'Follow Up Pending ',
                    Subject = 'Enrolment Support: Follow-up enrolment',
                    Description = 'Please validate this enrolment is progressing towards the first census date.',
                    DurationInMinutes = 5,
                    StartDateTime = System.now().addHours(336)
                    )
                );
            }
        }
    }  
    
    insert tasks;
}


===== Test Class =====
@isTest
private class test_create_reminder {

    @isTest(SeeAllData=false)
    private static void test_create_enrolment() {
    
        List<enrolment__c> createenrolment = new List <enrolment__c> ();
        
        List<Account> acc = [SELECT id FROM account limit 1];
        
        for (Account a: acc) {
            createenrolment.add(
                new enrolment__c(
                    Product__c = '01t90000004q3PH',
                    Account__c = a.id,
                    Call_Centre__c = 'Call_Centre__c',
                    Who_Enrolled__c = '00590000001Symm'
                )
            );
        }
        
        insert createenrolment;

    
        List<Event> tasks = new List<Event>();
        List<Enrolment__c> en = [SELECT id FROM Enrolment__c limit 1];

        for (Enrolment__c e: en) {
            Product2[] PD = [select Agent_Reminder__c,Enrolment_Support_Reminder__c from Product2 where Id = :e.Product__c];
            Group GP = [SELECT Id FROM Group where Name = 'Enrolment Support Reminders'];
            GroupMember GM = [SELECT UserOrGroupId FROM GroupMember where GroupId = :GP.id limit 1];
            String enrolment_support = GM.UserOrGroupId;
                
            for(Product2 ipd: PD ) {
                if (ipd.Agent_Reminder__c == true) {
                    tasks.add(new Event(
                            Whatid = e.id,  
                            OwnerID = UserInfo.getUserId(),
                            Engagement__c = 'Follow Up Pending ',
                            Subject = '48 hour enrolment follow-up call',
                            Description = 'Please call your enrolled student and ensure they have successfully submitted all relevant documentation and have accepted their offer.\n\nPlease ensure they are happy with the process so far, and overcome any issues they may have.\n\nPlease send Lode Careers email and encourage the student to opt-in now.',
                            ReminderDateTime = System.now().addHours(47),
                            IsReminderSet = true,
                            DurationInMinutes = 5,
                            StartDateTime = System.now().addHours(48)
                            )
                    );
                }

                if (ipd.Enrolment_Support_Reminder__c == true) {
                    tasks.add(new Event(
                        Whatid = e.id,
                        OwnerID = enrolment_support,
                        Engagement__c = 'Follow Up Pending ',
                        Subject = 'Enrolment Support: Follow-up enrolment',
                        Description = 'Please validate this enrolment is progressing towards the first census date.',
                        DurationInMinutes = 5,
                        StartDateTime = System.now().addHours(336)
                        )
                    );  
                }
            }   
            
            insert tasks;
        }
    }
}
Best Answer chosen by Integration 39
Amit Chaudhary 8Amit Chaudhary 8
Please check below post. I hope that will help you
1) http://amitsalesforce.blogspot.com/search/label/Test%20Class
2) http://amitsalesforce.blogspot.com/2015/06/best-practice-for-test-classes-sample.html
Please try below code. I hope that will help u
@isTest
private class test_create_reminder 
{
	static testMethod void testMethod1()
	{
		Product2 prod = new Product2(Name = 'Laptop X200', Family = 'Hardware' , Enrolment_Support_Reminder__c = true , Agent_Reminder__c = true );
        insert prod;
        
        Id pricebookId = Test.getStandardPricebookId();
        
        PricebookEntry standardPrice = new PricebookEntry(   Pricebook2Id = pricebookId, Product2Id = prod.Id, UnitPrice = 10000, IsActive = true);
        insert standardPrice;
        
        Pricebook2 customPB = new Pricebook2(Name='Custom Pricebook', isActive=true);
        insert customPB;
        
        PricebookEntry customPrice = new PricebookEntry(   Pricebook2Id = customPB.Id, Product2Id = prod.Id, UnitPrice = 12000, IsActive = true);
        insert customPrice;	
	
		Account acc = new Account();
		acc.Name='demo';
		insert acc;
		
        enrolment__c enr = new enrolment__c(
                    Product__c = prod.id,
                    Account__c = acc.id,
                    Call_Centre__c = 'Call_Centre__c'
                ) ;
			
		insert enr;

    }
}
Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you


 

All Answers

K@SK@S
Hi Int,
Don't  write trigger inside querys
You need to change the testclass to insert manualy the values
first insert a account then task fileds whenever you write a test class required fields Compulsory write the values.

 
Amit Chaudhary 8Amit Chaudhary 8
Please check below post. I hope that will help you
1) http://amitsalesforce.blogspot.com/search/label/Test%20Class
2) http://amitsalesforce.blogspot.com/2015/06/best-practice-for-test-classes-sample.html
Please try below code. I hope that will help u
@isTest
private class test_create_reminder 
{
	static testMethod void testMethod1()
	{
		Product2 prod = new Product2(Name = 'Laptop X200', Family = 'Hardware' , Enrolment_Support_Reminder__c = true , Agent_Reminder__c = true );
        insert prod;
        
        Id pricebookId = Test.getStandardPricebookId();
        
        PricebookEntry standardPrice = new PricebookEntry(   Pricebook2Id = pricebookId, Product2Id = prod.Id, UnitPrice = 10000, IsActive = true);
        insert standardPrice;
        
        Pricebook2 customPB = new Pricebook2(Name='Custom Pricebook', isActive=true);
        insert customPB;
        
        PricebookEntry customPrice = new PricebookEntry(   Pricebook2Id = customPB.Id, Product2Id = prod.Id, UnitPrice = 12000, IsActive = true);
        insert customPrice;	
	
		Account acc = new Account();
		acc.Name='demo';
		insert acc;
		
        enrolment__c enr = new enrolment__c(
                    Product__c = prod.id,
                    Account__c = acc.id,
                    Call_Centre__c = 'Call_Centre__c'
                ) ;
			
		insert enr;

    }
}
Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you


 
This was selected as the best answer