function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
Emma TolleyEmma Tolley 

Test Class Help for Newbie

Hi All,

Please help a struggling newbie (very struggling & very new!). I have an Apex Class & a VisualForce page which I believe should work. I am completely failing in writing a test class that gives me anything greater than 0% code coverage in my sandbox.

The basic premise is that I want to display a filtered list of records from my custom object in a visualforce page, the user will then be able to update certain fields, press Save and the records will update.

My apex class & visualforce page (/FTFEdit) code are below (these have been improved by a kind developer on these forums already).

Please, please can a nice kind person help me with a test class that works.

Thanks
Emma
 
public with sharing class Controller_FTFView{
    public List<PD_Record__c> FTFRecords {get; set;}

    public Controller_FTFView(){
        FTFRecords= [
            SELECT Name, Closure_Outcome__c, FTF__c, FTF_Comment__c, FTF_Reason__c, RFA_Number__c,WR_Number__c
            FROM PD_Record__c
            WHERE WMIS_Patch__c Like '11A5%' AND Owner_Is_Me__c = 0 AND Job_Status__c = 'Closed - Successful' AND (Closure_Outcome__c = 'Parts Ordered - In Stock' OR Closure_Outcome__c = 'Parts Ordered - OOS - Is obtainable' or Closure_Outcome__c = 'One Time Buy - Obtainable' or Closure_Outcome__c = 'Safety Reasons i.e. Manufacturer referral' or Closure_Outcome__c = 'Appliance Replacement Rec. (ART)')];
    }

    public PageReference save(){
        try{
            update FTFRRecords;
        }catch(DMLException e){
            //Report DML exceptions to the Apex Page messages element in Visualforce
            ApexPages.addMessage(new ApexPages.Message(ApexPages.Severity.Error,e.getMessage()));
        }

        //Returning null for the page reference, directs user back to the same VF page, but rerenders values.
        //Otherwise, you could return another Visualforce page or a link to a record's detail page here as well.
        return null;
    }

    public PageReference cancel(){
        //Return a link to the parent record perhaps or do something else besides return null here
        return null;
    }
}
<apex:page Controller="Controller_FTFView" >
    <apex:sectionHeader title="" subtitle="Mass Edit"/>
    <apex:pageMessages id="messages" />
    <apex:form >
            <apex:pageBlock mode="detail" title="Edit the following records" id="pb">
            <apex:pageBlockButtons >
                <apex:commandButton action="{!save}" value="Save" rerender="pb,messages"/>
                <apex:commandButton action="{!cancel}" value="Cancel" rerender="pb,messages"/>
                 </apex:pageBlockButtons>          
            <apex:pageBlockSection columns="1">
                  <apex:pageBlockTable value="{!FTFRecords}" var="p">
                    <apex:column value="{!p.Name}"/>          
                    <apex:column value="{!p.WR_Number__c}"/>
                    <apex:column value="{!p.RFA_Number__c}"/>
                    <apex:column value="{!p.Closure_Outcome__c}"/>     
                    <apex:column headerValue="FTF?" >                   
                        <apex:inputField value="{!p.FTF__c}"/>
                    </apex:column>
                    <apex:column headerValue="FTF Reason" >                   
                        <apex:inputField value="{!p.FTF_Reason__c}"/>
                    </apex:column>
                    <apex:column headerValue="FTF Comment" >
                        <apex:inputField value="{!p.FTF_Comment__c}"/>
                    </apex:column>                    
                  </apex:pageBlockTable>
       </apex:pageBlockSection>
        </apex:pageBlock>
    </apex:form>
</apex:page>



 
James LoghryJames Loghry
Take some time to go through the Apex Testing trailhead module (https://developer.salesforce.com/trailhead/module/apex_testing)  It should give you a good start on writing your first apex test class.  
Amit Chaudhary 8Amit Chaudhary 8
Please check below post for test classes.
1) http://amitsalesforce.blogspot.com/search/label/Test%20Class
2) http://amitsalesforce.blogspot.com/2015/06/best-practice-for-test-classes-sample.html
3) https://developer.salesforce.com/trailhead/module/apex_testing (http://(https://developer.salesforce.com/trailhead/module/apex_testing)

For Example you can see below post
1) http://amitsalesforce.blogspot.com/2015/06/best-practice-for-test-classes-sample.html

If you want to see the over all code coverage of your org. You can try below app exchange product
https://appexchange.salesforce.com/listingDetail?listingId=a0N3000000DXzlpEAD

Please try below code. I hope that will help u
@isTest 
public class Controller_FTFViewTest 
{
	static testMethod void testMethod1() 
	{
		Account testAccount = new Account();
		testAccount.Name='Test Account' ;
		insert testAccount;
		
		//PD_Record__c obj = new PD_Record__c();
		// Add All required field here
		// insert obj;

		Test.StartTest(); 


			try
			{
				Controller_FTFView testAccPlan = new Controller_FTFView();
				testAccPlan.cancel();
				testAccPlan.save();
			}
			catch(Exception ee)
			{
			}	
			
		Test.StopTest();
	}
}

Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

 
Emma TolleyEmma Tolley
Guys. I am greatful for you trying to help, honestly I am, but I am no further forward.

James - the 1st module basically says, copy this code (done), write a test class (no instructions HOW) and run. My problem is I cannot write a test class so this is just more frustration for me!!!

Amit - your code as a test gives 0% code coverage, again, I am greatful for this but when I have no idea what I need to write to test this, I am just tearing my hair out. Your best practice advice is about 17 steps further on than I am.

I just need to get something, ANYTHING to work. I am ready to cry. I am so close to telling my company that Salesforce is un-useable unless we pay £1,000s to a developer & going back to the old methods of Excel & Access.
Alex KirbyAlex Kirby
Hi Emma,

When you tried Amits code did you uncomment the section relating to your PD_Record__c object?
 
@isTest 
public class Controller_FTFViewTest 
{
	static testMethod void testMethod1() 
	{
		//Account testAccount = new Account();
		//testAccount.Name='Test Account' ;
		//insert testAccount;
		
		PD_Record__c obj = new PD_Record__c();
	
           //*******You need to enter your required fields here*****//

                obj.closure_outcome__c = 'Closure Outcome';
                obj.FTF__c = 'Something';

           //and so on

		 insert obj;

		Test.StartTest(); 

                 Test.setCurrentPage(page.your_page_name);

			try
			{
				Controller_FTFView testAccPlan = new Controller_FTFView();
				testAccPlan.cancel();
				testAccPlan.save();
			}
			catch(Exception ee)
			{
			}	
			
		Test.StopTest();
	}
}

It can be disheartening, but you'll get there. I hadn't touched Salesforce before I was thrown in and now I am 2 years down the line and getting there. Still al long way to go.Excel and Access have their place but they are no match for Salesforce. What can be achieved on this platform is pretty impressive.
Amit Chaudhary 8Amit Chaudhary 8
Hi Emma Tolley,

I hope you click on Run Test Button on your test class ? Please Execute you Test class and check code coverage