Apex Code Development You need to sign in to do that
Don't have an account?
Converting an Apex trigger to an Apex class
With much help from @pcon, I've now got a pretty sweet trigger that I need for my org. I know that a best practice is to work with classes vs. triggers, so I've attempted to convert my trigger to a class. Can anyone help to verify that I've done this correctly and also perhaps provide some guidance on writing a test class for it?
public class UpdateParentUtility {
Public static void updateParentProject(List<project__c> listProjects) {
Map<String, RecordType> rtMap = new Map<String, RecordType>();
// Build a map of record type name to record types
for (RecordType rt : [
select Name
from RecordType
where Name = 'Parent Project' or
Name = 'Child Project'
]) {
rtMap.put(rt.Name, rt);
}
Set<Id> taskrayParentIds = new Set<Id>();
// Iterate over all the projects
for (Project__c theProject : listProjects) {
// If we are dealing with a "child project" then put it's taskray parent Id in the set
if (theProject.RecordTypeId == rtMap.get('Child Project').Id) {
taskrayParentIds.add(theProject.Get_Parent_Project__c);
}
}
// Remove any null ids
taskrayParentIds.remove(null);
// If we have taskray parents, deal with them
if (!taskrayParentIds.isEmpty()) {
Map<Id, String> taskrayMap = new Map<Id, String>();
// Get all the taskray projects we need to deal with and map their Id to their name
for (Taskray__Project__c trp : [
select Name
from Taskray__Project__c
where Id in :taskrayParentIds
]) {
taskrayMap.put(trp.Id, trp.Name);
}
Map <String, Project__c> parentProjectMap = new Map <String, Project__c>();
// Build a map of project names to projects for any projects that match our taskray name and are "parent projects"
for (Project__c parentProject : [
select Name
from Project__c
where Name in :taskrayMap.values() and
RecordTypeId = :rtMap.get('Parent Project').Id
]) {
parentProjectMap.put(parentProject.Name, parentProject);
}
// Iterate through all the projects and do the mapping
for (Project__c theProject : listProjects) {
// Bail out if we're not dealing with a "child project"
if (theProject.RecordTypeId != rtMap.get('Child Project').Id) {
continue;
}
// Bail out if we can't find the task ray project for that id
if (!taskrayMap.containsKey(theProject.Get_Parent_Project__c)) {
continue;
}
// Bail out if we cant find a parent project for the task ray project name
if (!parentProjectMap.containsKey(taskrayMap.get(theProject.Get_Parent_Project__c))) {
continue;
}
// Set the parent project lookup
theProject.Parent_Project__c = parentProjectMap.get(taskrayMap.get(theProject.Get_Parent_Project__c)).Id;
}
}
}
}
http://amitsalesforce.blogspot.com/2015/06/trigger-best-practices-sample-trigger.html
Please let is know if this will help you
Thanks
Amit Chaudhary
1) http://amitsalesforce.blogspot.com/search/label/Test%20Class
2) http://amitsalesforce.blogspot.com/2015/06/best-practice-for-test-classes-sample.html
if you calling above class from trigger then please perfome the DML inside test class class will call automaticly
@isTest public class TriggerTestClass { static testMethod void testMethod1() { // Perform DML here only } }Please follow below salesforce Best Practice for Test Classes :-1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .
Please let us know if this post will help you