Hi,

I have a trigger which I and the user have tested in the Sandbox. 

I also have a test class for it and it passes that.

It is failing on deployment and I believe i have tracked it to once statement but cannot see issue:

Here is the trigger:

trigger TerrZipAdd on Territory_ZIP_Code__c (after insert, after update) {
	
    User mrOpen = [select id,name from User where name=:RequestOwnershipService.MR_OPEN_NAME]; 
    AccountShare[] newShares = new AccountShare[0];   

	set<ID> idsn = Trigger.newmap.keySet();
	list<Territory_Zip_Code__c> tzcRecsn = [SELECT Id, Name, GroupId__c, SharingMode__c FROM Territory_Zip_Code__c WHERE ID in :idsn];
	for (Territory_Zip_Code__c tzcn: tzcRecsn) {
  
    //JJB Blackiron 8-2011 Per Brian he wanted the hard exclusion of the 3 profiles        
    //for(Territory_Zip_Code__c tzcn : Trigger.new) {  
        List<Account> AccountZipRecs =
            [SELECT id,  OwnerId
            FROM Account  
            //WHERE BillingPostalCode = :tzcn.Name];
            WHERE BillingPostalCode = :tzcn.Name 
            and Owner.ProfileId  not in 
			('00e30000000mIYBAA2', '00e700000017F9PAAU', '00e50000000nDWbAAM')];
            
        Group gr;
        if(tzcn.GroupId__c != null) { 
            try {
                system.debug('about to try name match');
                gr = [Select id from Group where Name = :tzcn.GroupID__c];
            }
            catch (Exception ex) {
                   system.debug('about to try id');
 	            try
	            {
	                gr = [Select Id, Name from Group where Id = :tzcn.GroupID__c];
	            }
	            catch (Exception ex1) {
	            }   
            } 
        } 
        system.debug('the group id is ' + gr.id);                 
        if(gr.id != null) {
	       // We have our list of accounts affected; now add shares for the new group ID
			
			for (Account accshare: AccountZipRecs)
			{
		    	// Set the access level
		        string accountAccessLevel = null;
		        string opportunityAccessLevel = null;
		        Boolean fullAccess = false; 
	                
		        if(accshare.ownerId == mrOpen.id)
		        	fullAccess = true;
	                // SharingMode can have 3 values: null, 'Default', 'Telesales'
	                if(tzcn.SharingMode__c == 'Telesales')
	                {
	                    accountAccessLevel = 'Edit';
	                    opportunityAccessLevel = 'None';
	                }
	                else
	                {
	                   accountAccessLevel = fullAccess ? 'Edit' : 'Read';
	                   opportunityAccessLevel = fullAccess ? 'Read' : 'None';
	                }
	                // Create new share
	                AccountShare newShare = new AccountShare();
	                newShare.UserOrGroupId = gr.id;
	                newShare.AccountId = accshare.id;
	                newShare.AccountAccessLevel = accountAccessLevel;
	                newShare.OpportunityAccessLevel = opportunityAccessLevel;
	                // Copy the share
	                newShares.add(newShare);
		                
	        }  //For loop bracket  
	    }    // If gr.id !null 
    }
     
    // Anything to insert?
    if (newShares.size() == 0)
        return;
 
    // Insert safely
    try
    {
        Database.SaveResult[] results = Database.insert(newShares, false);
        
        for (Database.SaveResult sr : results)
        {
            if (sr.isSuccess())
                continue;
            for (Database.Error edb : sr.getErrors())
 	           System.debug('-->     sr: ' + edb.getMessage());
            }
    }
    catch (DmlException edb) {
    }     
}

 Now in trying to see what was wrong I commented the lower half of the trigger where I go through the for loop and do insert out and it passed validation, so it would seem the top portion is okay. 

It seems it does like the for statement:

for (Account accshare: AccountZipRecs)

any help greatly appreciated, I would like to be able tp get the deploayed.