Hi weznolte,

i tried you code but got the same error... I have amended the code can you have a look at this and see what the problem may be?

trigger Sales_Manager_Trigger on BGB_Contract__c (before insert, before update) {

List <BGB_Sales_Employees__c> arrRenNegs = new list <BGB_Sales_Employees__c>();
Set<Id> contractIds = new Set<Id>();


    for (BGB_Contract__c bgbContract : Trigger.new)
    {
    	//contractIds.add(bgbContract.Renewal_Negotiators__c);
    	
	   //Not to fire Trigger if user is equal to 'Sean Churchill'
       if (UserInfo.getName()<> 'Sean Churchill')
       
       {
           
                bgbContract.Sales_Manager__c = null;
            arrRenNegs = [select name from BGB_Sales_Employees__c where ID = :bgbContract.Renewal_Negotiators__c];
            
                if (arrRenNegs.size()>0)
                {
                    List <user> arrUsers = new List <user>();
                    arrUsers = [select ID from User where Name = :arrRenNegs.get(0).Name];
                    
                    if (arrUsers.size()>0)
                    {
                        bgbContract.Sales_Manager__c = arrUsers.get(0).ID;
                    }
                }
                
            }
    }

}

 the error i get is the following: -

Sales_Manager_Trigger: execution of BeforeUpdate

caused by: System.Exception: Too many SOQL queries: 21

Trigger.Sales_Manager_Trigger: line 17, column 26

Which is the same place as below...

trigger Sales_Manager_Trigger on BGB_Contract__c (before insert, before update) {

List <BGB_Sales_Employees__c> arrRenNegs = new list <BGB_Sales_Employees__c>();
Set<Id> contractIds = new Set<Id>();


    for (BGB_Contract__c bgbContract : Trigger.new)
    {
    	contractIds.add(bgbContract.Renewal_Negotiators__c);
    } // close the loop here
	   //Not to fire Trigger if user is equal to 'Sean Churchill'
       if (UserInfo.getName()<> 'Sean Churchill')
       
       {
           
                bgbContract.Sales_Manager__c = null;
            arrRenNegs = [select name from Sales_Employees__c where ID IN :contractIds]; 		// Since you aren't in a loop this the first query
            
                if (arrRenNegs.size()>0)
                {
                    List <user> arrUsers = new List <user>();
                    arrUsers = [select ID from User where Name = :arrRenNegs.get(0).Name]; // No loop, so this is query number 2. You have only run 2 queries (this one and the previous) each time the trigger fires.
                    
                    if (arrUsers.size()>0)
                    {
                        bgbContract.Sales_Manager__c = arrUsers.get(0).ID;
                    }
                }
                
            }

}

Thanks for your help... I have done what you have said and i get the following error?

"Save error: Expression cannot be assigned"

not sure what this means?? below is the updated code i had to re-declared BGB_contracts__c var as the bgbContract was in the loop.

Any ideas???

here the error:

Description	Resource	Path	Location	Type
Save error: Expression cannot be assigned	Sales_Manager_Trigger.trigger	Test/src/triggers	line 0	Force.com save problem

here the code: -

trigger Sales_Manager_Trigger on BGB_Contract__c (before insert, before update) {

List <BGB_Sales_Employees__c> arrRenNegs = new list <BGB_Sales_Employees__c>();
Set<Id> contractIds = new Set<Id>();


    for (BGB_Contract__c bgbContract : Trigger.new)
    {
    	contractIds.add(bgbContract.Renewal_Negotiators__c);
    }	
	   //Not to fire Trigger if user is equal to 'Sean Churchill'
       if (UserInfo.getName()<> 'Sean Churchill')
       
       { 
           
                BGB_Contract__c.Sales_Manager__c = null;
                       
            arrRenNegs = [select name from BGB_Sales_Employees__c where ID = :BGB_Contract__c.Renewal_Negotiators__c];
            
                if (arrRenNegs.size()>0)
                {
                    List <user> arrUsers = new List <user>();
                    arrUsers = [select ID from User where Name = :arrRenNegs.get(0).Name];
                    
                    if (arrUsers.size()>0)
                    {
                        BGB_Contract__c.Sales_Manager__c = arrUsers.get(0).ID;
                    }
                }
                
            }
    }

Take this code and copy and paste it. Don't change anything. If you get an error tell me what it is.

trigger Sales_Manager_Trigger on BGB_Contract__c (before insert, before update) {

List <BGB_Sales_Employees__c> arrRenNegs = new list <BGB_Sales_Employees__c>();
Set<Id> contractIds = new Set<Id>();


    for (BGB_Contract__c bgbContract : Trigger.new)
    {
    	contractIds.add(bgbContract.Renewal_Negotiators__c);
    }	
	   
	//Not to fire Trigger if user is equal to 'Sean Churchill'
	if (UserInfo.getName()<> 'Sean Churchill')

	{ 
	   arrRenNegs = [select name from BGB_Sales_Employees__c where ID IN :contractIds]; // don't change this line. Resist the temptation.
		
			if (arrRenNegs.size()>0)
			{
				List <user> arrUsers = new List <user>();
				arrUsers = [select ID from User where Name = :arrRenNegs.get(0).Name];
				
				if (arrUsers.size()>0)
				{
					BGB_Contract__c.Sales_Manager__c = arrUsers.get(0).ID;
				}
			}
			
	}
}

Hi,

I get the following error still after copying your copy and not changing anything: -

Description Resource Path Location Type
Save error: Expression cannot be assigned Sales_Manager_Trigger.trigger Test/src/triggers line 0 Force.com save problem

??

trigger Sales_Manager_Trigger on BGB_Contract__c (before insert, before update) {

List <BGB_Sales_Employees__c> arrRenNegs = new list <BGB_Sales_Employees__c>();
Map<id,BGB_Contract__c> contracts = Map<id, BGB_Contract__c>();

    for (BGB_Contract__c bgbContract : Trigger.new)
    {
contracts.put(bgbContract.id, bgbContract);
    }		   
	//Not to fire Trigger if user is equal to 'Sean Churchill'
	if (UserInfo.getName()<> 'Sean Churchill')

	{ 
	   arrRenNegs = [select name from BGB_Sales_Employees__c where ID IN :contracts.keySet()];
		
			if (arrRenNegs.size()>0)
			{
				List <user> arrUsers = new List <user>();
				arrUsers = [select ID from User where Name = :arrRenNegs.get(0).Name];
				
				if (arrUsers.size()>0)
				{
					BGB_Contract__c.Sales_Manager__c = arrUsers.get(0).ID; // this is your problem line. Your not using a variable. Using my changes above you need some way to select a contract e.g. contracts.get('a bgbContract id').Sales_manager__c = arrUsers.get(0).id
				}
			}
			
	}
}