function readOnly(count){ }
Sign Up ›
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
Learn More

Browse by Topic
ShowAll Questionssorted byDate Posted
+ Start a Discussion
jasonrtaylorjasonrtaylor 

Trigger not updating

I am trying to update the parent opportunity record with a count of all child records that meet a specified criteria when a new child custom object is created or modified. I have checked the SOQL queries and they are returning the results I expected. The opportunity relationship field is present and required.

 

trigger UpdatePendingPOMRequests on DM__c (after insert, after update) {

    //Find ID for 'POM' Record Type
    RecordType rt = [Select r.Id from RecordType r WHERE r.name = 'POM' AND r.SobjectType = 'DM__c'];

for(DM__c dm : trigger.new){
       if(dm.RecordTypeId == rt.id){

            integer dmct = [Select Count()
                            FROM DM__c d
                            WHERE dm__c.dm_opportunity_id__c = :dm.dm_opportunity_id__c
                            AND dm__c.RecordTypeId = :rt.id
                            AND dm__c.POM__c = 'Pending'
                            ];           
            Opportunity oid = [Select Num_Pending_NSP__c from Opportunity WHERE id =:dm.dm_opportunity_id__c ];
            oid.Num_Pending_NSP__c = dmct;

        Database.upsert(oid);
       }
    }
}

 

Thanks, in advance for your response.

Best Answer chosen by Admin (Salesforce Developers) 
User@SVFUser@SVF

Jasonrtaylor,

 

try the below code and check if it works.

 

 

trigger UpdatePendingPOMRequests on DM__c (after insert, after update) {
    //Find ID for 'POM' Record Type 
    Id RecType = [Select r.Id from RecordType r WHERE r.Name = 'POM' AND r.SobjectType = 'DM__c' Limit 1].Id;
    List<Opportunity> lstOpp = new List<Opportunity>();
    
    for(DM__c dm : trigger.new){
        if(dm.RecordTypeId == RecType){
            integer dmct = [Select Count() FROM DM__c d 
                                WHERE d.dm_opportunity_id__c = :dm.dm_opportunity_id__c
                                AND d.RecordTypeId = :RecType
                                AND d.POM__c = 'Pending'
                           ];

            Opportunity oid = [Select Num_Pending_NSP__c from Opportunity WHERE id =:dm.dm_opportunity_id__c ];
            oid.Num_Pending_NSP__c = dmct;
            lstOpp.add(oid);
       }
    }
    Database.update(lstOpp);
}

***  I did not add exception handling in the code.

 

All Answers

User@SVFUser@SVF

Hi Jasonrtaylor,

 

Before getting into the solution, I think that the functionality that you are trying to implement in the trigger can be done using standard salesforce functionality using the roll-up summary fields.

 

Create a roll-up summary field on opportunity and select roll-up type as "Count" and filter criteria as "Only records meeting certain criteria should be included in the calculation" and give your critera for record type name = 'pom' and Pom__c = 'Pending'.

 

If you are not able to access all the fields in the roll-up summary field filter criteria, create formula field "DM Pending Count" in DM object which returns TRUE if RecordType = 'Pom' and POM__c = 'Pending'. Then in the roll-up summary field filter criteria, just refer "DM Pending Count"  = TRUE.

 

Hope this helps.

 

 

*** TIP : When writing apex, never use the DML statements inside for loop. Instead add the record to a list and insert the list outside for loop.
jasonrtaylorjasonrtaylor

If we had the luxury of a Master-Detail relationship, that would definitely be the solution. Since this is just a lookup relationship, we are relegated to a trigger.

 

I am aware of the DML Limits on Triggers, and I will "Bulkify" the trigger after it is functioning as expected.

 

Thank you.

 

-Jason
User@SVFUser@SVF

Jasonrtaylor,

 

try the below code and check if it works.

 

 

trigger UpdatePendingPOMRequests on DM__c (after insert, after update) {
    //Find ID for 'POM' Record Type 
    Id RecType = [Select r.Id from RecordType r WHERE r.Name = 'POM' AND r.SobjectType = 'DM__c' Limit 1].Id;
    List<Opportunity> lstOpp = new List<Opportunity>();
    
    for(DM__c dm : trigger.new){
        if(dm.RecordTypeId == RecType){
            integer dmct = [Select Count() FROM DM__c d 
                                WHERE d.dm_opportunity_id__c = :dm.dm_opportunity_id__c
                                AND d.RecordTypeId = :RecType
                                AND d.POM__c = 'Pending'
                           ];

            Opportunity oid = [Select Num_Pending_NSP__c from Opportunity WHERE id =:dm.dm_opportunity_id__c ];
            oid.Num_Pending_NSP__c = dmct;
            lstOpp.add(oid);
       }
    }
    Database.update(lstOpp);
}

***  I did not add exception handling in the code.

 

This was selected as the best answer
jasonrtaylorjasonrtaylor

This worked great!!!. Thank you.