Hi all,

I need some help with covering a trigger.  My test calss gets me 58% of the way there but I would relly like to get closer to 100%.

My trigger is not big and should be easy help.  Just need pointed in the right direction.

Trigger that I am trying to cover:

OpportunityContactAssoc (Code Covered: 58%)
 line  source 
 1   trigger OpportunityContactAssoc on Opportunity (before insert, before update) { 
 2   List<Contact> cntList = new List<Contact>(); 
 3   List<OpportunityContactRole> oppCntRole = new List<OpportunityContactRole>(); 
 4   public String cntID {get;set;} 
 5    
 6    for (Opportunity o: Trigger.new) { 
 7    if (o.Customer_Number__c != null) 
 8    { 
 9    try {Contact cnts = [select Id, cnt_plcsc_CustNmbr_ExtID__c, cnt_plcsc_Customer_Number__c 
 10    from Contact 
 11    where cnt_plcsc_Customer_Number__c =: o.Customer_Number__c 
 12    And cnt_plcsc_CustNmbr_ExtID__c =: o.Customer_Number__c + 'Ins01' limit 1]; 
 13    cntID = cnts.Id; 
 14    cntList.add(cnts);} catch (Exception e) {System.debug('Contact Record Does Not Exist.' + cntID);} 
 15    
 16    if(cntID != null) 
 17    { 
 18    OpportunityContactRole ocr = new OpportunityContactRole(ContactId=cntID, OpportunityID = o.Id, 
 19    Role = 'Primary Insured', IsPrimary = true); 
 20    upsert new List<OpportunityContactRole>{ocr}; 
 21    
 22    for(OpportunityContactRole oppcnts : [select Id, ContactId, OpportunityId, Role, IsPrimary 
 23    from OpportunityContactRole 
 24    where IsPrimary =: false And Role =: 'Primary Insured' And OpportunityId =: o.Id]) 
 25    { 
 26    delete oppcnts; 
 27    } 
 28    
 29    } 
 30    } 
 31    else { 
 32    try { Contact cnts = [select Id, MailingStreet, MailingState, cnt_plcsc_Customer_Number__c, 
 33    MailingPostalCode, MailingCity, LastName, FirstName, Email 
 34    from Contact 
 35    where Email =: o.Consumer_Email__c And MailingPostalCode =: o.Zip__c And RecordTypeId =: '01240000000DVfa' limit 1]; 
 36    cntID = cnts.Id; 
 37    o.Customer_Number__c = cnts.cnt_plcsc_Customer_Number__c; 
 38    cntList.add(cnts);} catch (Exception e) {System.debug('Contact Record Does Not Exist.');} 
 39    
 40    if(cntID != null){ 
 41    OpportunityContactRole ocr = new OpportunityContactRole(ContactId=cntID, OpportunityID = o.Id, 
 42    Role = 'Primary Insured', IsPrimary = true); 
 43    upsert new List<OpportunityContactRole>{ocr}; 
 44    } 
 45    } 
 46    } 
 47   } 

 test class (please don't laugh:smileywink:):

@isTest
private class TestOpportunityContactRole {

    static testMethod void TestmyOpportunityContactRoleTrigger() {
        
// TO DO: implement unit test
        Test.startTest();
        
		Contact cntExisting = new Contact(
        FirstName = 'Test', LastName = 'Tester', RecordTypeId = '01240000000DVfaAAG', Email='test@hanover.com', 
        cnt_plcsc_CustNmbr_ExtID__c = '123456789INS01', cnt_plcsc_Customer_Number__c='123456789');
    	insert cntExisting;
    	
    	Contact cntExisting2 = new Contact(
        FirstName = 'Test', LastName = 'Tester2', RecordTypeId = '01240000000DVfaAAG', Email='test2@hanover.com', 
        cnt_plcsc_CustNmbr_ExtID__c = '2123456789INS01', cnt_plcsc_Customer_Number__c='2123456789');
    	insert cntExisting;
    	
    	Opportunity myOppPolicyTest = new Opportunity(StageName='Quoted', CloseDate=Date.today(), Name='Tester1', 
    	Policy_Id__c='ABC1234567', Pol_Sym__c='ABC', Pol_No__c='1234567',LOB__c='Auto', 
    	opp_plcsc_Integration_ID__c='A1234567', Customer_Number__c = '123456789');
		insert myOppPolicyTest;
    	                
        OpportunityContactRole ocr = new OpportunityContactRole(OpportunityId = myOppPolicyTest.Id,
		ContactId = cntExisting.Id, Role = 'Primary Insured', IsPrimary = true);
		upsert new List<OpportunityContactRole> {ocr};
		
		System.assert(myOppPolicyTest.Customer_Number__c == '2123456789');
        Test.stopTest();
    }
}