Apex Code Development You need to sign in to do that
Don't have an account?
Sabah Farhana Error in creating trigger
Hi all,
Iam getting an error in the line highlighted below.Is this the correct way to write it
trigger updateGroupLookup on Case (before insert) {
for (Case c : Trigger.new) {
if(c.groupid__c!= null){
c.group_Account__c = [select id from account where Group_ID__c =c.groupid__c];
}
}
Iam getting an error in the line highlighted below.Is this the correct way to write it
trigger updateGroupLookup on Case (before insert) {
for (Case c : Trigger.new) {
if(c.groupid__c!= null){
c.group_Account__c = [select id from account where Group_ID__c =c.groupid__c];
}
}
Hi sabah,
1) Never use SOQL query in Loop (either Initialization level or inside loop)
2) Check for NULL at object level first then check for field otherwise it may throw NULL Pointer Exception
3) Try to use IN keyword for multiple id, do not use same query again and again for each id.
try below code,
trigger updateGroupLookup on Case (before insert) {
List<Case> caseList = Trigger.NEW;
for(Case c: caseList) {
if(c != null && c.groupId__c != null) {
}
}
}
Regards,
Michael
All Answers
1. You are using SOQL Inside the for loop.
2. Getting SOQL Result and assigning this to Field instead of object this is wrong.
The correct way is
List<Case> caseList = [select id from account where Group_ID__c =c.groupid__c];
3. Remove SOQL from for loop and use MAP or SET..
Hi sabah,
1) Never use SOQL query in Loop (either Initialization level or inside loop)
2) Check for NULL at object level first then check for field otherwise it may throw NULL Pointer Exception
3) Try to use IN keyword for multiple id, do not use same query again and again for each id.
try below code,
trigger updateGroupLookup on Case (before insert) {
List<Case> caseList = Trigger.NEW;
for(Case c: caseList) {
if(c != null && c.groupId__c != null) {
}
}
}
Regards,
Michael
c.group_Account__c = [select id from account where ID=:c.groupid__c].ID;
let me know error if it not works.