Hi,

I tried to write my trigger and test class (I am just starting as an admin) based on the following blog post:
http://knthornt.wordpress.com/2011/07/29/updating-products-on-opportunity-close-date-change/

I wanted to start the trigger in case of changes in the Stage. I created a Stage field on OLI (Opp Product), the trigger should update the picklist whenever it is changed on the Parent Opportunity.

The trigger is working, that's great, but I can't right the test class and therefor I am not able to push it into Production.
Could the issue be that the error/issue is related to (old) API version? (blog post is from 2011/07/29). I already added "(SeeAllData = true)" but not solved yet ... Failed Class Test, but code coverage is 43% (7/16)

Thanks, Benny

My trigger: 

trigger Opportunity_StageName_Update on Opportunity (after update) {

    //get the Ids of our EU AOE record type and add them to a set
    Set<Id> recTypeIds = new Set<Id>();
    for(RecordType r : [select Id, Name from RecordType where (Name='EU AOE Opportunity') AND SobjectType='Opportunity']){
        recTypeIds.add(r.id);
    }
     
    //check the opportunities in the trigger to see if the StageName changed AND any are of the RecordTypes above. 
    //if so add them to a Set
    Set<Id> EUAOEOppIds = new Set<Id>();
    for(Integer i=0;i<trigger.new.size();i++){
        if(trigger.new[i].StageName <> trigger.old[i].StageName && recTypeIds.contains(trigger.new[i].RecordTypeId)){
            EUAOEOppIds.add(Trigger.new[i].id);
        }
    }
     
    //Process any opps that have changed
    if(EUAOEOppIds.size() > 0){
        //get all of the opportunity Line items tied to opportunities in this trigger
        List<Opportunity> oliList = [select Id, Name, StageName, (select Id, Opportunity_Stage__c, OpportunityId from OpportunityLineItems) from Opportunity where Id IN :EUAOEOppIds];
         
        //create list to hold opportunity line items that need updating.
        List<OpportunityLineItem> oliUpdateList = new List<OpportunityLineItem>();
         
        //loop through opportunites and update all of the opportunity line items. add line items to update list.
        for(Opportunity o : oliList){
            for(OpportunityLineItem oli : o.OpportunityLineItems){
                oli.Opportunity_Stage__c = o.StageName;
                oliUpdateList.add(oli);
            }
        }
         
        //update the line items
        if(!oliUpdateList.isEmpty()){
            update oliUpdateList;
        }
    }
}

My test class:

@isTest (SeeAllData = true)
private class Test_Opportunity_StageName_Update {
 
    static testMethod void myUnitTest() {
        //create a dummy account
        Account a = new Account(Name='Test Account');
        insert a;
                 
        //Get the Standard PriceBook and make sure it is active
        PriceBook2 pb = [select Id from PriceBook2 where IsStandard=True];
        pb.IsActive=true;
        update pb;
         
        //create two products 
        List<Product2> prodList = new List<Product2>();
        prodList.add(new Product2(Name='Prod1'));
        prodList.add(new Product2(Name='Prod1'));
        insert prodList;
         
        //Create pricebook entries for the products
        List<PricebookEntry> pbEntryList = new List<PricebookEntry>();
        pbEntryList.add(new PricebookEntry(Pricebook2Id=pb.Id, Product2Id=prodList[0].id, UnitPrice=100, IsActive=true));
        pbEntryList.add(new PricebookEntry(Pricebook2Id=pb.Id, Product2Id=prodList[1].id, UnitPrice=200, IsActive=true));
        insert pbEntryList; 
         
        //Get the record type we care about plus 3 other ones.
        List<RecordType> recTypeList = [select Id, Name from RecordType where (Name='EU AOE Opportunity' OR Name='MEX Opportunity' OR Name='NA Opportunity' OR Name='SA Opportunity') AND SobjectType='Opportunity']; 
         
        //Create 200 new opportunities.
        List<Opportunity> newOppList = new List<Opportunity>();
        for(Integer i=0; i<200; i++){
            Opportunity o = new Opportunity(Name='Test Oppty ' + i, AccountId=a.id, StageName='Prospecting', CloseDate=Date.Today()+1, Probability=0.5);
            //We grabbed four record types above, so set 1/4 of opportunities to each record type. 
            o.RecordTypeId=recTypeList[Math.mod(i,4)].Id;
            newOppList.add(o);
        }
                  
        //insert our new opportunties
        insert newOppList;
         
        //Now add both products to all of the opportunities
        List<OpportunityLineItem> oliList = new List<OpportunityLineItem>();
        for(Opportunity o : newOppList){
            oliList.add(new OpportunityLineItem(OpportunityId=o.id, PriceBookEntryId=pbEntryList[0].id,Quantity=1, Opportunity_Stage__c='Prospecting',UnitPrice=100));
            oliList.add(new OpportunityLineItem(OpportunityId=o.id, PriceBookEntryId=pbEntryList[1].id,Quantity=1, Opportunity_Stage__c='Prospecting',UnitPrice=200));
        }
         
        //insert the opportunity line items
        insert oliList;
         
        //Now that everything has been set up, we can begin the actual test
        Test.startTest();
        
        //change the Stage for all 200 opportunities
        for(Opportunity o : newOppList){
             o.StageName = 'Discovery';
        }
         
        //Update the opportuntiies
        update newOppList;

                  
        //get all of the products tied to the opportunites, there should be 400 total
        oliList.clear();
        oliList = [select Id, Opportunity_Stage__c from OpportunityLineItem where OpportunityId IN :newOppList];
        System.assertEquals(400,oliList.size());
         
        //Now check that the number of Opportunity Line items with Stage Name of Discovery is 100
        //since 1 out of 4 the opportunities should have fired product stage updates
        Integer DiscoveryCounter = 0;
        Integer ProspectingCounter = 0;
        for(OpportunityLineItem oli : oliList){
            if(oli.Opportunity_Stage__c == 'Discovery'){
                //increase the count by 1
                DiscoveryCounter++;             
            }
            if(oli.Opportunity_Stage__c == 'Prospecting'){
                ProspectingCounter++;
            }
        }
        
        //make sure the counts are as expected
        System.AssertEquals(100,DiscoveryCounter);
        System.AssertEquals(300,ProspectingCounter);
        Test.stopTest();
        
        
    }
}

The error:

Class: Test_Opportunity_StageName_Update
Method Name: myUnitTest
Pass/Fail: Fail

Error Message	:

System.DmlException: Insert failed. First exception on row 0; first error: CANNOT_INSERT_UPDATE_ACTIVATE_ENTITY, A workflow or approval field update caused an error when saving this record. Contact your administrator to resolve it.
common.exception.SfdcSqlException: ORA-20067: OPPORTUNITY_LINEITEM.QUANTITY
ORA-06512: at "DOPEY.SOPPLINEITEM", line 1242
ORA-06512: at line 1


{call sOppLineItem.update_opplineitems(?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)}

{call sOppLineItem.update_opplineitems(?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)}: []

Stack Trace
Class.Test_Opportunity_StageName_Update.myUnitTest: line 49, column 1

Thanks, Benny