Apex Code Development You need to sign in to do that
Don't have an account?
Gary Payne Apex Trigger to update a lookup field
Ineed help withthe following Apex Trigger:
trigger ForceSourceCrossRef on Lead (before insert, before update ) {
For (Lead l:Trigger.new) {
if(l.Source__c != null) {
List<CrossRef__c> cr = new List<CrossRef__c>();
cr = [Select Id from CrossRef__c WHERE
CrossRef__c.Name = :l.Source__c ORDER BY Id LIMIT 1];
if(cr.size()>0){
cr.Source_Cross_Reference__c = cr[0].Id;
}
}
}
}
Attempting to update a custom lookup field on the Lead object called Source_Cross_Reference__c with the value that's imported in a Lead field called Source__c. (Source__c is a picklist field.) There is a custom object called CrossRef__c that uses the Source__c picklist value in the CrossRef__c.Name field. I want to populate the Source_Cross_Reference__c field with the ID value from the CrossRef__c object. The Devleoper Console is displaying the following Problem: "Initial term of field expression must be a concrete SObject: List<CrossRef__c>".. What is neededto correct this problem? Will this trigger perform the update described earlier?
trigger ForceSourceCrossRef on Lead (before insert, before update ) {
For (Lead l:Trigger.new) {
if(l.Source__c != null) {
List<CrossRef__c> cr = new List<CrossRef__c>();
cr = [Select Id from CrossRef__c WHERE
CrossRef__c.Name = :l.Source__c ORDER BY Id LIMIT 1];
if(cr.size()>0){
cr.Source_Cross_Reference__c = cr[0].Id;
}
}
}
}
Attempting to update a custom lookup field on the Lead object called Source_Cross_Reference__c with the value that's imported in a Lead field called Source__c. (Source__c is a picklist field.) There is a custom object called CrossRef__c that uses the Source__c picklist value in the CrossRef__c.Name field. I want to populate the Source_Cross_Reference__c field with the ID value from the CrossRef__c object. The Devleoper Console is displaying the following Problem: "Initial term of field expression must be a concrete SObject: List<CrossRef__c>".. What is neededto correct this problem? Will this trigger perform the update described earlier?
I think I misunderstood your field and objects. Here you go with new code revision:
trigger ForceSourceCrossRef on Lead (before insert, before update ) { Set<String> sSources = new Set<String>(); for(Lead l : Trigger.new) { if(l.Source__c != null) sSources.add(l.Source__c); } Map<String, CrossRef__c> mCrossRefs = new Map<String, CrossRef__c>(); for(CrossRef__c crInstance : [SELECT Id, Name, Source_Cross_Reference__c FROM CrossRef__c WHERE Name IN :sSources]) { mCrossRefs.put(crInstance.Name, crInstance); } for(Lead l : Trigger.new) { if(l.Source__c != null) { if(mCrossRefs.containsKey(l.Source__c)) { l.Source_Cross_Reference__c = mCrossRefs.get(l.Source__c).Id; } } } }Hope this works as per your expectationsAll Answers
trigger ForceSourceCrossRef on Lead (before insert, before update ) { List<CrossRef__c> lCRs = new List<CrossRef__c>(); Set<String> sSources = new Set<String>(); for(Lead l : Trigger.new) { if(l.Source__c != null) sSources.add(l.Source__c); } Map<String, CrossRef__c> mCrossRefs = new Map<String, CrossRef__c>(); for(CrossRef__c crInstance : [SELECT Id, Name FROM CrossRef__c WHERE Name IN :sSources]) { mCrossRefs.put(crInstance.Name, crInstance); } for(Lead l : Trigger.new) { if(l.Source__c != null) { if(mCrossRefs.containsKey(l.Source__c)) { CrossRef__c crTemp = mCrossRefs.get(l.Source__c); crTemp.Source_Cross_Reference__c = crTemp.Id; lCRs.add(crTemp); } } } if(!lCRs.isEmpty()) update lCRs; }Hope this helps! if yes, then mark it as solution.
Thanks,
Sumit
Will this trigger perform the update described earlier ?
A.You have to update the field on lead object not the CrossRef__c object .This is how you should do .trigger ForceSourceCrossRef on Lead (before insert, before update ) {
For (Lead l:Trigger.new) {
if(l.LeadSource != null) {
List<CrossRef__c> cr = new List<CrossRef__c>();
cr = [Select Id from CrossRef__c WHERE
CrossRef__c.Name = :l.LeadSource ORDER BY Id LIMIT 1];
if(cr.size()>0){
l.Source_Cross_Reference__c = cr[0].Id;
}
}
}
}
This code needs ot be bulkified .
Thanks,
Sailaja
trigger ForceSourceCrossRef on Lead (before insert, before update ) { List<String> crossrefIds = new Set<String>(); Map<String,CrossRef__c> NameToCrossRef = new Map<String,CrossRef__c>(); for (Lead l :trigger.new ) { if(l.Source__c != null) { crossrefIds.add(l.Source__c ); } } for (CrossRef__c cr = [Select Id,Name from CrossRef__c WHERE Name IN :crossrefIds ORDER BY Id]) { NameToCrossRef .put(cr.Name,cr); } for (Lead l :trigger.new ) { if(l.Source__c != null) { CrossRef__c cr = NameToCrossRef .get(l.Source__c ); if(cr != null ) { l.Source_Cross_Reference__c = cr.Id; } } } }I think I misunderstood your field and objects. Here you go with new code revision:
trigger ForceSourceCrossRef on Lead (before insert, before update ) { Set<String> sSources = new Set<String>(); for(Lead l : Trigger.new) { if(l.Source__c != null) sSources.add(l.Source__c); } Map<String, CrossRef__c> mCrossRefs = new Map<String, CrossRef__c>(); for(CrossRef__c crInstance : [SELECT Id, Name, Source_Cross_Reference__c FROM CrossRef__c WHERE Name IN :sSources]) { mCrossRefs.put(crInstance.Name, crInstance); } for(Lead l : Trigger.new) { if(l.Source__c != null) { if(mCrossRefs.containsKey(l.Source__c)) { l.Source_Cross_Reference__c = mCrossRefs.get(l.Source__c).Id; } } } }Hope this works as per your expectationstrigger ForceSourceCrossRef on Lead (before insert, before update ) { List<String> crossrefIds = new Set<String>(); Map<String,CrossRef__c> NameToCrossRef = new Map<String,CrossRef__c>(); for (Lead l :trigger.new ) { if(l.Source__c != null) { crossrefIds.add(l.Source__c ); } } for (CrossRef__c cr : [Select Id,Name from CrossRef__c WHERE Name IN :crossrefIds ORDER BY Id]) { NameToCrossRef .put(cr.Name,cr); } for (Lead l :trigger.new ) { if(l.Source__c != null) { CrossRef__c cr = NameToCrossRef .get(l.Source__c ); if(cr != null ) { l.Source_Cross_Reference__c = cr.Id; } } } }