+ Start a Discussion
Avinash RaviAvinash Ravi 

Need help developing a test class for 100 percent code coverage. Can someone please help?

public with sharing class ThePrayagMarathon {

   public ThePrayagMarathon() {
   
   }
   
   public Registration__c Regs {get;set;}
   
   public PageReference save()
   { 
    
    if(Registration__c.Marathon_Category__c == null || Registration__c.Marathon_Distance__c == null || Registration__c.Name_of_the_Participant__c == null || Registration__c.DOB__c == null || Registration__c.Address_Line_1__c == null || Registration__c.City__c == null || Registration__c.State__c == null || Registration__c.Pin_Code__c == null || Registration__c.Email__c == null || Registration__c.Mobile_Number__c == null ||  Registration__c.Tee_Shirt_Size__c == null)
   {
    
    ApexPages.addMessage(new Apexpages.Message(ApexPages.severity.error,'Please fill all mandatory fields.'));
                return null;
   }
    
        System.debug('Entered into save');
        RecordType regRtype = [SELECT Name,id FROM RecordType WHERE SobjectType='Registration__c' and Name='Marathon' LIMIT 1];
        system.debug('Record type of inserted registration..'+regRtype.id);
        Regs.RecordTypeId = regRtype.id;
        Regs.type__c = 'New Participant'; 
        try {      
        insert regs;
        if(Regs.Marathon_Category__c == 'Rs. 700 /- For Ages Above 12')
        {pagereference Page = new pagereference('https://www.payumoney.com/paybypayumoney/#/37061');
        return Page;}
        else
        {pagereference Page = new pagereference('https://www.payumoney.com/paybypayumoney/#/37063');
        return Page;}
           } 
         catch(DMLException e) {
        return null;
        }      
        }
        
        public PageReference cancel()
        {pagereference Page = new pagereference('http://www.joinprayag.com');
        return Page;}
        
        
        public ThePrayagMarathon(ApexPages.StandardController controller) {
        this.regs = (Registration__c)controller.getRecord();
        system.debug('m here ....'+regs);            
        }

}
Best Answer chosen by Avinash Ravi
Amit Chaudhary 8Amit Chaudhary 8
Please modify your main class like below:-
public with sharing class VolunteerRegistration 
{
    public VolunteerRegistration() {
    }
    public Registrations__c Regs {get;set;}
    
    public PageReference save()
    { 
    
        try { 
        System.debug('Entered into save');
		
        List<RecordType> regRtypeList = [SELECT Name,id FROM RecordType WHERE SobjectType='Registration__c' and Name='Volunteer Registration' LIMIT 1];
        //Regs.RecordTypeId = '012280000000f2q';
            
            insert Regs;
            pagereference Page = new pagereference('http://www.joinprayag.com/thankyou/');
            return page;     
             } 
        catch(DMLException e) {
        return null;
        }      
     }   
     public PageReference cancel()
     {
         System.debug('Entered into cancel');
         
             pagereference Page = new pagereference('http://www.joinprayag.com');
             return Page;
     }
     
     public VolunteerRegistration(ApexPages.StandardController controller) 
     {
        regs = (Registrations__c)controller.getRecord();
        system.debug('This is ....'+regs);          
     }   
}

Then try below test class
@isTest
public class VolunteerRegistration_Test{
	public static testmethod void VolunteerRegistration_Test()
	{
		Test.StartTest();
		RecordType regRtype = [SELECT Name,id FROM RecordType WHERE SobjectType='Registrations__c' and Name='Volunteer Registration' LIMIT 1];
		//List<Registrations__c> regList = new List<Registrations__c> ();

			Registrations__c regTemp = new Registrations__c();
			regTemp.Full_Name__c = 'Full Name';
			regTemp.Gender__c = 'Male';
			regTemp.Date_of_Birth__c = Date.today();
			regTemp.Email__c = 'avinash@joinprayag.com';
			regTemp.Phone__c = '9176473115';
			regTemp.Address_Line_1__c = 'TCS ChennaiOne';
			regTemp.Address_Line_2__c = 'Thoraipakkam';
			regTemp.City__c = 'Chennai';
			regTemp.State__c = 'Tamil Nadu';
			regTemp.Pin_Code__c = '600061';
			regTemp.Current_Occupation__c = 'Student';
			regTemp.Place_of_Occupation__c = 'SSEC';
			regTemp.Interested_in__c = 'Analytics';
			regTemp.Skills_that_could_be_of_use__c = 'Nothing';
			regTemp.Why_Prayag__c = 'Prayag';
			regTemp.How_did_you_get_to_know_about_us__c = 'Google';
			
			VolunteerRegistration contrl = new VolunteerRegistration();
			contrl.Regs = regTemp;
			contrl.save();
			contrl.cancel();
		Test.StopTest();
	}
	// You can remove below method. Only above method will work for you
	public static testmethod void VolunteerRegistration_Test2()
	{
		Registrations__c regTemp2 = new Registrations__c ();
		regTemp2.Full_Name__c = 'Full Name1';
		regTemp2.Gender__c = 'Female';
		regTemp2.Date_of_Birth__c = Date.today();
		regTemp2.Email__c = 'prayag@joinprayag.com';
		regTemp2.Phone__c = '9176473116';
		regTemp2.Address_Line_1__c = 'TCS Chennai1';
		regTemp2.Address_Line_2__c = 'Thoraipakkam';
		regTemp2.City__c = 'Chennai';
		regTemp2.State__c = 'Tamil Nadu';
		regTemp2.Pin_Code__c = '600061';
		regTemp2.Current_Occupation__c = 'Employed';
		regTemp2.Place_of_Occupation__c = 'TCS';
		regTemp2.Interested_in__c = 'Analytics';
		regTemp2.Skills_that_could_be_of_use__c = 'Nothing';
		regTemp2.Why_Prayag__c = 'Prayag';
		regTemp2.How_did_you_get_to_know_about_us__c = 'Google';
		//insert regTemp2;
		
		Test.StartTest();

			ApexPages.StandardController sc = new ApexPages.StandardController(regTemp2);
			VolunteerRegistration  ControllerObj = new VolunteerRegistration(sc);
			ControllerObj.save();
			ControllerObj.cancel(); 
		Test.StopTest();
	}
}

Please let us know if this will help you

 

All Answers

Amit Chaudhary 8Amit Chaudhary 8
Please try below test class. I hope that will help you:-

NOTE:- Please add valid data in all below field according to field data type
@isTest 
public class ThePrayagMarathonTest 
{
	static testMethod void testMethod1() 
	{
		Test.StartTest(); 
			ThePrayagMarathon contrl = new ThePrayagMarathon();
            //Please add valid data in all below field according to field data type
			contrl.Regs.Marathon_Category__c =''Rs. 700 /- For Ages Above 12';
			contrl.Regs.Marathon_Distance__c = 22;
			contrl.Regs.Name_of_the_Participant__c = '33';
			contrl.Regs.DOB__c = System.today();
			contrl.Regs.Address_Line_1__c = '33';
			contrl.Regs.City__c = '33';
			contrl.Regs.State__c = '33';
			contrl.Regs.Pin_Code__c = 2343;
			contrl.Regs.Email__c = 'test@mail.com';
			contrl.Regs.Mobile_Number__c = 23333;
			contrl.Regs.Tee_Shirt_Size__c = 23;
			contrl.save();
			contrl.cancel();
		
		Test.StopTest();
	}

	static testMethod void testMethod2() 
	{
		Registration__c Regs = new Registration__c();

          //Please add valid data in all below field according to field data type

			Regs.Marathon_Category__c =''Rs. 701 /- For Ages Above 12';
			Regs.Marathon_Distance__c = 22;
			Regs.Name_of_the_Participant__c = '33';
			Regs.DOB__c = System.today();
			Regs.Address_Line_1__c = '33';
			Regs.City__c = '33';
			Regs.State__c = '33';
			Regs.Pin_Code__c = 2343;
			Regs.Email__c = 'test@mail.com';
			Regs.Mobile_Number__c = 23333;
			Regs.Tee_Shirt_Size__c = 23;
		insert Regs;

		Test.StartTest(); 
			ApexPages.StandardController sc = new ApexPages.StandardController(Regs);
			ThePrayagMarathon contrl = new ThePrayagMarathon(sc);
			contrl.save();
			contrl.cancel();
		Test.StopTest();
	}
 
}

you can learn more about test classes in below blog:-
http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html

Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required 
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please mark this as Best Answer if this will help you. SO that if some one has same issue this post can help others.

Thanks,
Amit Chaudhary
 
Avinash RaviAvinash Ravi
Hi Amit,

Thanks a lot for your response.

But I get an error at line 20,21 .. 48 and 49 stating invalid method save(/cancel) on object Registrations__c ()
Avinash RaviAvinash Ravi
The exact error is
Error: Compile Error: Method does not exist or incorrect signature: [Registrations__c].save() 

and even if I comment out line 20,21, the class saves fine but fails when run in the developer console..

no rows for assignment to Sobject at line 48.

Please help out.
Avinash RaviAvinash Ravi
Hi Amit,

Kindly excuse me if I had made a blunder I'm new to this area and I'm not sure of much of the code. Please help out.

The requirements have changed a bit so I've modified them to fit the new :
This is the main class :
 
public with sharing class VolunteerRegistration {
    public VolunteerRegistration() {
    }
    public Registrations__c Regs {get;set;}
    
    public PageReference save()
    { 
    
        try { 
        System.debug('Entered into save');
        RecordType regRtype = [SELECT Name,id FROM RecordType WHERE SobjectType='Registration__c' and Name='Volunteer Registration' LIMIT 1];
        system.debug('Record type of inserted registration is '+regRtype.id);
        //Regs.RecordTypeId = '012280000000f2q';
            
            insert Regs;
            pagereference Page = new pagereference('http://www.joinprayag.com/thankyou/');
            return page;     
             } 
        catch(DMLException e) {
        return null;
        }      
     }   
     public PageReference cancel()
     {
         System.debug('Entered into cancel');
         
             pagereference Page = new pagereference('http://www.joinprayag.com');
             return Page;
     }
     
     public VolunteerRegistration(ApexPages.StandardController controller) 
     {
        regs = (Registrations__c)controller.getRecord();
        system.debug('This is ....'+regs);          
     }   
}





This is the test class :
 
@isTest
public class VolunteerRegistration_Test{
public static testmethod void VolunteerRegistration_Test()

{
Test.StartTest();

RecordType regRtype = [SELECT Name,id FROM RecordType WHERE SobjectType='Registrations__c' and Name='Volunteer Registration' LIMIT 1];
//List<Registrations__c> regList = new List<Registrations__c> ();
Registrations__c regTemp = new Registrations__c();

regTemp.Full_Name__c = 'Full Name';
regTemp.Gender__c = 'Male';
regTemp.Date_of_Birth__c = Date.today();
regTemp.Email__c = 'avinash@joinprayag.com';
regTemp.Phone__c = '9176473115';
regTemp.Address_Line_1__c = 'TCS ChennaiOne';
regTemp.Address_Line_2__c = 'Thoraipakkam';
regTemp.City__c = 'Chennai';
regTemp.State__c = 'Tamil Nadu';
regTemp.Pin_Code__c = '600061';
regTemp.Current_Occupation__c = 'Student';
regTemp.Place_of_Occupation__c = 'SSEC';
regTemp.Interested_in__c = 'Analytics';
regTemp.Skills_that_could_be_of_use__c = 'Nothing';
regTemp.Why_Prayag__c = 'Prayag';
regTemp.How_did_you_get_to_know_about_us__c = 'Google';
insert regTemp; //added because the next two statements threw an error.
//regtemp.save();
//regtemp.cancel();
Test.StopTest();

}
//regList.add(regTemp);
//


public static testmethod void VolunteerRegistration_Test2()
{


Registrations__c regTemp2 = new Registrations__c ();

regTemp2.Full_Name__c = 'Full Name1';
regTemp2.Gender__c = 'Female';
regTemp2.Date_of_Birth__c = Date.today();
regTemp2.Email__c = 'prayag@joinprayag.com';
regTemp2.Phone__c = '9176473116';
regTemp2.Address_Line_1__c = 'TCS Chennai1';
regTemp2.Address_Line_2__c = 'Thoraipakkam';
regTemp2.City__c = 'Chennai';
regTemp2.State__c = 'Tamil Nadu';
regTemp2.Pin_Code__c = '600061';
regTemp2.Current_Occupation__c = 'Employed';
regTemp2.Place_of_Occupation__c = 'TCS';
regTemp2.Interested_in__c = 'Analytics';
regTemp2.Skills_that_could_be_of_use__c = 'Nothing';
regTemp2.Why_Prayag__c = 'Prayag';
regTemp2.How_did_you_get_to_know_about_us__c = 'Google';

insert regTemp2;
//regList.add(regTemp2);

Test.StartTest();
ApexPages.StandardController sc = new ApexPages.StandardController(regTemp2);
VolunteerRegistration regTemp = new VolunteerRegistration(sc);
regtemp.save();
regtemp.cancel(); // these two statements don't throw an error while saving.. but when I run the class on the //developer console they return a 'no rows to assign' error like I had mentioned earlier.
Test.StopTest();

}
}

Thanks,
Avinash
Amit Chaudhary 8Amit Chaudhary 8
Please modify your main class like below:-
public with sharing class VolunteerRegistration 
{
    public VolunteerRegistration() {
    }
    public Registrations__c Regs {get;set;}
    
    public PageReference save()
    { 
    
        try { 
        System.debug('Entered into save');
		
        List<RecordType> regRtypeList = [SELECT Name,id FROM RecordType WHERE SobjectType='Registration__c' and Name='Volunteer Registration' LIMIT 1];
        //Regs.RecordTypeId = '012280000000f2q';
            
            insert Regs;
            pagereference Page = new pagereference('http://www.joinprayag.com/thankyou/');
            return page;     
             } 
        catch(DMLException e) {
        return null;
        }      
     }   
     public PageReference cancel()
     {
         System.debug('Entered into cancel');
         
             pagereference Page = new pagereference('http://www.joinprayag.com');
             return Page;
     }
     
     public VolunteerRegistration(ApexPages.StandardController controller) 
     {
        regs = (Registrations__c)controller.getRecord();
        system.debug('This is ....'+regs);          
     }   
}

Then try below test class
@isTest
public class VolunteerRegistration_Test{
	public static testmethod void VolunteerRegistration_Test()
	{
		Test.StartTest();
		RecordType regRtype = [SELECT Name,id FROM RecordType WHERE SobjectType='Registrations__c' and Name='Volunteer Registration' LIMIT 1];
		//List<Registrations__c> regList = new List<Registrations__c> ();

			Registrations__c regTemp = new Registrations__c();
			regTemp.Full_Name__c = 'Full Name';
			regTemp.Gender__c = 'Male';
			regTemp.Date_of_Birth__c = Date.today();
			regTemp.Email__c = 'avinash@joinprayag.com';
			regTemp.Phone__c = '9176473115';
			regTemp.Address_Line_1__c = 'TCS ChennaiOne';
			regTemp.Address_Line_2__c = 'Thoraipakkam';
			regTemp.City__c = 'Chennai';
			regTemp.State__c = 'Tamil Nadu';
			regTemp.Pin_Code__c = '600061';
			regTemp.Current_Occupation__c = 'Student';
			regTemp.Place_of_Occupation__c = 'SSEC';
			regTemp.Interested_in__c = 'Analytics';
			regTemp.Skills_that_could_be_of_use__c = 'Nothing';
			regTemp.Why_Prayag__c = 'Prayag';
			regTemp.How_did_you_get_to_know_about_us__c = 'Google';
			
			VolunteerRegistration contrl = new VolunteerRegistration();
			contrl.Regs = regTemp;
			contrl.save();
			contrl.cancel();
		Test.StopTest();
	}
	// You can remove below method. Only above method will work for you
	public static testmethod void VolunteerRegistration_Test2()
	{
		Registrations__c regTemp2 = new Registrations__c ();
		regTemp2.Full_Name__c = 'Full Name1';
		regTemp2.Gender__c = 'Female';
		regTemp2.Date_of_Birth__c = Date.today();
		regTemp2.Email__c = 'prayag@joinprayag.com';
		regTemp2.Phone__c = '9176473116';
		regTemp2.Address_Line_1__c = 'TCS Chennai1';
		regTemp2.Address_Line_2__c = 'Thoraipakkam';
		regTemp2.City__c = 'Chennai';
		regTemp2.State__c = 'Tamil Nadu';
		regTemp2.Pin_Code__c = '600061';
		regTemp2.Current_Occupation__c = 'Employed';
		regTemp2.Place_of_Occupation__c = 'TCS';
		regTemp2.Interested_in__c = 'Analytics';
		regTemp2.Skills_that_could_be_of_use__c = 'Nothing';
		regTemp2.Why_Prayag__c = 'Prayag';
		regTemp2.How_did_you_get_to_know_about_us__c = 'Google';
		//insert regTemp2;
		
		Test.StartTest();

			ApexPages.StandardController sc = new ApexPages.StandardController(regTemp2);
			VolunteerRegistration  ControllerObj = new VolunteerRegistration(sc);
			ControllerObj.save();
			ControllerObj.cancel(); 
		Test.StopTest();
	}
}

Please let us know if this will help you

 
This was selected as the best answer
Avinash RaviAvinash Ravi
Thanks a lot Amit. That worked. Awesome stuff.

Much Obliged!