+ Start a Discussion
Ashok S 7Ashok S 7 

how can i cover integer id in the test class

hai guys.
In my controller i used integer data type for id. but in the test take the id as string and assign to the integer id .It displaying theIllegal assignment from String to Integer  how can slove it
here my controller 
-----------------------------------------
public class fetchingController {

    public list<Book__c>  bookList {get;set;}
    public Integer id{get;set;}
    public Integer uid{get;set;}

    public fetchingController(){
           bookList = [Select Id ,Name , author__c , title__c , price__c from Book__c];

    }

// Method to delete Record  
        public PageReference deleteBook() {
                String bookId = ApexPages.currentPage().getParameters().get('id');
                System.debug('book lsit id is--------------------- '+bookId);
                if (bookId!=''){
                 Book__c book = [Select id from Book__c where id=:bookId ];
                  delete book ;
                }
        return null;
   }

   // Method to update Book Record 

   public PageReference updateBook() {
        String bookUid = ApexPages.currentPage().getParameters().get('uid');
        System.debug('The id for update is ------------------'+bookUid);
        if (bookUid!=''){
        Book__c book =[select Id  from Book__c where id = : bookUid];
            book.Author__c = 'Naveen';
        update book;
        }
        return null;
   }

}
testclass
--------------------------------------
@isTest
public class fetchingController_Test
{
     public static testmethod void fetch()
     {
         test.startTest();
         //inserting values to the book object
         Book__c b = new Book__c();
         b.Author__c = 'Mc growth ';
         b.Discount__c = 15;
         b.Price__c = 2500;
         b.Title__c = 'Advanced Java';
         insert b;
 
 
         //including pagereference in the test class
         pagereference pg = page.Example1_Vf_Page;
         pg.getparameters().put('id',string.valueOf(b.id));
         test.setcurrentpage(pg);


         //include the class name
         
         //string s = ApexPages.currentPage().getParameters().put('id',b.id);
         //system.debug('the value of ss='+s);
         
         //string s1 = ApexPages.currentPage().getParameters().put('id',b.id);
         //system.debug('the value of s1='+s1);
         
         fetchingController fc= new fetchingController();
         //calling the variables
         fc.id = ApexPages.currentPage().getParameters().get(b.id);
         fc.uid = ApexPages.currentPage().getParameters().get(b.id);
         
         //calling the methods
         fc.updateBook();
         fc.deleteBook();

         test.stopTest();
    }
}
 
Best Answer chosen by Ashok S 7
Amit Chaudhary 8Amit Chaudhary 8
Please try below code. I hope that will help you:-
@isTest
public class fetchingController_Test
{
     public static testmethod void fetch()
     {
         test.startTest();
		 
         //inserting values to the book object
         Book__c b = new Book__c();
         b.Author__c = 'Mc growth ';
         b.Discount__c = 15;
         b.Price__c = 2500;
         b.Title__c = 'Advanced Java';
         insert b;
 
         //including pagereference in the test class
         pagereference pg = page.Example1_Vf_Page;
         pg.getparameters().put('id',string.valueOf(b.id));
         pg.getparameters().put('uid',string.valueOf(b.id));
         test.setcurrentpage(pg);
         
         fetchingController fc= new fetchingController();
         fc.updateBook();
         fc.deleteBook();

         test.stopTest();
    }
}

Please check below blog for more information on test classes
http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html

Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required 
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

Thanks,
Amit Chaudhary

All Answers

Vivek DeshmaneVivek Deshmane
Hi,
You need to change data type from Integer to String because record ID is alphanumeric.
 public String id{get;set;}
    public String uid{get;set;}
Let me know if it helps you.

Best Regards,
-Vivek
Amit Chaudhary 8Amit Chaudhary 8
Please try below code. I hope that will help you:-
@isTest
public class fetchingController_Test
{
     public static testmethod void fetch()
     {
         test.startTest();
		 
         //inserting values to the book object
         Book__c b = new Book__c();
         b.Author__c = 'Mc growth ';
         b.Discount__c = 15;
         b.Price__c = 2500;
         b.Title__c = 'Advanced Java';
         insert b;
 
         //including pagereference in the test class
         pagereference pg = page.Example1_Vf_Page;
         pg.getparameters().put('id',string.valueOf(b.id));
         pg.getparameters().put('uid',string.valueOf(b.id));
         test.setcurrentpage(pg);
         
         fetchingController fc= new fetchingController();
         fc.updateBook();
         fc.deleteBook();

         test.stopTest();
    }
}

Please check below blog for more information on test classes
http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html

Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required 
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

Thanks,
Amit Chaudhary
This was selected as the best answer
Ashok S 7Ashok S 7
but i can not these two lines
 public Integer id{get;set;}
    public Integer uid{get;set;}
please help me
Amit Chaudhary 8Amit Chaudhary 8
Below line are not is use in your main class. You can delete below code:-

 public Integer id{get;set;}
 public Integer uid{get;set;}

I hope this will help you. Please try below code in main class:-
public class fetchingController {
    public list<Book__c>  bookList {get;set;}
    public fetchingController()
	{
           bookList = [Select Id ,Name , author__c , title__c , price__c from Book__c];
    }

// Method to delete Record  
        public PageReference deleteBook() {
                String bookId = ApexPages.currentPage().getParameters().get('id');
                System.debug('book lsit id is--------------------- '+bookId);
                if (bookId!=''){
                 Book__c book = [Select id from Book__c where id=:bookId ];
                  delete book ;
                }
        return null;
   }
   // Method to update Book Record 
   public PageReference updateBook() 
   {
        String bookUid = ApexPages.currentPage().getParameters().get('uid');
        System.debug('The id for update is ------------------'+bookUid);
        if (bookUid!=''){
        Book__c book =[select Id  from Book__c where id = : bookUid];
            book.Author__c = 'Naveen';
        update book;
        }
        return null;
   }
}