+ Start a Discussion
Shannon Andreas 1Shannon Andreas 1 

Trigger/Test Class Help

Can someone help me with this trigger/test class. I am trying to create a contract when the status of a DocuSign = Completed.

trigger CreateContractDocSignComp on dsfs__DocuSign_Status__c (after insert)
{
    List<Contract> ctr = new List<Contract>();
    
      for(dsfs__DocuSign_Status__c dsfs : Trigger.new)
      {
        if(dsfs.dsfs__Envelope_Status__c == 'Completed')
        {
             Contract c = new Contract(Name = dsfs.Name,
             Status = 'Draft',
             Total_Contract_Value__c =dsfs.Total_Contract_Value__c,
             StartDate = dsfs.Contract_Start_Date__c,
             Payment_Status__c = 'Ready to be Invoiced',
             AccountId = dsfs.dsfs__Company__c,
             Opportunity_Name__c = dsfs.dsfs__Opportunity__c);
             ctr.add(c);
         }
      }
      if(ctr.size() > 0)
      {
            System.debug('-ctr------->'+ctr.size());
            insert ctr;
      }     
}



@isTest
private class TestCreateContractDocSignCompTrigger 
{
    static testMethod void validateCreateContractDocuSignComp() 
    {   
       Account a = new Account(
       Name = 'Test Account');
    insert a;

       Opportunity o = new Opportunity(
       Name = 'Test Opp',
       Ready_for_Contract__c = true,
       CloseDate = System.Today(),
       AccountId = a.Id,
       StageName = 'Signed / Closed Sale',
       Amount = decimal.valueof('6995'));
    insert o;
    
       dsfs__DocuSign_Status__c  dsfs = new dsfs__DocuSign_Status__c(
       dsfs__Company__c = o.AccountId,
       dsfs__Opportunity__c = o.Name,
       dsfs__Envelope_Status__c = 'Completed',
       dsfs__DocuSign_Envelope_ID__c = '1001A123-1234-5678-1D84-F8D44652A382',
       dsfs__Subject__c = 'Document for eSignature');
    insert dsfs;
 Test.StartTest();
       
            
            List<Contract> lstContr = [select id from contract where Opportunity_Name__c =:o.id];
                 //System.assertNotEquals(1stContr,null);
                 
        Test.StopTest();
       
      }
}

Thanks!

Shannon
Best Answer chosen by Shannon Andreas 1
Amit Chaudhary 8Amit Chaudhary 8
Please try below test class. I  hope that will help you.
@isTest
private class TestCreateContractDocSignCompTrigger 
{
    static testMethod void validateCreateContractDocuSignComp() 
    {   
		Account a = new Account(		Name = 'Test Account');
		insert a;

		Opportunity o = new Opportunity(
		Name = 'Test Opp',
		Ready_for_Contract__c = true,
		CloseDate = System.Today(),
		AccountId = a.Id,
		StageName = 'Signed / Closed Sale',
		Amount = decimal.valueof('6995'));
		insert o;
    
		
		Test.StartTest();
		   dsfs__DocuSign_Status__c  dsfs = new dsfs__DocuSign_Status__c();
		   dsfs.dsfs__Company__c = o.AccountId;
		   dsfs.dsfs__Opportunity__c = o.id;
		   dsfs.dsfs__Envelope_Status__c = 'Completed';
		   dsfs.dsfs__DocuSign_Envelope_ID__c = '1001A123-1234-5678-1D84-F8D44652A382';
		   dsfs.dsfs__Subject__c = 'Document for eSignature';
		   insert dsfs;
       
            
            List<Contract> lstContr = [select id from contract where dsfs__Opportunity__c =:o.id];
            //System.assertNotEquals(1stContr,null);
        Test.StopTest();
       
	}
}
Please check below blog for test classes.
http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html

Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

Thanks
Amit Chaudhary

All Answers

Amit Chaudhary 8Amit Chaudhary 8
Please try below test class. I  hope that will help you.
@isTest
private class TestCreateContractDocSignCompTrigger 
{
    static testMethod void validateCreateContractDocuSignComp() 
    {   
		Account a = new Account(		Name = 'Test Account');
		insert a;

		Opportunity o = new Opportunity(
		Name = 'Test Opp',
		Ready_for_Contract__c = true,
		CloseDate = System.Today(),
		AccountId = a.Id,
		StageName = 'Signed / Closed Sale',
		Amount = decimal.valueof('6995'));
		insert o;
    
		
		Test.StartTest();
		   dsfs__DocuSign_Status__c  dsfs = new dsfs__DocuSign_Status__c();
		   dsfs.dsfs__Company__c = o.AccountId;
		   dsfs.dsfs__Opportunity__c = o.id;
		   dsfs.dsfs__Envelope_Status__c = 'Completed';
		   dsfs.dsfs__DocuSign_Envelope_ID__c = '1001A123-1234-5678-1D84-F8D44652A382';
		   dsfs.dsfs__Subject__c = 'Document for eSignature';
		   insert dsfs;
       
            
            List<Contract> lstContr = [select id from contract where dsfs__Opportunity__c =:o.id];
            //System.assertNotEquals(1stContr,null);
        Test.StopTest();
       
	}
}
Please check below blog for test classes.
http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html

Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

Thanks
Amit Chaudhary
This was selected as the best answer
Priyanka SPriyanka S
Hi Shannon,

Just insert the test record for the dsfs__DocuSign_Status__c object with dsfs__Envelope_Status__c as Completed. Then the contract will be inserted automatically as per your trigger logic.

Total_Contract_Value__c and Contract_Start_Date__c values are null in your test record of dsfs__DocuSign_Status__c object. Add those field values in the test record of dsfs__DocuSign_Status__c object and run the test class. 

Let me know if you have any questions. 
shashi lad 4shashi lad 4
is dsfs__Opportunity__c = o.Name, should be o.Id ???

thanks
shashi
Priyanka SPriyanka S
If dsfs__Opportunity__c field is a look up field to opportunity then you need to assign the opportunity Id (o.Id) to it.
Shannon Andreas 1Shannon Andreas 1
Amit,

I implemented your code and it passes. However, coverage on the trigger is still at 0 after running test.

Priyanka,

dsfs.Total_Contract_Value__c and dsfs.Contract_Start_Date__c are both formula fields and coming up as "unwriteable:.

Any suggestions on coverage?

Thanks!
Priyanka SPriyanka S
Hi Shanon,

Is the field dsfs__Opportunity__c is a look up field to opportunity .If so please assign opportunity Id(o.Id) to it instead of name.
Also you set the value to the field dsfs__DocuSign_Envelope_ID__c as '1001A123-1234-5678-1D84-F8D44652A382'. Is that a standard value. Please put a debug statement as below after inserting dsfs__DocuSign_Status__c record.

System.debug('Docusign Status' + dsfs); // Here you can see the inserted record values in debug log to make sure the values are triggered.

what is the code covrage of the trigger? Make sure that the lines are covered whenever you run the test class. Let me know if you still got any issues.

 
Shannon Andreas 1Shannon Andreas 1
Amit and Priyanka,

Thanks for the help! It was my error, I did not activated the Trigger :/

Shannon