+ Start a Discussion
sfdotcomsfdotcom 

Test class for After Insert & After Update trigger

Hi,
I need help on writing test class for below trigger. I have wrote test class but not any coverage.
Trigger:
trigger sampleTrigger on Object1__c (After Update) {

 if((trigger.IsAfter) && (trigger.Isupdate))
  {
   list<Object1__c> object1List = trigger.new;
 
   list<Object2__c> object2List = new  list<Object2__c > ();
   list<Object2__c> oldObject2List =[select id,name,Marks__c from Object2__c where Object1__c=:trigger.new];
  
   for(Object1__c obj1: trigger.new)
   {
      for(Object2__c obj2:oldObject2List)
      {
    
       obj2.Marks__c=obj1.Marks__c;
          object2List.add(obj2);
      }   
   }
   
    Update object2List;
  
   }

}

______________
Test class:

@isTest
public class sampleTrigger_Test {
    public static testMethod void testUpdate(){
       
        Account acc = new Account(Name = 'Test');
        insert acc;
        Contact con  =new Contact( LastName = 'Test',  AccountId = acc.Id);
        insert Con;
        Order__c ord = new Order__c(Account__c = acc.Id, Contact__c = con.Id);
        insert ord;       
        Object1__c obj1 = new Object1__c(Marks__c = 10.00);
        insert tp;
       
        Object2__c obj2 = new Object2__c ( Name = 'Test',
                                                             Marks__c = 12.12,
                                                            Account__c = acc.Id,
                                                            Object1__c = obj1.Id); // Here object1 has relationship with obj2
        insert obj2;
        obj2.Marks__c = obj1.Marks__c;
        update obj2;
        }
}

Thanks in advance..
Best Answer chosen by sfdotcom
Fahad-AkhtarFahad-Akhtar
Hi sfdotcom,
There are things which can be done in a diffrent way but just to keep it to your question, you are updating "update obj2;" your object2 which is child of object1 but your trigger is on Object1__c update so if you change your class to update object1 at the end, it should work
 
@isTest
public class sampleTrigger_Test {
    public static testMethod void testUpdate(){
       
        Account acc = new Account(Name = 'Test');
        insert acc;
        Contact con  =new Contact( LastName = 'Test',  AccountId = acc.Id);
        insert Con;
        Order__c ord = new Order__c(Account__c = acc.Id, Contact__c = con.Id);
        insert ord;       
        Object1__c obj1 = new Object1__c(Marks__c = 10.00);
        insert tp;
       
        Object2__c obj2 = new Object2__c ( Name = 'Test',
                                                             Marks__c = 12.12,
                                                            Account__c = acc.Id,
                                                            Object1__c = obj1.Id); // Here object1 has relationship with obj2
        insert obj2;
        obj1.Marks__c = obj2.Marks__c;
        update obj1;
        }
}

Thanks,
Fahad Akhtar

All Answers

Fahad-AkhtarFahad-Akhtar
Hi sfdotcom,
There are things which can be done in a diffrent way but just to keep it to your question, you are updating "update obj2;" your object2 which is child of object1 but your trigger is on Object1__c update so if you change your class to update object1 at the end, it should work
 
@isTest
public class sampleTrigger_Test {
    public static testMethod void testUpdate(){
       
        Account acc = new Account(Name = 'Test');
        insert acc;
        Contact con  =new Contact( LastName = 'Test',  AccountId = acc.Id);
        insert Con;
        Order__c ord = new Order__c(Account__c = acc.Id, Contact__c = con.Id);
        insert ord;       
        Object1__c obj1 = new Object1__c(Marks__c = 10.00);
        insert tp;
       
        Object2__c obj2 = new Object2__c ( Name = 'Test',
                                                             Marks__c = 12.12,
                                                            Account__c = acc.Id,
                                                            Object1__c = obj1.Id); // Here object1 has relationship with obj2
        insert obj2;
        obj1.Marks__c = obj2.Marks__c;
        update obj1;
        }
}

Thanks,
Fahad Akhtar
This was selected as the best answer
sfdotcomsfdotcom
Hi Fahad,
Here Object1__c object has two lookup fields. One is with Account and another is with Object2__c.
Object1__c fields:
1. Account__c (Lookup to Account)
2. Object2__c (Lookup to Object2__c)
Fahad-AkhtarFahad-Akhtar
Hi sfdotcom,
This shouldn't matter as long as we insert and update Object1__c, in your previous code your trigger is on "Object1__c" update but in your test class you are not updating "obj1" and i just noticed that on line # 12 ":insert tp;" I am not sure what tp is, below is fixed code, try this one
 
@isTest
public class sampleTrigger_Test {
    public static testMethod void testUpdate(){
       
        Account acc = new Account(Name = 'Test');
        insert acc;

        Object1__c obj1 = new Object1__c(Marks__c = 10.00);
        insert obj1;
       
        Object2__c obj2 = new Object2__c ( Name = 'Test',
                                                             Marks__c = 12.12,
                                                            Account__c = acc.Id,
                                                            Object1__c = obj1.Id); // Here object1 has relationship with obj2
        insert obj2;
        obj1.Marks__c = obj2.Marks__c;
        update obj1;
        }
}

There was no need to create contact and order so i removed that code.

Thanks,
Fahad Akhtar
 
Amit Chaudhary 8Amit Chaudhary 8
Please check below blog . I hope that will help you for test classes.
http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html

Please Try below code i Hope that will help u
@isTest
public class sampleTrigger_Test {
    public static testMethod void testUpdate(){
       
        Account acc = new Account(Name = 'Test');
        insert acc;
        Contact con  =new Contact( LastName = 'Test',  AccountId = acc.Id);
        insert Con;
        Order__c ord = new Order__c(Account__c = acc.Id, Contact__c = con.Id);
        insert ord;       
        Object1__c obj1 = new Object1__c(Marks__c = 10.00);
        insert obj1;
       
        Object2__c obj2 = new Object2__c ( Name = 'Test',
                                                             Marks__c = 12.12,
                                                            Account__c = acc.Id,
                                                            Object1__c = obj1.Id); // Here object1 has relationship with obj2
        insert obj2;
		
		obj1.Marks__c =11;
		update obj1;
		
        }
}
Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

Thanks
Amit Chaudhary
 
sfdotcomsfdotcom
Hi Fahad,

Thank You So much. Now i got 100% coverage. As per ur suggestion i have changed staement from  obj2.Marks__c = obj1.Marks__c; to obj1.Marks__c = obj2.Marks__c; 
       
sfdotcomsfdotcom
Thank You Amit
Fahad-AkhtarFahad-Akhtar
Hi sfdotcom,
Please mark one best answer, if this has solved your problem.

Thanks,
Fahad Akhtar