function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
sudhirn@merunetworks.comsudhirn@merunetworks.com 

Test Class Suggestion

Hi, 

I want to write a test class for trigger below below trigger will fire only when opportunity is approved
 
trigger Account_Type_Update on Opportunity (After Update) 
{
    public List<Account> accountsToUpdate = new List<Account>(); 

    for(Opportunity opp : Trigger.New)
    {
        if  ( opp.Is_Approved__c)
        {
            Account acct = new Account(Id = opp.AccountId, Type = 'Client');
            accountsToUpdate.add(acct);
        }
    }

        update accountsToUpdate;
}

I wrote a test class no luck i dont see code coverage is getting improved at all Please suggest me how to make changes. 
 
@isTest
public class   Test_Account_Type_Update {


   static testMethod void testShare() {
   
   List<Account> accs = new List<Account>();
   
   test.startTest();

    Account testAcct = new Account (Name = 'Sudhir Account');
    insert testAcct;
    
      // Creates first opportunity
    Opportunity oppt = new Opportunity(
                            RecordTypeID = '012250000008i5uAAA', 
                            Name ='New mAWS Deal',
                            AccountID = testAcct.ID,
                            StageName = 'Account Opened',
                            Amount = 3000,
                            CloseDate = System.today(),
                            CurrencyIsoCode = 'USD'
                            
                            );

   insert oppt;
    
    
    accs = [SELECT Id,Type FROM Account WHERE ID = :testAcct.ID];
   
   
    for (Account a : accs) {
      a.Type = 'Client';
    }
    update accs;

       
   Test.stopTest();
   
   } 
 

}

Thanks
Sudhir
 
Best Answer chosen by sudhirn@merunetworks.com
RAM AnisettiRAM Anisetti
hi,
modify ur code like this...
 
@isTest
public class   Test_Account_Type_Update {


   static testMethod void testShare() {
   
   List<Account> accs = new List<Account>();
   
   test.startTest();

    Account testAcct = new Account (Name = 'Sudhir Account');
    insert testAcct;
    
      // Creates first opportunity
    Opportunity oppt = new Opportunity(
                            RecordTypeID = '012250000008i5uAAA', 
                            Name ='New mAWS Deal',
                            AccountID = testAcct.ID,
                            StageName = 'Account Opened',
                            Amount = 3000,
                            CloseDate = System.today(),
                            CurrencyIsoCode = 'USD'
                            
                            );

   insert oppt;
    
  oppt.Is_Approved__c=true;
    
 update oppt;

       
   Test.stopTest();
   
   } 
 

}

 

All Answers

RAM AnisettiRAM Anisetti
hi,
modify ur code like this...
 
@isTest
public class   Test_Account_Type_Update {


   static testMethod void testShare() {
   
   List<Account> accs = new List<Account>();
   
   test.startTest();

    Account testAcct = new Account (Name = 'Sudhir Account');
    insert testAcct;
    
      // Creates first opportunity
    Opportunity oppt = new Opportunity(
                            RecordTypeID = '012250000008i5uAAA', 
                            Name ='New mAWS Deal',
                            AccountID = testAcct.ID,
                            StageName = 'Account Opened',
                            Amount = 3000,
                            CloseDate = System.today(),
                            CurrencyIsoCode = 'USD'
                            
                            );

   insert oppt;
    
  oppt.Is_Approved__c=true;
    
 update oppt;

       
   Test.stopTest();
   
   } 
 

}

 
This was selected as the best answer
Amit Chaudhary 8Amit Chaudhary 8
Please try below code. I hope that will help you
Never user hard code ID in Test class that will fail once you will deploy your code in production.
Please add valid record type name in below query.
 
@isTest
public class   Test_Account_Type_Update {
  static testMethod void testShare() 
  {
    Account testAcct = new Account (Name = 'Test Account');
    insert testAcct;

	test.startTest();
		List<RecordType> lstRecordType = [select id,name from RecordType where Name ='ABC' limit 1];
		
		Opportunity oppt = new Opportunity(
								RecordTypeID = lstRecordType[0].id, 
								Name ='New mAWS Deal',
								AccountID = testAcct.ID,
								StageName = 'Account Opened',
								Amount = 3000,
								CloseDate = System.today(),
								CurrencyIsoCode = 'USD'
								);
		insert oppt;
		oppt.Is_Approved__c=true;
		update oppt;
		
	Test.stopTest();
   
   } 
 

}
Please check below post for test classes. I hope that will help u
http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html

Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you