function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
llisallisa 

i wrote class but it is giving 0% code coverage.can someone let me know where my mistake is?

public class KAddNoteControllers {
   public boolean displayPopup {get; set;}
   public ApexPages.StandardController nad;
   public KAddNoteControllers(ApexPages.StandardController controller) {
   }
   public pagereference closePopup() {
   this.nad.save();
       PageReference pageRef = new PageReference('/apex/KDetailpage');
       pageref.setRedirect(true);
       return pageref;
   }

   public void showPopup() {
       displayPopup = true;
   }

    public K_Document__c objNote{get;set;}
    String kId='';
    public KAddNoteControllers(){
        objNote = new K_Document__c();
        kId = ApexPages.currentPage().getParameters().get('id');
    }
    public void save(){
    Datetime yourDate = Datetime.now();
    String dateOutput = yourDate.format('MM/dd/yyyy  h:mm a');
        K_Document__c doc = [Select Id, note__c from K_Document__c where id=:kId];
        if(objNote.note__c <> null){ //format('MM/dd/yyyy HH:mm:ss'
            String note = '<B>' + UserInfo.getName() + '</B>'+ '&nbsp&nbsp' + '<B>'+  yourDate.format('MM/dd/yyyy  h:mm a') + '</B>' ;
            note += '<BR/>' + objNote.note__c;
            doc.note__c = note + '<BR/><BR/>' + common.NVL(doc.note__c);
            
            update doc;
            
            
        }
    }
}
and my test class is ---

@isTest//(SeeAllData=true)
private class test_KAddNoteControllers {
  static testMethod void test_KAddNoteControllers1()
  {
      //page reference
   K_Document__c obj=new K_Document__c ();
   PageReference pageRef = Page.KAddNote;
    System.assertNotEquals(null,pageRef);
    System.assertEquals('/apex/KDetailpage',pageRef.getUrl());
    Map<String,String> pageParameters = pageRef.getParameters();
    System.assertEquals(1,pageParameters.values().size());
    System.assertEquals('recordId',pageParameters.get('id'));
  }
  private static testMethod void showpopup()
    {
        
    }
  private static testMethod void test_KAddNoteControllers2()
  { //add record
      K_Document__c k1=new K_Document__c();
      k1.id='12345';
      k1.note__c='abcde';
      insert k1;
    }  
    //for constructotr
    private static testMethod void test_KAddNoteControllers3()
    {
      K_Document__c k1=new K_Document__c();
       ApexPages.StandardController sc = new ApexPages.standardController(k1);
       KHeaderController controller = new KHeaderController(sc);
      }
    private static testMethod void save()
    {
        
    }
      }
   Please some one help me on this.please. 
Best Answer chosen by llisa
Amit Chaudhary 8Amit Chaudhary 8
Please modify your class like below
public class KAddNoteControllers 
{
   public boolean displayPopup {get; set;}
   public ApexPages.StandardController nad;
   
    public KAddNoteControllers(ApexPages.StandardController controller) {
    }
   
    public pagereference closePopup() 
    {
	   save();
       PageReference pageRef = new PageReference('/apex/KDetailpage');
       pageref.setRedirect(true);
       return pageref;
    }

    public void showPopup() 
    {
       displayPopup = true;
    }

    public K_Document__c objNote {get;set;}
    String kId='';
    
	public KAddNoteControllers()
	{
        objNote = new K_Document__c();
        kId = ApexPages.currentPage().getParameters().get('id');
    }
    public void save()
	{
		Datetime yourDate = Datetime.now();
		String dateOutput = yourDate.format('MM/dd/yyyy  h:mm a');
        K_Document__c doc = [Select Id, note__c from K_Document__c where id=:kId];
        if(objNote.note__c != null)
		{ 
			//format('MM/dd/yyyy HH:mm:ss'
            String note = '<B>' + UserInfo.getName() + '</B>'+ '&nbsp&nbsp' + '<B>'+  yourDate.format('MM/dd/yyyy  h:mm a') + '</B>' ;
            note += '<BR/>' + objNote.note__c;
            doc.note__c = note + '<BR/><BR/>' + common.NVL(doc.note__c);
            update doc;
        }
    }
}
Then Please try below test class
@isTest
private class test_KAddNoteControllers 
{
    boolean displayPopup = true;
    static testMethod void test_KAddNoteControllers1()
	{
          K_Document__c k1=new K_Document__c();
          k1.note__c='abcde';
		  k1.Order_Number__c='123';
          insert k1;
		  
		PageReference pageRef = Page.KAddNote; // Add your VF page Name here
		pageRef.getParameters().put('id', String.valueOf(k1.id));
		Test.setCurrentPage(pageRef);
        
        ApexPages.StandardController sc = new ApexPages.standardController(k1);
        KAddNoteControllers controller = new KAddNoteControllers(sc);
		controller.objNote.note__c  ='abc';
		
        controller.closePopup();
        controller.showpopup();
    }
	
	static testMethod void test_KAddNoteControllers()
	{
        K_Document__c k1=new K_Document__c();
        k1.note__c='abcde';
        k1.Order_Number__c='123';
        insert k1;

		
		PageReference pageRef = Page.KAddNote; // Add your VF page Name here
		pageRef.getParameters().put('id', String.valueOf(k1.id));
		Test.setCurrentPage(pageRef);
  
		
        KAddNoteControllers controller = new KAddNoteControllers();
		controller.objNote.note__c  ='abc';
		controller.showPopup();
        controller.save();
		controller.closePopup();
    }

}
Please check below blog for test classes.
http://amitsalesforce.blogspot.in/search/label/Test%20Class

Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

Thanks
Amit Chaudhary

All Answers

Juraj CiljakJuraj Ciljak
Hi Monalisa :),
unit test class is not very happy written :).
for example method test_KAddNoteControllers 2
1. you need insert data
​2. then call constructor off class and rest off unit test method should be written different :)

also I am not sure what are you testing with "private static testMethod void save()"

Thanks
Juraj :)
Abhishek BansalAbhishek Bansal
Hi Monalisa,

Please change your test class from below class :
 
@isTest(SeeAllData=false)
private class test_KAddNoteControllers {
	static testMethod void test_KAddNoteControllers1(){
		K_Document__c k1=new K_Document__c();
      	k1.note__c='abcde';
      	insert k1;
      	PageReference pageRef = Page.KAddNote;
    
    	Map<String,String> pageParameters = pageRef.getParameters();
    	pageParameters.put('id',k1.id);
    	
      	ApexPages.StandardController sc = new ApexPages.standardController(k1);
        KHeaderController controller = new KHeaderController(sc);
        
        controller.closePopup();
        controller.showPopup();
	}
}

Let me know if you have any issue.

Regards,
Abhishek
Abhishek BansalAbhishek Bansal
Hi Monalisa,

I would also suggest you to chrange your controller class with below code :
 
public class KAddNoteControllers {
   public boolean displayPopup {get; set;}
   public ApexPages.StandardController nad;
   public KAddNoteControllers(ApexPages.StandardController controller) {
       objNote = new K_Document__c();
       kId = ApexPages.currentPage().getParameters().get('id');
   }
   public pagereference closePopup() {
   this.nad.save();
       PageReference pageRef = new PageReference('/apex/KDetailpage');
       pageref.setRedirect(true);
       return pageref;
   }

   public void showPopup() {
       displayPopup = true;
   }

    public K_Document__c objNote{get;set;}
    String kId='';
  
    public void save(){
    Datetime yourDate = Datetime.now();
    String dateOutput = yourDate.format('MM/dd/yyyy  h:mm a');
        K_Document__c doc = [Select Id, note__c from K_Document__c where id=:kId];
        if(objNote.note__c <> null){ //format('MM/dd/yyyy HH:mm:ss'
            String note = '<B>' + UserInfo.getName() + '</B>'+ '&nbsp&nbsp' + '<B>'+  yourDate.format('MM/dd/yyyy  h:mm a') + '</B>' ;
            note += '<BR/>' + objNote.note__c;
            doc.note__c = note + '<BR/><BR/>' + common.NVL(doc.note__c);
            
            update doc;
            
            
        }
    }
}

You do not need two constructors in your class.

Regards,
Abhishek
llisallisa

Hi Abhishek,
thanks for reply,but still it is showing 0% code coverage.
Abhishek BansalAbhishek Bansal
Have you modified your controller class with the code that i have provided you in the recent post.
If yes, than please follow below steps :
 
Step 1 : Edit your controller class is Browser and save it again.
Step 2 : Go to Apex Test Execution and click the link View Test History.
Step 3 : Now click on button "Clear Test Data".
Step 4 : Open your test class in browser and click "Run Test"
Step 5 : If it ran successfully than go to developer console and check your code coverage.

Let me know if it works for you or not.

Regards,
Abhishek.
llisallisa
Hi Abhishek,

I did changes in my apex class.It Gives me an Error -System.DmlException: Insert failed. First exception on row 0; first error: REQUIRED_FIELD_MISSING, Required fields are missing: [Order_Number__c]: [Order_Number__c].
Abhishek BansalAbhishek Bansal
The error shows that you have a required field order__c on your object and you are trying to save to save the record without adding value in it. Please assign value in order__c in your controller class as well as test class.
llisallisa
Hi Abhishek,
 Thanks for replying,Your code is correct,now it will cover 31% of code.
Abhishek BansalAbhishek Bansal
Hi Monalisa,

May be there is a syntax mistake in calling Save method of your controller class.
I have modified the syntax in your class.

Please update or change your controller class with below code :
public class KAddNoteControllers {
   public boolean displayPopup {get; set;}
   public ApexPages.StandardController nad;
   public KAddNoteControllers(ApexPages.StandardController controller) {
       objNote = new K_Document__c();
       kId = ApexPages.currentPage().getParameters().get('id');
   }
   public pagereference closePopup() {
	   save();
       PageReference pageRef = new PageReference('/apex/KDetailpage');
       pageref.setRedirect(true);
       return pageref;
   }

   public void showPopup() {
       displayPopup = true;
   }

    public K_Document__c objNote{get;set;}
    String kId='';
  
    public void save(){
    Datetime yourDate = Datetime.now();
    String dateOutput = yourDate.format('MM/dd/yyyy  h:mm a');
        K_Document__c doc = [Select Id, note__c from K_Document__c where id=:kId];
        if(objNote.note__c <> null){ //format('MM/dd/yyyy HH:mm:ss'
            String note = '<B>' + UserInfo.getName() + '</B>'+ '&nbsp&nbsp' + '<B>'+  yourDate.format('MM/dd/yyyy  h:mm a') + '</B>' ;
            note += '<BR/>' + objNote.note__c;
            doc.note__c = note + '<BR/><BR/>' + common.NVL(doc.note__c);
            
            update doc;
            
            
        }
    }
}


I have corrected the syntax on line no. 9 because Save method is defined in your class, so u can call it directly by its name.
Please execute your test class again by doing these changes.

Regards,
Abhishek.
 
llisallisa
Hi Abhishek,
                   If i change that save(),it is showing 0% code coverage.I think we missed something.
Thanks for this.
llisallisa
Hi abhishek,
   thanks,but it is not covering these lines of codes.

public class KAddNoteControllers {
   public boolean displayPopup {get; set;}
   public ApexPages.StandardController nad;
   public KAddNoteControllers(ApexPages.StandardController controller) {
   }
   public pagereference closePopup() {
   this.nad.save();
       PageReference pageRef = new PageReference('/apex/KDetailpage');
       pageref.setRedirect(true);
       return pageref;

   }

   public void showPopup() {
       displayPopup = true;
   }

    public K_Document__c objNote{get;set;}
    String kId='';
    public KAddNoteControllers(){
        objNote = new K_Document__c();
        kId = ApexPages.currentPage().getParameters().get('id');
    }
    public void save(){
    Datetime yourDate = Datetime.now();
    String dateOutput = yourDate.format('MM/dd/yyyy  h:mm a');
        K_Document__c doc = [Select Id, note__c from K_Document__c where id=:kId];
        if(objNote.note__c <> null){ //format('MM/dd/yyyy HH:mm:ss'
            String note = '<B>' + UserInfo.getName() + '</B>'+ '&nbsp&nbsp' + '<B>'+  yourDate.format('MM/dd/yyyy  h:mm a') + '</B>' ;
            note += '<BR/>' + objNote.note__c;
            doc.note__c = note + '<BR/><BR/>' + common.NVL(doc.note__c);
            
            update doc;
            

            
        }
    }
}
 
Amit Chaudhary 8Amit Chaudhary 8
Please modify your class like below
public class KAddNoteControllers 
{
   public boolean displayPopup {get; set;}
   public ApexPages.StandardController nad;
   
    public KAddNoteControllers(ApexPages.StandardController controller) {
    }
   
    public pagereference closePopup() 
    {
	   save();
       PageReference pageRef = new PageReference('/apex/KDetailpage');
       pageref.setRedirect(true);
       return pageref;
    }

    public void showPopup() 
    {
       displayPopup = true;
    }

    public K_Document__c objNote {get;set;}
    String kId='';
    
	public KAddNoteControllers()
	{
        objNote = new K_Document__c();
        kId = ApexPages.currentPage().getParameters().get('id');
    }
    public void save()
	{
		Datetime yourDate = Datetime.now();
		String dateOutput = yourDate.format('MM/dd/yyyy  h:mm a');
        K_Document__c doc = [Select Id, note__c from K_Document__c where id=:kId];
        if(objNote.note__c != null)
		{ 
			//format('MM/dd/yyyy HH:mm:ss'
            String note = '<B>' + UserInfo.getName() + '</B>'+ '&nbsp&nbsp' + '<B>'+  yourDate.format('MM/dd/yyyy  h:mm a') + '</B>' ;
            note += '<BR/>' + objNote.note__c;
            doc.note__c = note + '<BR/><BR/>' + common.NVL(doc.note__c);
            update doc;
        }
    }
}
Then Please try below test class
@isTest
private class test_KAddNoteControllers 
{
    boolean displayPopup = true;
    static testMethod void test_KAddNoteControllers1()
	{
          K_Document__c k1=new K_Document__c();
          k1.note__c='abcde';
		  k1.Order_Number__c='123';
          insert k1;
		  
		PageReference pageRef = Page.KAddNote; // Add your VF page Name here
		pageRef.getParameters().put('id', String.valueOf(k1.id));
		Test.setCurrentPage(pageRef);
        
        ApexPages.StandardController sc = new ApexPages.standardController(k1);
        KAddNoteControllers controller = new KAddNoteControllers(sc);
		controller.objNote.note__c  ='abc';
		
        controller.closePopup();
        controller.showpopup();
    }
	
	static testMethod void test_KAddNoteControllers()
	{
        K_Document__c k1=new K_Document__c();
        k1.note__c='abcde';
        k1.Order_Number__c='123';
        insert k1;

		
		PageReference pageRef = Page.KAddNote; // Add your VF page Name here
		pageRef.getParameters().put('id', String.valueOf(k1.id));
		Test.setCurrentPage(pageRef);
  
		
        KAddNoteControllers controller = new KAddNoteControllers();
		controller.objNote.note__c  ='abc';
		controller.showPopup();
        controller.save();
		controller.closePopup();
    }

}
Please check below blog for test classes.
http://amitsalesforce.blogspot.in/search/label/Test%20Class

Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

Thanks
Amit Chaudhary
This was selected as the best answer
llisallisa
Thanks Amit and Abhishek for Helping me.now the the Test code runs Perfectly with 86% of code coverage.
llisallisa
HI Amit,
can u please help me on the other problems of test class.