function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
Oron MizrachiOron Mizrachi 

Apex Test for a simple soql Class

Hi i have a simple Apex Class , the only used as a controller for a visulforce page , and contain mainly soql jobs, 

But i just cant pass 72% covarge , no matter what Test in writing, 

the code below , can please some one help me with the Test class

Thank you.
public class PrivareaApex
{
 private ApexPages.StandardController stdCtrl {get; set;}
  
 public List<account> conts {get; set;}
  public string  currentRecordId {get;set;}
  public integer  Pax {get;set;}
public List<Invoice1__c> Invo {get; set;}

 public PrivareaApex(ApexPages.StandardController std)
 {

  stdCtrl=std;
  setupContacts();
 }
  
 private void setupContacts()
 {

 String Roomname=[select Unit_Name__c from account where Id=:stdCtrl.getId()].Unit_Name__c;
  conts=[select id, Name, PersonEmail, Phone, Union_Member_contact__pc from account where Unit_Name__c=:Roomname];
  Pax=[select COUNT() from account where Unit_Name__c=:Roomname];
  Invo = [select Name, Invoice_Date__c, Billed_Amount_NIS__c, Payment_Method__c,Billing_Frequency__c from Invoice1__c where Account__c=:stdCtrl.getId()];


 }
    
          }

 
James LoghryJames Loghry
Oron, first off, you need 75% code coverage across the entire org when you deploy, not a single Apex class.  As long as the "average" is above 75%, you will be able to deploy.  The best practice is to stay well north of that and as close to 100% code covered as you can get.

That being said, when you talk about the 72% code coverage, is that for the Apex class in your post, or the entire code coverage of your org? Furthermore, can you post your test class(es) that invoke your PrivareaApex method so that we can help you increase the code coverage?  

Thanks,
- James
Amit Chaudhary 8Amit Chaudhary 8
Please check below post. I hope that will help you for test class.
http://amitsalesforce.blogspot.in/search/label/Test%20Class
You can try below code test class
@isTest 
public class PrivareaApexClass 
{
	static testMethod void testMethod1() 
	{
		Account testAccount = new Account();
		testAccount.Name='Test Account' ;
		insert testAccount;

		Test.StartTest(); 
			ApexPages.StandardController sc = new ApexPages.StandardController(testAccount);
			PrivareaApex testAccPlan = new PrivareaApex(sc);

			PageReference pageRef = Page.AccountPlan; // Add your VF page Name here
			pageRef.getParameters().put('id', String.valueOf(testAccount.Id));
			Test.setCurrentPage(pageRef);

		Test.StopTest();
	}
}
Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you


 
Abhishek BansalAbhishek Bansal
Hi Oron,

Please find below your required test class :
 
@isTest(seeAllData = false)
private class PrivareaApexTestClass {
	static testMethod void testMethod() {
		Account testAccount = new Account(Name = 'Test', Unit_Name__c = 'Test Unit Name');
		insert testAccount;
		
		Invoice1__c testInvoice = new Invoice1__c(Account__c = testAccount.id, Name = 'Test Invoice');
		insert testInvoice;
		
		PageReference pageRef = Page.PrivatePage;// Please replace PrivatePage with name of your VF page
        pageRef.getParameters().put('id', String.valueOf(testAccount.Id));
        Test.setCurrentPage(pageRef);
        
        Test.startTest();
		ApexPages.StandardController sc = new ApexPages.StandardController(testAccount);
		PrivareaApex testCont = new PrivareaApex(sc);
		Test.stopTest();
	}
}

Note : Please replace the "PrivatePage" at line no.10 with name of your VF page for which you are using this controller class.
Let me know if you need more help on this.

Thanks,
Abhishek Bansal.
Oron MizrachiOron Mizrachi
Thank you, but how can i use the PrivareaApex class in the test when the  PrivareaApex class havent been deployed yet to the Production environment (its needs the test to get covarage and be deployed...) ?

and even the visualforce page need the PrivareaApex  class (as conttroller) and can be deployed before the PrivareaApex  class is been deployed....

 
Abhishek BansalAbhishek Bansal
Hi Oron,

It is not possible to deploy a component which is dependent on other components.
So you have to deploy your VF page, Controller Class, Test class together as they are dependent on each other.
I dont understand why you want to deploy Vf page first than test class than controller class.
Let me know if you need more information on this.

Thanks,
Abhishek Bansal