function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
SahajSahaj 

System.NullPointerException: Attempt to de-reference a null object?

Hi All,

Please help me with this code.
trigger catgUpdate on BMCServiceDesk__Incident__c (before insert,before update) 
{
    set<id> inc1 = new set<id>();
for(BMCServiceDesk__Incident__c inc : trigger.new)
{
    inc1.add(inc.BMCServiceDesk__FKBMC_BaseElement__c);
   
    List<BMCServiceDesk__BMC_BaseElement__c> bE = [Select id,Product_Categorization_Tier_1__c,Category_CI__c,Sub_Category_CI__c from BMCServiceDesk__BMC_BaseElement__c where id IN :inc1];
    If(bE.size()> 0)
    {
    inc.Parent__c = bE[0].Category_CI__c;
    inc.Child__c = bE[0].Sub_Category_CI__c;
    //inc.Product_1__c = bE[0].Product_Categorization_Tier_1__c;    
}
}
}

This code is working fine and Parent__c(lookup) and Child__c(lookup) values are autopopulated when I save the record.
when I edit the record and click on Parent__c or  Child__c lookup icon, it gives error ie System.NullPointerException: Attempt to de-reference a null object. Please let me know the issue

Thanks in advance.

Sahaj
 
cloudSavvyProgcloudSavvyProg
Hi Sahaj,

On which line do you get Attempt to derefernce null object?

First check if list bE is empty or not. Like the following,
If(!bE.isEmpty() && bE.size()> 0)

bE is empty, then query id returning no results.

Is BMCServiceDesk__FKBMC_BaseElement__c a mandatory field on BMCServiceDesk__Incident__c? If not check for not null for that field in your code.
if(inc.BMCServiceDesk__FKBMC_BaseElement__c != null)
inc1.add(inc.BMCServiceDesk__FKBMC_BaseElement__c);


Check if the list is empty for the query.

Hope this helps.

Regards,
CloudSavvyProg

 
Amit Chaudhary 8Amit Chaudhary 8
If found below issue in your code..
1) Null Check
2) SOQL inside for loop.

Please try below code.
trigger catgUpdate on BMCServiceDesk__Incident__c (before insert,before update) 
{
    set<id> inc1 = new set<id>();
	for(BMCServiceDesk__Incident__c inc : trigger.new)
	{
		inc1.add(inc.BMCServiceDesk__FKBMC_BaseElement__c);
	}

	if(inc1.size() > 0 )
	{
	
		Map<Id,BMCServiceDesk__BMC_BaseElement__c> bEMap = new Map<Id,BMCServiceDesk__BMC_BaseElement__c> ([Select id,Product_Categorization_Tier_1__c,Category_CI__c,Sub_Category_CI__c from BMCServiceDesk__BMC_BaseElement__c where id IN :inc1] );
		
		for(BMCServiceDesk__Incident__c inc : trigger.new)
		{
			If(bEMap!= null && bEMap.containsKey(inc.BMCServiceDesk__FKBMC_BaseElement__c))
			{
				BMCServiceDesk__BMC_BaseElement__c be =bEMap.get(inc.BMCServiceDesk__FKBMC_BaseElement__c);
				if(be.Category_CI__c != null)
				{	
					inc.Parent__c = be.Category_CI__c;
				}
				if(be.Sub_Category_CI__c != null)
				{		
					inc.Child__c = be.Sub_Category_CI__c;
				}
			}
		}
	}
	
}

Please check below post trigger best pratice
1) http://amitsalesforce.blogspot.in/2015/06/trigger-best-practices-sample-trigger.html

1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org.

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers

4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail

Let us know if this will help you

Thanks
Amit Chaudhary
SahajSahaj
Hi Amit,

Thanks for your response. I have tried the same code that you have mentioned but when I click on the lookup icon(UI) of Parent__c or Child__c. I get the same error.
Can you please help in it.

Regards,
Sahaj