function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
VSK98VSK98 

Getting Too many Soql queries 101 hit on vf page

Hi All,

Getting the Governor limit Too many Soql queries 101 hit on vf page. But it's occured in rare conditions only. How to avoid it.

may i know the best practice to write the trigger.

Regards,
Siv.
Amit Chaudhary 8Amit Chaudhary 8
Please check below postTrigger best pratice
1) http://amitsalesforce.blogspot.in/2015/06/trigger-best-practices-sample-trigger.html
2) https://developer.salesforce.com/page/Trigger_Frameworks_and_Apex_Trigger_Best_Practices
3) https://developer.salesforce.com/page/Apex_Code_Best_Practices

1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org.

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers

4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail

.............................


 
Stop the error messages
Here are some best practices that will stop the error messages and/or help you avoid hitting the Governors Limit: 

 
1. Since Apex runs on a Multitenant structure, Apex runtime engine strictly enforces limits to ensure code doesn't monopolize shared resources. Learn about the Governors Limit.
2. Avoid SOQL queries that are inside FOR loop. 
3. Check out the Salesforce Developer Blog where you can find Best Practices for Triggers.
4. Review best practices for Trigger and Bulk requests on our Force.com Apex Code Developer's Guide. 
5. Be sure you're following the key coding principals for Apex Code in our Developer's Guide.

Important: Salesforce cannot stop the Governors Limit or raise it. Following the best practices above should ensure that you don't hit this limit in the future.
Let us know if this will help you..
 
sslodhi87sslodhi87
Hi Siv,

Please post your code then only we are able to find the issue.

Thanks
VSK98VSK98
I have debugged the logs .............its showing the error in below code
 
public class name {
public static void method(list<Assignment__c> ast)

  {
  
  
   List<Task>tasks=new List<Task>();
   Set<Id> contactIds = new Set<Id>();
   List<Mob__c> updateeligibletravel=new List<Mob__c>(); 
   Set<Id> mobids= new Set<Id>();
   recordtype record=[select id,name,SobjectType from recordtype where (name='Employment Visa') and (SobjectType ='Mob__c')];//[select id,name from recordtype where name='Employment Visa'];
   recordtype cntrecd=[select id,name,SobjectType from recordtype where (name='Employee') and (SobjectType='Contact')];//[select id,name from recordtype where name='Employee'];
  
  id rcdtype=Util.getRecordTypeIdByLabel('task','Task');
  
  for(Assignment__c At:ast )
    {
       
        if(at.Mob__c!=null)
        {
           mobIds.add(at.Mob__c) ;
                    
        }
       
        
    }    
      
      
     
     
     Map<id,Mob__c> mobEntry = new Map<id,Mob__c>
     ([select id,name,Eligible_for_Travel__c,wct_mobility_type__c,Immigration__r.Visa_Type__c,
           Immigration__r.Visa_Expiration_Date__c,Immigration__r.WCT_Immigration_Record_Type__c,Mob_Employee__c,
           Visa_Expiration_Date__c,Immigration__r.Maxout_Date__c,Employee_Email_Address__c,(select 94_Expiration__c from I_94__r order by CreatedDate desc) 
           from Mob__c where id in :mobids]);
           map<id,id> conmob=new map<id,id>();--------------------ERROR HERE
     
    for(Assignment__c At:ast)
    {
    
                  Mob__c con2 = mobEntry.get(at.Mob__c);
 
                    if(con2.Mob_Employee__c!=null)
                        {
                           conmob.put(con2.id,con2.Mob_Employee__c);
                           contactIds.add(con2.Mob_Employee__c) ;
                        }
    
    }

Any suggestions

Adv Thnx,
VSK
Temoc MunozTemoc Munoz
Hi VSK.

First, we need to make sure that queries that are the same on every call should be avoided.

Change this:
recordtype record=[select id,name,SobjectType from recordtype where (name='Employment Visa') and (SobjectType ='Mob__c')];

recordtype cntrecd=[select id,name,SobjectType from recordtype where (name='Employee') and (SobjectType='Contact')];

to this (this won't count towards your governor limits)
Id record = Schema.SObjectType.Mob__c.getRecordTypeInfosByName().get('Employment Visa').getRecordTypeId();
Id cntrecd = Schema.SObjectType.Contact.getRecordTypeInfosByName().get('Employee').getRecordTypeId();
Are the above record types used in your code by the way? If not, please remove these queries then..

Second, this code may not be the root cause. Do you have triggers that are called several times? Are there any triggers that are hitting several classes containing SOQL statements? Do you have unnecessary trigger calls that you need to deprecate?

Thanks