You need to sign in to do that
Don't have an account?
Karthik Sundara Raj
trigger ServiceLifeTimeValue on Service_Work_Order__c (after insert, after update){
if (trigger.isAfter && (trigger.isInsert || trigger.isUpdate) ){
string VINNumber;
Vehicle__c objVehicle = new Vehicle__c();
for(Service_Work_Order__c swo:trigger.new){
VINNumber = swo.Workorder_VIN_Number__c;
AggregateResult[] totalCost = [select SUM(Test_Total_Work_Order_Cost_ExGST__c) from Service_Work_Order__c where Workorder_VIN_Number__c=:VINNumber];
objVehicle = [Select Id,Test_service_life_time_value__c From Vehicle__c Where Name=:VINNumber];
objVehicle.Test_service_life_time_value__c =Integer.valueOf(totalCost);
}
Update objVehicle;
}
}
I have recived Following Error meassage:
Error:Apex trigger ServiceLifeTimeValue caused an unexpected exception, contact your administrator: ServiceLifeTimeValue: execution of AfterUpdate caused by: System.QueryException: List has more than 1 row for assignment to SObject: Trigger.ServiceLifeTimeValue: line 11, column 1
Thanks,
Karthik
What is the problem of this "Trigger"?
trigger ServiceLifeTimeValue on Service_Work_Order__c (after insert, after update){
if (trigger.isAfter && (trigger.isInsert || trigger.isUpdate) ){
string VINNumber;
Vehicle__c objVehicle = new Vehicle__c();
for(Service_Work_Order__c swo:trigger.new){
VINNumber = swo.Workorder_VIN_Number__c;
AggregateResult[] totalCost = [select SUM(Test_Total_Work_Order_Cost_ExGST__c) from Service_Work_Order__c where Workorder_VIN_Number__c=:VINNumber];
objVehicle = [Select Id,Test_service_life_time_value__c From Vehicle__c Where Name=:VINNumber];
objVehicle.Test_service_life_time_value__c =Integer.valueOf(totalCost);
}
Update objVehicle;
}
}
I have recived Following Error meassage:
Error:Apex trigger ServiceLifeTimeValue caused an unexpected exception, contact your administrator: ServiceLifeTimeValue: execution of AfterUpdate caused by: System.QueryException: List has more than 1 row for assignment to SObject: Trigger.ServiceLifeTimeValue: line 11, column 1
Thanks,
Karthik
All Answers
The problem is in this query -
objVehicle = [Select Id,Test_service_life_time_value__c From Vehicle__c Where Name=:VINNumber];
The query is returning multiple records and you are storing them in single instance of objVehicle.
You can either add LIMIT 1 clause in query if you want your query to return only one record or
Use -
List<Vehicle__c> lstVehicle = [Select Id,Test_service_life_time_value__c From Vehicle__c Where Name=:VINNumber];
and iterate the list
Minor change in code. Please check below post to learn Trigger best pratice
1) http://amitsalesforce.blogspot.in/2015/06/trigger-best-practices-sample-trigger.html
1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts
2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org.
3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers
4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.
5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception
6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits
7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore
8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found
9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail
Let us know if this will help you
Thanks
Amit Chaudhary
Thanks for your detailed reply.
those 2 SOQL is working fine on work bench
select SUM(Test_Total_Work_Order_Cost_ExGST__c) from Service_Work_Order__c where Workorder_VIN_Number__c='WAUZZZ8K0EA068613'
Select Id,Test_service_life_time_value__c From Vehicle__c Where Name='WAUZZZ8K0EA068613'
but still i am getting error as below:
Error:Apex trigger ServiceLifeTimeValue caused an unexpected exception, contact your administrator: ServiceLifeTimeValue: execution of AfterUpdate caused by: System.SObjectException: Invalid field VIN for AggregateResult: Trigger.ServiceLifeTimeValue: line 20, column 1
Thanks,
Karthik
I got Following Error:
Error:Apex trigger ServiceLifeTimeValue caused an unexpected exception, contact your administrator: ServiceLifeTimeValue: execution of AfterUpdate caused by: System.SObjectException: SObject row was retrieved via SOQL without querying the requested field: Vehicle__c.Name: Trigger.ServiceLifeTimeValue: line 30, column 1
It works well,Thanks a lot.
@Nayana and Mandy,
Thanks for you help.
I would like to map same data Vehicle Object to Service work order Object which have master-details relationship.I tried that code but it not working,Please find the code in below:It is in bold and italic:
trigger ServiceLifeTimeValue on Service_Work_Order__c (after insert, after update)
{
if (Trigger.isAfter && (Trigger.isInsert || Trigger.isUpdate))
{
Set<String> setStrVINNumber = new Set<String>();
Set<String> setStrVINNumber1 = new Set<String>();
Map<String, Decimal> mapStrVINNumToTotal = new Map<String, Decimal>();
List<Vehicle__c> lstVehicleToUpdate = new List<Vehicle__c>();
// iterate over SWOs and collect VIN numbers
for(Service_Work_Order__c objSWO : Trigger.New)
{
setStrVINNumber.add(objSWO.Workorder_VIN_Number__c);
}
// calculate sum
for(AggregateResult objAR : [ SELECT SUM(Test_Total_Work_Order_Cost_ExGST__c) total, Workorder_VIN_Number__c VIN
FROM Service_Work_Order__c
WHERE Workorder_VIN_Number__c IN :setStrVINNumber GROUP BY Workorder_VIN_Number__c] )
{
mapStrVINNumToTotal.put((String)objAR.get('VIN'),(Decimal)objAR.get('total'));
}
// iterate over matching vehicles and update the total amount.
for(Vehicle__c objVehicle : [ SELECT Id,Test_service_life_time_value__c ,Name
FROM Vehicle__c
WHERE Name IN :setStrVINNumber])
{
if(mapStrVINNumToTotal.containsKey(objVehicle.Name))
{
objVehicle.Test_service_life_time_value__c = mapStrVINNumToTotal.get(objVehicle.Name);
lstVehicleToUpdate.add(objVehicle);
/*/////////////////////////////////////////////////////////////*/
for(Vehicle__c objVehicle1 : [ SELECT Id,Test_service_life_time_value__c ,Name
FROM Vehicle__c
WHERE Name IN :setStrVINNumber])
{
setStrVINNumber1.add(objVehicle1.Id);
for(Vehicle_Ownership__c objAVO : [ SELECT Id,VIN__c,Test_Roll__c ,Name
FROM Vehicle_Ownership__c
WHERE VIN__c IN :setStrVINNumber1 AND Customer_Vehicle_Relationship_Status__c='Active'])
{
objAVO.Test_Roll__c=objVehicle1.Test_service_life_time_value__c ;
//lstVehicleToUpdate.add(objVehicle); }
}
/*/////////////////////////////////////////////////////////////*/
}
}
// update vehicles - If any exception occurs, it throw an error - so passed 'true'
if(lstVehicleToUpdate.size() > 0 ) // check list size before DML
{
DataBase.Update(lstVehicleToUpdate, true);
}
}
}
}
I would like to map same data Vehicle Object to Service work order Object which have master-details relationship.I tried that code but it not working,Please find the code in below:It is in bold and italic:
trigger ServiceLifeTimeValue on Service_Work_Order__c (after insert, after update)
{
if (Trigger.isAfter && (Trigger.isInsert || Trigger.isUpdate))
{
Set<String> setStrVINNumber = new Set<String>();
Set<String> setStrVINNumber1 = new Set<String>();
Map<String, Decimal> mapStrVINNumToTotal = new Map<String, Decimal>();
List<Vehicle__c> lstVehicleToUpdate = new List<Vehicle__c>();
// iterate over SWOs and collect VIN numbers
for(Service_Work_Order__c objSWO : Trigger.New)
{
setStrVINNumber.add(objSWO.Workorder_VIN_Number__c);
}
// calculate sum
for(AggregateResult objAR : [ SELECT SUM(Test_Total_Work_Order_Cost_ExGST__c) total, Workorder_VIN_Number__c VIN
FROM Service_Work_Order__c
WHERE Workorder_VIN_Number__c IN :setStrVINNumber GROUP BY Workorder_VIN_Number__c] )
{
mapStrVINNumToTotal.put((String)objAR.get('VIN'),(Decimal)objAR.get('total'));
}
// iterate over matching vehicles and update the total amount.
for(Vehicle__c objVehicle : [ SELECT Id,Test_service_life_time_value__c ,Name
FROM Vehicle__c
WHERE Name IN :setStrVINNumber])
{
if(mapStrVINNumToTotal.containsKey(objVehicle.Name))
{
objVehicle.Test_service_life_time_value__c = mapStrVINNumToTotal.get(objVehicle.Name);
lstVehicleToUpdate.add(objVehicle);
/*/////////////////////////////////////////////////////////////*/
for(Vehicle__c objVehicle1 : [ SELECT Id,Test_service_life_time_value__c ,Name
FROM Vehicle__c
WHERE Name IN :setStrVINNumber])
{
setStrVINNumber1.add(objVehicle1.Id);
for(Vehicle_Ownership__c objAVO : [ SELECT Id,VIN__c,Test_Roll__c ,Name
FROM Vehicle_Ownership__c
WHERE VIN__c IN :setStrVINNumber1 AND Customer_Vehicle_Relationship_Status__c='Active'])
{
objAVO.Test_Roll__c=objVehicle1.Test_service_life_time_value__c ;
//lstVehicleToUpdate.add(objVehicle); }
}
/*/////////////////////////////////////////////////////////////*/
}
}
// update vehicles - If any exception occurs, it throw an error - so passed 'true'
if(lstVehicleToUpdate.size() > 0 ) // check list size before DML
{
DataBase.Update(lstVehicleToUpdate, true);
}
}
}
}