function readOnly(count){ }
Sign Up ›
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
Learn More

Browse by Topic
ShowAll Questionssorted byDate Posted
+ Start a Discussion
Steve CairneySteve Cairney 

Faking a record ID for a test class

Hi all, when you have a test class in your sandbox that references the ID of a record of a custom object within the sandbox, how to do get round the fact that this object and record won't exist in your production org when you come to test the changeset?
Best Answer chosen by Steve Cairney
Ravi Dutt SharmaRavi Dutt Sharma
String details = ItsApprovedWebservices.GetBookingDetails(bookingdetails.Id);

Use the id of inserted record, instead of hardcoding it.

All Answers

Ravi Dutt SharmaRavi Dutt Sharma
Hey Steve,
I think you are using SeeAllData=true attribute in your test classes. It is generally not a good practice to query the data which is already present in the org. Do not use SeeAllData=true. Instead create the test data in the test class itself and then use that data to test your methods.
Steve CairneySteve Cairney
Ravi, you are indeed correct! I am using SeeAllData.

I'll work on creating the test data in the class, and report back, thanks.
Mahesh DMahesh D
Hi Steve,

Please check below post for test classes. I hope that will help you
1) http://amitsalesforce.blogspot.com/search/label/Test%20Class
2) http://amitsalesforce.blogspot.com/2015/06/best-practice-for-test-classes-sample.html

Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process.

Please do let me know if it helps you.

Regards,
Mahesh
Steve CairneySteve Cairney
Ravi,

Here's the test class as it stands (it's for a webservice)

What I'll need to do is create test data for an object called Its_Approved_Booking__c but I'm not sure how to implement the code in here. I've successfully created a controller and test class using this object but the methods don't work in this class (I've commented out my efforts)
  
@isTest(seeAlldata = true)
public class Testing_ItsApprovedWebServices {
    @istest public static  void ItsApprovedWebServicesTest(){ 
        
        //Set up test IABooking and give it an ID
        //ItsApproved_Booking__c bookingdetails = new ItsApproved_Booking__c(id = 'a138E000000N9dr');

        Test.setMock(HttpCalloutMock.class, new MockHttpResponseGenerator()); 

        String username = ItsApprovedWebServices.Login('test');
        String details = ItsApprovedWebservices.GetBookingDetails('a138E000000N9dr');

        Test.setMock(HttpCalloutMock.class, new MockHttpResponseGenerator2()); 
        String postbooking = ItsApprovedWebServices.PostBooking('{"test" : "test"}','authorization_id');

    }		
}

 
Ravi Dutt SharmaRavi Dutt Sharma
Hey Steve,

I am not sure what you mean by below line :
  
ItsApproved_Booking__c bookingdetails = new ItsApproved_Booking__c(id = 'a138E000000N9dr');

You cannot pass the id parameter will creating the record. You need just pass the mandatory fields present on object and then insert the record. Salesforce will generate the id by itself. Something like below should work for you.
  
@isTest(seeAlldata = true)
public class Testing_ItsApprovedWebServices {
    @istest public static  void ItsApprovedWebServicesTest(){ 
        
        //Set up test IABooking and give it an ID
        //ItsApproved_Booking__c bookingdetails = new ItsApproved_Booking__c(Name='Test', Plus other mandatory fields here);
insert bookingdetails ;

        Test.setMock(HttpCalloutMock.class, new MockHttpResponseGenerator()); 

        String username = ItsApprovedWebServices.Login('test');
        String details = ItsApprovedWebservices.GetBookingDetails(bookingdetails.Id);

        Test.setMock(HttpCalloutMock.class, new MockHttpResponseGenerator2()); 
        String postbooking = ItsApprovedWebServices.PostBooking('{"test" : "test"}','authorization_id');

    }		
}

Let me know if you have any questions. Thanks.
Steve CairneySteve Cairney
Thanks Ravi, annoyingly, the Name field is actually an autonumber with the format AI-{0000} and it's the only required field.

What's the syntax to take that into account?
Ravi Dutt SharmaRavi Dutt Sharma
ItsApproved_Booking__c bookingdetails = new ItsApproved_Booking__c();
insert bookingdetails ;

Try this code sample then, it should work. Thanks.
Steve CairneySteve Cairney
Thanks Ravi, I'll need to change the following line too right?
  
String details = ItsApprovedWebservices.GetBookingDetails('a138E000000N9dr');

Here is the GetBookingDetails from the referenced class, I'm not sure what to put as the string now, since we can't hard-code an ID.
  
webservice static String GetBookingDetails(ID id) {
    JSONGenerator jsonGenerator = JSON.createGenerator(true);
          
      ItsApproved_Booking__c booking = [SELECT Id, Name, Booking_Title__c, Customer_Reference__c, Incharge_Date__c FROM ItsApproved_Booking__c WHERE Id = :id];

 
Ravi Dutt SharmaRavi Dutt Sharma
String details = ItsApprovedWebservices.GetBookingDetails(bookingdetails.Id);

Use the id of inserted record, instead of hardcoding it.
This was selected as the best answer
Steve CairneySteve Cairney
Thanks Ravi, the problem now is I have a DLM and a Callout within the same transaction so I'll need to sepatate the processes.

I thought this might solve the issue but the variable bookingdetails is outside the loop now. Can you suggest the correct syntax here?
  
@isTest
public class Testing_ItsApprovedWebServices {
    	
    public static testMethod void insertBooking(){ 
        ItsApproved_Booking__c bookingdetails = new ItsApproved_Booking__c();
    	insert bookingdetails;
    }
	@isTest public static  void ItsApprovedWebServicesTest(){
        Test.setMock(HttpCalloutMock.class, new MockHttpResponseGenerator()); 

        String username = ItsApprovedWebServices.Login('test');
        String details = ItsApprovedWebservices.GetBookingDetails(bookingdetails.Id);

        Test.setMock(HttpCalloutMock.class, new MockHttpResponseGenerator2()); 
        String postbooking = ItsApprovedWebServices.PostBooking('{"test" : "test"}','authorization_id');

    }		
}

 
Steve CairneySteve Cairney
Seems that Test.startTest and Test.stopTest will work, however it throws up errors relating to ItsApprovedWebServices.cls so I'm going to check those out
  
@isTest
public class Testing_ItsApprovedWebServices {

	@isTest public static  void ItsApprovedWebServicesTest(){
        ItsApproved_Booking__c bookingdetails = new ItsApproved_Booking__c();
    	insert bookingdetails;
        
        Test.startTest();
        Test.setMock(HttpCalloutMock.class, new MockHttpResponseGenerator()); 

        String username = ItsApprovedWebServices.Login('test');
        String details = ItsApprovedWebservices.GetBookingDetails(bookingdetails.Id);
		
        Test.setMock(HttpCalloutMock.class, new MockHttpResponseGenerator2()); 
        String postbooking = ItsApprovedWebServices.PostBooking('{"test" : "test"}','authorization_id');
		
        Test.stopTest();
    }		
}

 
Ravi Dutt SharmaRavi Dutt Sharma
@isTest(seeAlldata = false)
public class Testing_ItsApprovedWebServices {
    @istest public static  void ItsApprovedWebServicesTest(){ 
        
		Test.startTest();
        ItsApproved_Booking__c bookingdetails = new ItsApproved_Booking__c();
		insert bookingdetails ;
		Test.stopTest();
		
        Test.setMock(HttpCalloutMock.class, new MockHttpResponseGenerator()); 

        String username = ItsApprovedWebServices.Login('test');
        String details = ItsApprovedWebservices.GetBookingDetails(bookingdetails.Id);

        Test.setMock(HttpCalloutMock.class, new MockHttpResponseGenerator2()); 
        String postbooking = ItsApprovedWebServices.PostBooking('{"test" : "test"}','authorization_id');

    }		
}

Enclose you DML operation within Test.startTest() and Test.stopMethod()
Ravi Dutt SharmaRavi Dutt Sharma
Yes Steve, you are correct. I told you the other way wrong, my code snippet wont work.Enclose the portion of your code that performs the callout within Test.startTestand Test.stopTest statements. The Test.startTest statement must appear before the Test.setMock statement. Also, the calls to DML operations must not be part of the Test.startTest/Test.stopTest block.
Steve CairneySteve Cairney
Great, I've managed to get a successful pass using the below, however the coverage is low so I will have to use the same technique to add the other related objects and fields that are needed by ItsApprovedWedservice.cls. Thanks for your help!

 
Steve CairneySteve Cairney
Hi Ravi, I've hit Lists, which I've never tested data with before.

The offending is this in the ItsApprovedWebServices.cls
  
List<IA_Product__c> IAProducts = [SELECT Id, Code__c FROM IA_Product__c WHERE Id = :p.IAProduct__c];

        jsonGenerator.writeStartObject(); // Products
        jsonGenerator.writeStringField('ProductionCode', IAProducts[0].Code__c);           
        jsonGenerator.writeStringField('CustomerProductReference', IAProducts[0].Code__c);

I'm trying various approaches in test class, but nothing is working

This is my latest attempt
  
IA_Product__c iaproduct = new IA_Product__c(Code__c = '606');
        insert iaproduct;
        
        List<IA_Product__c> productlist = [SELECT Id, Code__c From IA_Product__c WHERE Id = :iaproduct.Id];
        insert productlist;

How can I ensure that I create the test data for the IA_Product__c but then make sure the list is not empty?