Apex Code Development You need to sign in to do that
Don't have an account?
Adam Bengtson My test class does not seem to be covering my code properly.
I am having issues getting all of my code covered or at least 75% of it.
I have tested my class manually and everything seems to work properly, but when I run my test class it does not cover the code I expected it to. I am creating a contact con1 and retrieving the Individual_Auto_ID__c is an auto generated unique custom field. When passed to the function it should find the newly created con and return exactly 1 result since I just created that contact. This works perfect when testing manually but not when the Test function runs it. Am I missing something?
Test Class:
My Controller:
I have tested my class manually and everything seems to work properly, but when I run my test class it does not cover the code I expected it to. I am creating a contact con1 and retrieving the Individual_Auto_ID__c is an auto generated unique custom field. When passed to the function it should find the newly created con and return exactly 1 result since I just created that contact. This works perfect when testing manually but not when the Test function runs it. Am I missing something?
Test Class:
@isTest
private class myController_Test {
static testMethod void myTestController_Test() {
//----------------------------------------
//TEST CLASS FOR myController
//----------------------------------------
Contact con1 = new Contact(firstname='Test', lastname='Test', email='test@aei.org');
insert con1;
string con_id = con1.Individual_Auto_ID__c;
string field_name = 'test';
//unsubscribe - good and bad values
boolean valid = myController.unsubscribe(con_id, field_name);
}
My Controller:
global with sharing class myController {
public static List<Contact> contacts {get; set;}
@RemoteAction
global static boolean unsubscribe(string user_id, string newsletterField) {
Boolean valid = true;
contacts = [SELECT FirstName
FROM Contact
WHERE Individual_Auto_ID__c = :user_id];
if(contacts.size() < 1) {
valid = false;
} else {
//This is not being covered
}
return valid;
}
}
Please find the below Test Class:
@isTest private class myController_Test { static testMethod void myTestController_Test() { //---------------------------------------- //TEST CLASS FOR myController //---------------------------------------- Contact con = new Contact(firstname='Test', lastname='Test', email='test@aei.org', Individual_Auto_ID__c = 'Test User'); insert con; string con_id = con.Individual_Auto_ID__c; string field_name = 'test'; //unsubscribe - good and bad values boolean valid = myController.unsubscribe(con_id, field_name); }Please check below post for test classes. I hope that will help you
1) http://amitsalesforce.blogspot.com/search/label/Test%20Class (http://amitsalesforce.blogspot.com/search/label/Test%20Class" target="_blank)
2) http://amitsalesforce.blogspot.com/2015/06/best-practice-for-test-classes-sample.html (http://amitsalesforce.blogspot.com/2015/06/best-practice-for-test-classes-sample.html" target="_blank)
3) https://developer.salesforce.com/page/An_Introduction_to_Apex_Code_Test_Methods
Please follow below salesforce Best Practice for Test Classes :-
1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process.
Please do let me know if it helps you.
Regards,
Mahesh
Also added the assertion here:
@isTest private class myController_Test { static testMethod void myTestController_Test() { //---------------------------------------- //TEST CLASS FOR myController //---------------------------------------- Contact con = new Contact(firstname='Test', lastname='Test', email='test@aei.org', Individual_Auto_ID__c = 'Test User'); insert con; string con_id = con.Individual_Auto_ID__c; string field_name = 'test'; //unsubscribe - good and bad values boolean valid = myController.unsubscribe(con_id, field_name); System.assertEquals(true, valid); }Please do let me know if it helps you.
Regards,
Mahesh
Did you test the solution which I posted?
Regards,
Mahesh
I cannot manually set "Individual_Auto_ID__c" its an auto generated field. I am also going through the links and best practices now to see if maybe I missed something.
Please try below code. I hope that will help you
@isTest private class myController_Test { static testMethod void myTestController_Test() { Contact con1 = new Contact(firstname='Test', lastname='Test', email='test@aei.org'); insert con1; string con_id = con1.Individual_Auto_ID__c; string field_name = 'test'; //unsubscribe - good and bad values boolean valid = myController.unsubscribe(con_id, field_name); } static testMethod void myTestController_Test1() { Contact con1 = new Contact(firstname='Test', lastname='Test', email='test@aei.org'); insert con1; Contact cont = [select Individual_Auto_ID__c from contact where id=:con1.id]; // try to get auto number from query string con_id = cont.Individual_Auto_ID__c; string field_name = 'test'; boolean valid = myController.unsubscribe(con_id, field_name); } }Please let us know if this will help youThanks
Amit Chaudhary
Please find the below Test Class:
Here I considered
(1) The assertios as seertions are important for every Test Class
(2) Naming Conventions.
(3) Added the comments.
@isTest private class myController_Test { @isTest static void myTestController_TestSuccess() { //---------------------------------------- //TEST CLASS FOR myController //---------------------------------------- Contact con = new Contact(firstname='Test', lastname='Test', email='test@aei.org'); insert con; con = [select Individual_Auto_ID__c from contact where Id =: con.id]; string con_id = con.Individual_Auto_ID__c; string field_name = 'test'; //unsubscribe - good and bad values boolean valid = myController.unsubscribe(con_id, field_name); System.assertEquals(true, valid); } @isTest static void myTestController_TestFailure() { Contact con = new Contact(firstname='Test', lastname='Test', email='test@aei.org'); insert con; con = [select Individual_Auto_ID__c from contact where Id =: con.id]; string con_id = '1234'; // Setting a different value so that we can test the failure scenario. string field_name = 'test'; //unsubscribe - good and bad values boolean valid = myController.unsubscribe(con_id, field_name); System.assertEquals(false, valid); } }Please do let me know if it helps you.
Regards,
Mahesh
I tried both, and still it cannot seem to cover my code properly. There is something weird going on with the "Individual_Auto_ID__c", is there a way to output variables in the test class? I am unsure if it is getting set or if its not getting created properly.
@isTest private class myController_Test { static testMethod void myTestController_Test() { Contact con1 = new Contact(firstname='Test', lastname='Test', email='test@aei.org'); insert con1; Contact con = [SELECT ID, Individual_Auto_ID__c FROM Contact Where ID =: con1.ID LIMIT 1]; System.debug('Contact Record ' + con); //Check in debug logs if you are getting any values. string con_id = con.Individual_Auto_ID__c; string field_name = 'test'; boolean valid = myController.unsubscribe(con_id, field_name); } }Have a look to it,Regards
Rahul
Please share the screenshot of your Class's code coverage. Which lines are covering and which lines are not covering.
Also you can use the System.debug('') and print the debug logs. Before testing the Test Class enable the debug.
@isTest private class myController_Test { @isTest static void myTestController_TestSuccess() { //---------------------------------------- //TEST CLASS FOR myController //---------------------------------------- Contact con = new Contact(firstname='Test', lastname='Test', email='test@aei.org'); insert con; con = [select Id, Individual_Auto_ID__c from contact where Id =: con.id]; System.debug('=====con:'+con); string con_id = con.Individual_Auto_ID__c; string field_name = 'test'; //unsubscribe - good and bad values boolean valid = myController.unsubscribe(con_id, field_name); System.assertEquals(true, valid); } @isTest static void myTestController_TestFailure() { Contact con = new Contact(firstname='Test', lastname='Test', email='test@aei.org'); insert con; con = [select Id, Individual_Auto_ID__c from contact where Id =: con.id]; System.debug('=====con:'+con); string con_id = '1234'; // Setting a different value so that we can test the failure scenario. string field_name = 'test'; //unsubscribe - good and bad values boolean valid = myController.unsubscribe(con_id, field_name); System.assertEquals(false, valid); } }Please do let me know if it helps you.Regards,
Mahesh
I tested your code in my developer org and i am getting 100% code coverage in my developer org.
I am simply using below test class.
@isTest private class myController_Test { static testMethod void myTestController_Invaild() { Contact cont = new Contact(firstname='Test', lastname='Test', email='test@aei.org'); insert cont; string con_id ='1234'; string field_name = 'test'; boolean valid = myController.unsubscribe(con_id, field_name); System.assertEquals(false, valid); } static testMethod void myTestController_Valid() { Contact cont = new Contact(firstname='Test', lastname='Test', email='test@aei.org'); insert cont; cont = [select Individual_Auto_ID__c from contact where id=:cont.id]; // try to get auto number from query string con_id = cont.Individual_Auto_ID__c; string field_name = 'test'; boolean valid = myController.unsubscribe(con_id, field_name); System.assertEquals(true, valid); } }NOTE:- Please execute your test class from salesforce UI then refresh your main class to check code coverage
Please let us know if this will help you
Thanks
Amit Chaudhary