You need to sign in to do that
Don't have an account?
Kev Brier
Trigger Too many SOQL queries: 101
Hi,
We're new to Salesforce Development but we've managed to pull together a trigger that updates a Primary Contact Lookup on the opportunity. The trigger works perfectly well, however, we hit the SQL limit in Salesforce and are unsure how to overcome this.
Please can you advise on how the code could be written in a more efficient way?
Thanks,
Kev
We're new to Salesforce Development but we've managed to pull together a trigger that updates a Primary Contact Lookup on the opportunity. The trigger works perfectly well, however, we hit the SQL limit in Salesforce and are unsure how to overcome this.
Please can you advise on how the code could be written in a more efficient way?
trigger trgMnCopyPrimaryContact on Opportunity (before update) { for (Opportunity o : Trigger.new) { OpportunityContactRole[] contactRoleArray = [select ContactID, isPrimary from OpportunityContactRole where OpportunityId = :o.id ORDER BY isPrimary DESC, createdDate]; if (contactRoleArray.size() > 0) { o.Opportunity_contact__c = contactRoleArray[0].ContactID; }else{ o.Opportunity_contact__c = null; } } }
Thanks,
Kev
All Answers
We shouldn't use the soql query in the for loop which leads to hits the govener limit. Here copy the below modified code Let me know if you face any errors, alternatively mark this answer as best if this solves your problem.
Regards,
Sai Krishna Tavva.
1) SOQL inside For loop
Please try below code.
Please check below post for trigger best pratice
1) http://amitsalesforce.blogspot.in/2015/06/trigger-best-practices-sample-trigger.html
2) http://amitsalesforce.blogspot.in/2015/03/how-to-stop-recursive-trigger-in.html
1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts
2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org.
3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers
4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.
5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception
6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits
7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore
8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found
9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail
PLease let us know if this will help you
https://help.salesforce.com/apex/HTViewSolution?id=000181404&language=en_US
Idea is that, your code should not have any SOQL queries running within a loop. All data has to be fetched outside the for/while loop before actually using it within the loop. You have to watch out for tricky ones like a function being called within for loop and the function having a SOQL query inside, which technically makes it SOQL inside loop.
I have updated your code with a fix below:
I have done the following changes:
1. Moved SOQL from line 5 to outside the loop.
2. Captured the OpportunityContactRole records from this SOQL and put it in a map
3. Now. within the for loop, instead of querying through SOQL, I am just accessing the pre-fetched data from within the map and assigning to the field "Opportunity_contact__c "
Hope this helps.
Tavva - Unfortunately we hit this error - Incompatible element type Id for collection of OpportunityContactRole at line 6 column 20
Amit - Unfortunately we hit this error - Variable does not exist: o.setOpp at line 11 column 84
Rajiv - Unfortunately we hit this error - Method does not exist or incorrect signature: [Map<Id,OpportunityContactRole>].contains(Id) at line 7 column 12
Thanks for all your help, any further help would be gratefully appreciated.
Thanks,
Kev
I'm setting your answer to Best and will push the trigger to Live using Eclispe.
Thanks,
Kev