+ Start a Discussion
Atla MasthanaiahAtla Masthanaiah 

I want test class for this program

trigger afterupdatecon on Account (after insert){
list<id> accid=new list<id>();
    list<contact> con=new list<contact>();
    map<id,account> oldmap=trigger.oldmap;
    map<id,account> newmap=trigger.newmap;
    for(id aid:oldmap.keyset()){
list<account> acclist=[select phone,(select OtherPhone from contacts) from account where id in:accid];
for(account a:acclist){
    for(contact c:a.contacts){
    update con;
Mahesh DMahesh D
Hi Atla,

Please find the modified trigger:

(1) Handled all scenarios.
(2) Bulkified the trigger.
(3) Naming convention.
(4) Alignment.
(5) Added the comments.
(6) Tested the code in my DE environment and everything looks good.
(7) Added Test class with 100% coverage along with assertions.

// Trigger on Account object to handle after update action.
trigger AccountTrigger on Account (after update){
    Set<Id> accIdSet = new Set<Id>();
    // Iterating through the input records.
    for(Account acc: Trigger.new){
        if(acc.Phone != Trigger.oldMap.get(acc.Id).Phone) {
    // Check if Set is empty or not.
    if(!accIdSet.isEmpty()) {
        List<Contact> conList = [Select Id, OtherPhone, AccountId, Account.Phone from Contact where AccountId IN: accIdSet];
        if(conList != null && !conList.isEmpty()) {
            for(Contact con: conList) {
                con.OtherPhone = con.Account.Phone;
            update conList;
Here is the Test Class which covers 100%
private class AccountTriggerTest {
    static void testMethodOne() {
        Account acc = new Account();
        acc.Name='Test Account';
        insert acc;

        Contact cont = new Contact();
        insert cont;
        acc.Phone = '111-222-3333';
        update acc;
        Contact contNew = [select Id, OtherPhone from Contact where Id =: cont.Id LIMIT 1];
        System.assertEquals(acc.Phone, contNew.OtherPhone);

Please check below post for test classes.
1) https://developer.salesforce.com/page/An_Introduction_to_Apex_Code_Test_Methods

Please follow below salesforce Best Practice for Test Classes :

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process.

Please do let me know if it helps you.