+ Start a Discussion
Selvakumar Anbazhagan 7Selvakumar Anbazhagan 7 

Test Coverage Issue

Hi,

I have created a Trigger and trying to deploy to production. But am getting Deployment error because of Test Coverage as follows:

Code Coverage Failure
The following triggers have 0% code coverage. Each trigger must have at least 1% code coverage.
CarrierChannelPB


My Trigger and Test classes is given below. How i can resolve this?

Trigger :

/* Assign CarrierChanne Pricebook whenever CarrierChanne recordtype chosen */
trigger CarrierChannelPB on Opportunity (Before insert, Before update) {
if(Trigger.isBefore && (Trigger.isInsert || Trigger.isUpdate))
            {
                 List<Pricebook2> prcbooklist = [select id,name from pricebook2];
                 Map<String,Id> prcbookMap = new Map<String,Id>();
                 Map<Id,String> abbAccmap = new Map<Id,String>();
                 List<RecordType> recordtypId =  [Select Id,Name From RecordType Where SobjectType = 'Opportunity'];
                 Map<Id,String> recMap = new Map<Id,String>();
                 Set<Opportunity> OppItrortunityUpdateIds = new Set<Opportunity>();
                 Set<Id> accountIds = new Set<Id>();
                 Set<Id> RectypIds = new Set<Id>();
                              
                if(!prcbooklist.isEmpty())
                {
                    for(Pricebook2 prcIter : prcbooklist)
                    {
                        prcbookMap.put(prcIter.name,prcIter.id);
                    }
                }
                System.debug('==prcmap'+prcbookMap);
                
                for(RecordType rectyp : recordtypId)
                {
                    recMap.put(rectyp.Id,rectyp.name);
                }
                
                for(Opportunity OppIdsItr : Trigger.new)
                {
                    accountIds.add(OppIdsItr.accountid);
                    
                }
                for(Account AccItr : [SELECT id,ABB_Region__c FROM Account WHERE Id IN:accountIds])
                {
                    abbAccmap.put(AccItr.id,AccItr.ABB_Region__c);
                }
            
                for(Opportunity OppItr : Trigger.new)
                {
                    if(prcbookMap.size() > 0)
                    { 
                         
                        if (recMap.get(OppItr.RecordTypeId) == 'p) Carrier')
                        {
                            OppItr.Pricebook2Id = prcbookMap.get('Carrier');
                        }
                        else if(Trigger.isUpdate)
                        {
                          if(OppItr.RecordTypeId!=Trigger.oldMap.get(OppItr.Id).RecordTypeId)
                            {
                            if(recMap.get(OppItr.RecordTypeId) == 'p) Carrier')
                            OppItr.Pricebook2Id = prcbookMap.get('Carrier');
                            else if(abbAccmap.get(OppItr.accountId) == 'a)Support')
                            {
                             OppItr.Pricebook2Id = prcbookMap.get('support');
                            }
                            else if(abbAccmap.get(OppItr.accountId) == 'b) Standalone')
                               
                           }
                           
                      
                          } 
                      System.debug('====assign'+OppItr.Pricebook2Id);
                
                        }
              }
              }

            }
}



Test Class:

@isTest (SeeAllData = true)
public class TestcarrierPricebookOpp {
    Public static testmethod void validatepric(){
    Id pbID = null;

    pbID = [Select Name, Description From Pricebook2 where Name = 'Carrier'].Id;
    List<RecordType> recordtypId =  [Select SobjectType, Name, Id, DeveloperName From RecordType  Where SobjectType = 'Opportunity' And  Name = 'p) Carrier'];
Account obj = new Account( Name = 'Test123', BillingPostalCode='78945');
insert obj;

Opportunity objOpp = new Opportunity(Name = 'newTest',recordtypeId=recordtypId[0].Id,AccountId = obj.Id,StageName ='Prospecting',CloseDate=Date.today());
        objOpp.Pricebook2Id=pbID;       
insert objOpp;

Opportunity objUOppt = new opportunity(Id =objOpp.Id );
update objUOppt ;

}
}




Any help on this?


Thanks,
Selva
 
Amit Chaudhary 8Amit Chaudhary 8
Try to avoid SeeAllData= true from your test class.

// This is how we get the Standard PriceBook Id.  Prior to Summer '14, we needed
// to use SeeAllData=true, so this is a big improvement
Id pricebookId = Test.getStandardPricebookId();

Try below test clas.
@isTest
public class TestcarrierPricebookOpp 
{
    Public static testmethod void validatepric()
	{
		// This is how we get the Standard PriceBook Id.  Prior to Summer '14, we needed
		// to use SeeAllData=true, so this is a big improvement

		Id pricebookId = Test.getStandardPricebookId();

		List<RecordType> recordtypId =  [Select SobjectType, Name, Id, DeveloperName From RecordType  Where SobjectType = 'Opportunity' And  Name = 'p) Carrier'];
		
		Account obj = new Account( Name = 'Test123', BillingPostalCode='78945');
		insert obj;

		Opportunity objOpp = new Opportunity(Name = 'newTest',recordtypeId=recordtypId[0].Id,AccountId = obj.Id,StageName ='Prospecting',CloseDate=Date.today());
		objOpp.Pricebook2Id=pricebookId;       
		insert objOpp;

		objOpp.Name='demo';	
		update objUOppt ;

	}
}
Please check below post for test classes.
1) http://amitsalesforce.blogspot.in/search/label/Test%20Class
2) http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html


Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

 
Selvakumar Anbazhagan 7Selvakumar Anbazhagan 7
Hi Amit,

Thanks for your response.

Actually,my pricebook which is not a Standard Pricebook. So it failed now. Even i tried with assign specific Pricebook to it. Again got failed.

Is it way to approch different?