+ Start a Discussion
ravikanth321ravikanth321 

Too Many SOQL Queries :101


Hi Anything Wrong In My Trigger ,When I am Trying To Deploy a Test Class(In Test Class Ii am Just Inserting  Account,Oppurtunity,Cardapplication objcet) I am Getting This Below Error:
System.LimitException: Too many SOQL queries: 101 
Stack Trace: Trigger.UpdateEngagement: line 13, column 1
trigger UpdateEngagement on Opportunity (after insert, after update, before update) 
{
    if(Trigger.isInsert || (Trigger.isUpdate && Trigger.isAfter))
    {
        map<Id, string> mpOpp = new map<Id, string>();
        for(Opportunity o: Trigger.New)
        {
            mpOpp.put(o.AccountId, o.StageName);
        }
        
        If(mpOpp != null && mpOpp.size()>0)
        {
            List<Account> lstAcc = [select  EngagementCode__c, id from Account where id in :mpOpp.KeySet()];
            for(Account a: lstAcc)
            {
                a.EngagementCode__c = mpOpp.get(a.id);
            }
            update lstAcc;
        }
    }

    // New code added to Update the Incentive Options dependent field on stage change - by Vivek
 /*   if(Trigger.isUpdate && Trigger.isBefore)
    {
    
system.debug('@@1Before Incentive offer + Incentive'+Trigger.Old[0].Incentive__c);
        for(Opportunity OppNew : Trigger.New)
        {
            for(Opportunity OppOld : Trigger.Old)
            {
                if(OppNew.StageName != 'Product Recommendation' && OppOld.Incentive__c!='')
                {
                
system.debug('@@2Copying Incentive offer'+OppOld.Incentive__c);
                    OppNew.Incentive__c = OppOld.Incentive__c;
                }
            }
        }     
    } */
}
Best Answer chosen by ravikanth321
Mahesh DMahesh D
Hi Rashmi,

Please find the modified code:

Here I considered:

(1) Added the conditions so that it will not execute every insertion / updation.
trigger UpdateEngagement on Opportunity (after insert, after update, before update) 
{
    if((Trigger.isInsert || Trigger.isUpdate ) && Trigger.isAfter) {
        map<Id, string> mpOpp = new map<Id, string>();
        for(Opportunity o: Trigger.New) {
            if(Trigger.isInsert || o.StageName != Trigger.oldMap.get(o.Id).StageName 
                                || o.AccountId != Trigger.oldMap.get(o.Id).AccountId)
            mpOpp.put(o.AccountId, o.StageName);
        }
        
        If(!mpOpp.isEmpty()) {
            List<Account> lstAcc = [select  EngagementCode__c, id from Account where id in :mpOpp.KeySet()];
            for(Account a: lstAcc) {
                a.EngagementCode__c = mpOpp.get(a.id);
            }
            update lstAcc;
        }
    }

    // New code added to Update the Incentive Options dependent field on stage change - by Vivek
 /*   if(Trigger.isUpdate && Trigger.isBefore)
    {
    
system.debug('@@1Before Incentive offer + Incentive'+Trigger.Old[0].Incentive__c);
        for(Opportunity OppNew : Trigger.New)
        {
            for(Opportunity OppOld : Trigger.Old)
            {
                if(OppNew.StageName != 'Product Recommendation' && OppOld.Incentive__c!='')
                {
                
system.debug('@@2Copying Incentive offer'+OppOld.Incentive__c);
                    OppNew.Incentive__c = OppOld.Incentive__c;
                }
            }
        }     
    } */
}

You need to look into other triggers. If you are updating the Opportunity in any of the triggers then there is highly chances of getting into Too Many SOQL.

If possible check all the Triggers on Account, Opportunity and Cardapplication, make sure that you are not writing the SOQL inside the for loop.

Also follow the best practices of writing the trigger:

1) One Trigger Per Object

A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org.

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers

4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail


Please do let me know if it helps you.

Regards,
Mahesh

All Answers

Amit Chaudhary 8Amit Chaudhary 8
Your this Trigger look good to me. Please check other trigger and compare with below best pratice

Here are some best practices that will stop the error messages and/or help you avoid hitting the Governors Limit: 
https://help.salesforce.com/apex/HTViewSolution?id=000181404&language=en_US
1. Since Apex runs on a Multitenant structure, Apex runtime engine strictly enforces limits to ensure code doesn't monopolize shared resources. Learn about the Governors Limit.
2. Avoid SOQL queries that are inside FOR loop. 
3. Check out the Salesforce Developer Blog where you can find Best Practices for Triggers.
4. Review best practices for Trigger and Bulk requests on our Force.com Apex Code Developer's Guide. 
5. Be sure you're following the key coding principals for Apex Code in our Developer's Guide.

Please let us know if this will help you
Mahesh DMahesh D
Hi Rashmi,

Please find the modified code:

Here I considered:

(1) Added the conditions so that it will not execute every insertion / updation.
trigger UpdateEngagement on Opportunity (after insert, after update, before update) 
{
    if((Trigger.isInsert || Trigger.isUpdate ) && Trigger.isAfter) {
        map<Id, string> mpOpp = new map<Id, string>();
        for(Opportunity o: Trigger.New) {
            if(Trigger.isInsert || o.StageName != Trigger.oldMap.get(o.Id).StageName 
                                || o.AccountId != Trigger.oldMap.get(o.Id).AccountId)
            mpOpp.put(o.AccountId, o.StageName);
        }
        
        If(!mpOpp.isEmpty()) {
            List<Account> lstAcc = [select  EngagementCode__c, id from Account where id in :mpOpp.KeySet()];
            for(Account a: lstAcc) {
                a.EngagementCode__c = mpOpp.get(a.id);
            }
            update lstAcc;
        }
    }

    // New code added to Update the Incentive Options dependent field on stage change - by Vivek
 /*   if(Trigger.isUpdate && Trigger.isBefore)
    {
    
system.debug('@@1Before Incentive offer + Incentive'+Trigger.Old[0].Incentive__c);
        for(Opportunity OppNew : Trigger.New)
        {
            for(Opportunity OppOld : Trigger.Old)
            {
                if(OppNew.StageName != 'Product Recommendation' && OppOld.Incentive__c!='')
                {
                
system.debug('@@2Copying Incentive offer'+OppOld.Incentive__c);
                    OppNew.Incentive__c = OppOld.Incentive__c;
                }
            }
        }     
    } */
}

You need to look into other triggers. If you are updating the Opportunity in any of the triggers then there is highly chances of getting into Too Many SOQL.

If possible check all the Triggers on Account, Opportunity and Cardapplication, make sure that you are not writing the SOQL inside the for loop.

Also follow the best practices of writing the trigger:

1) One Trigger Per Object

A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org.

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers

4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail


Please do let me know if it helps you.

Regards,
Mahesh
This was selected as the best answer
ravikanth321ravikanth321
Thanks Mahesh