function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
hari azmeera 8hari azmeera 8 

create a task if lead status is hot and add reminder to that task

Best Answer chosen by hari azmeera 8
Amit Chaudhary 8Amit Chaudhary 8
Hi Hari,
I found below issue in your code
1) You was using = to compare not ==
2) As per your code if(trigger.isInsert && Trigger.isAfter ) you are using only After Insert not Update . So i removed
3) you are not cheking size of list before DML.


Please try below code.
trigger reminder on Lead (after insert) 
{
	list<Task> lstTaskToInsert = new list<Task>();
	if(trigger.isInsert  && Trigger.isAfter )
	{
		for(lead objlead : trigger.new)
		{
			  if(objlead.status == 'Hot') 
			  {
				 Task objTask = new Task();
				 objTask.whatId = objlead.Id;
				 // add all test related required field here
				 lstTaskToInsert.add(objTask);
			  }
		}
		if( lstTaskToInsert.size() > 0 ) 
		{
			insert lstTaskToInsert;
		}	
	}
}

Please check below post for trigger i hope that will  help you
1) http://amitsalesforce.blogspot.in/2015/06/trigger-best-practices-sample-trigger.html

1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org.

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers

4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail

Let us know if this will help you

Thanks
Amit Chaudhary

All Answers

sandeep sankhlasandeep sankhla
Hi Hari,
Please refer the below code where you can check if lead status is hot on insert and then you can insert task for each lead and then you can set other values for task. I just added one valye which is whatdi rest field values you can provide as per your need.s
UTrigger on Lead (after insert, after update)
		   {
		   
			list<Task> lstTaskToInsert = new list<Task>();
			
				if(trigger.isInsert() && Trigger.isAfter())
				{
						for(lead objlead : trigger.new)
						{
						      if(objlead.status = 'Hot')
							  {
							     Task objTask = new Task();
								 objTask.whatId = objlead.Id;
								 lstTaskToInsert.add(objTask);
							  }
						}
						
						insert lstTaskToInsert;
				}
		   }

please check and let me know if it helps you.

Thanks,
Sandeep
Mahesh DMahesh D
Hi Hari,

You can able to achieve this with the Workflow field update.

Steps:
1) Create a Workflow on Lead Object.
2) Evaluation Criteria as 'Created'.
3) Rule Criteria as 'Status = Hot'.
4) Immediate Workflow action --> Task Creation.
5) Save and activate the Workflow.

Regards,
Mahesh

 
sandeep sankhlasandeep sankhla
Hi Hari,

Yes, instead of trigger you can use workflow action also as mentioned by Mahesh.

Thanks
hari azmeera 8hari azmeera 8
Hi Sandeep,

Yes offcourse but i want to do by using triggers only,

I am tring to impletement same code which you sent but i am getting below error.

Error: Condition expression must be of type Boolean
sandeep sankhlasandeep sankhla
can you share the code so I can check ?
hari azmeera 8hari azmeera 8
trigger reminder on Lead (after insert, after update) {
               
           
            list<Task> lstTaskToInsert = new list<Task>();
            
                if(trigger.isInsert() && Trigger.isAfter())
                {
                        for(lead objlead : trigger.new)
                        {
                              if(objlead.status = 'Hot') // I am getting error here
                              {
                                 Task objTask = new Task();
                                 objTask.whatId = objlead.Id;
                                 lstTaskToInsert.add(objTask);
                              }
                        }
                        insert lstTaskToInsert;
                }
           }

 
 
sandeep sankhlasandeep sankhla
we missed == opertaor ..please replcae = with == and check.
Mahesh DMahesh D
Hi Hari,

Please use the below code:
 
Trigger LeadTrigger on Lead (after insert, after update) {
           
    List<Task> lstTaskToInsert = new list<Task>();
    if(trigger.isInsert && Trigger.isAfter){
        for(lead ld : trigger.new) {
            if(ld.status == 'Hot') {
                Task objTask = new Task();
                objTask.whatId = ld.Id;
                lstTaskToInsert.add(objTask);
            }
        }
        if(!lstTaskToInsert.isEmpty())
            insert lstTaskToInsert;
    }
}

Regards,
Mahesh
Mahesh DMahesh D
Hi Hari,

In the above code I considered:

(1) Alignment
(2) Naming convention
(3) Corrected the error.
(4) Saved the trigger in my DE environment and everything looks good.

Regards,
Mahesh
Amit Chaudhary 8Amit Chaudhary 8
Hi Hari,
I found below issue in your code
1) You was using = to compare not ==
2) As per your code if(trigger.isInsert && Trigger.isAfter ) you are using only After Insert not Update . So i removed
3) you are not cheking size of list before DML.


Please try below code.
trigger reminder on Lead (after insert) 
{
	list<Task> lstTaskToInsert = new list<Task>();
	if(trigger.isInsert  && Trigger.isAfter )
	{
		for(lead objlead : trigger.new)
		{
			  if(objlead.status == 'Hot') 
			  {
				 Task objTask = new Task();
				 objTask.whatId = objlead.Id;
				 // add all test related required field here
				 lstTaskToInsert.add(objTask);
			  }
		}
		if( lstTaskToInsert.size() > 0 ) 
		{
			insert lstTaskToInsert;
		}	
	}
}

Please check below post for trigger i hope that will  help you
1) http://amitsalesforce.blogspot.in/2015/06/trigger-best-practices-sample-trigger.html

1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org.

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers

4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail

Let us know if this will help you

Thanks
Amit Chaudhary
This was selected as the best answer