+ Start a Discussion
ThomasmThomasm 

lead conversion test code

I am working if a trigger to convert multiple leads at once and need help with the test class

the trigger is:

trigger AutoConvert on Lead (after update) {
    list<Lead> LeadsToConvert = new list<Lead>();
    for(Lead myLead: Trigger.new){
        if(!myLead.isConverted)
            LeadsToConvert.add(myLead);
    }
 
    list<Database.LeadConvert> leadConverts = new list<Database.LeadConvert>();
    for(Lead myLead : LeadsToConvert){
        Database.LeadConvert lc = new database.LeadConvert();
        lc.setLeadId(myLead.Id);
        lc.convertedStatus = 'Qualified';

        //Database.ConvertLead(lc,true);
        lc.setDoNotCreateOpportunity(true);
        leadConverts.add(lc);
  }
    if(!leadConverts.isEmpty()){
        for(Integer i = 0; i <= leadConverts.size()/100 ; i++){
            list<Database.LeadConvert> tempList = new list<Database.LeadConvert>();
            Integer startIndex = i*100;
            Integer endIndex = ((startIndex+100) < leadConverts.size()) ? startIndex+100: leadConverts.size();
            for(Integer j=startIndex;j<endIndex;j++){
                tempList.add(leadConverts[j]);
            }
            Database.LeadConvertResult[] lcrList = Database.convertLead(tempList, false);
            for(Database.LeadConvertResult lcr : lcrList)
                System.assert(lcr.isSuccess());
        }
    }

}

and the test class is 

@isTest
Private class UnitTest_AutoConvert {

Static TestMethod void AutoConvert(){

    test.StartTest();

   // Create the Lead object
   Lead testLead = new Lead(
  id='00Qa0000012cJlM',
   FirstName='Demo 100800',
   LastName = 'Demo 100800 UnitTest',
   Status='Qualified',
   company='Lacosta',
   street='1211 E I-40 Service Rd',
   city=' Oklahoma City',
   state='OK'
  // zippostal_code= '73149'
   
   //Ready_to_Convert__c = true
   );

   update testLead;
   System.debug('Created and inserted lead');

   Database.LeadConvert lc = new database.LeadConvert();
   lc.setLeadId(testLead.Id);

   LeadStatus convertStatus = [SELECT Id, MasterLabel FROM LeadStatus WHERE IsConverted=true LIMIT 1];
   lc.setConvertedStatus(convertStatus.MasterLabel);
   Database.LeadConvertResult lcrList = Database.convertLead(lc);

   // Make sure conversion was successful
   System.assert(lcrList.isSuccess());

   test.stopTest();
   }
   }

i am currently getting the following error
System.DmlException: ConvertLead failed. First exception on row 0; first error: CANNOT_UPDATE_CONVERTED_LEAD, cannot reference converted lead: []
Stack Trace Class.UnitTest_AutoConvert.AutoConvert: line 31, column 1
 
Best Answer chosen by Thomasm
James LoghryJames Loghry
Your trigger is set up so that *any* lead that is updated is converted.  Typically, lead converts only happen if certain criteria are met.  If that's also the case with your sales process, then you need to add those critera to your trigger.

The reason your trigger is erroring out is that in your test class, you are calling update testLead; which will convert your testLead, and then you are converting it once again later in your test class.  Hence the cannot convert a converted lead error.

Your solutiion is to:
  1. Add criteria to your trigger to only convert based on specific criteria
  2. Prevent the trigger from converting already converted leads (similar to step 1)
  3. remove the convert call from your test class and let the trigger take care of the conversion for you.

All Answers

James LoghryJames Loghry
Your trigger is set up so that *any* lead that is updated is converted.  Typically, lead converts only happen if certain criteria are met.  If that's also the case with your sales process, then you need to add those critera to your trigger.

The reason your trigger is erroring out is that in your test class, you are calling update testLead; which will convert your testLead, and then you are converting it once again later in your test class.  Hence the cannot convert a converted lead error.

Your solutiion is to:
  1. Add criteria to your trigger to only convert based on specific criteria
  2. Prevent the trigger from converting already converted leads (similar to step 1)
  3. remove the convert call from your test class and let the trigger take care of the conversion for you.
This was selected as the best answer
Amit Chaudhary 8Amit Chaudhary 8
Please check below post i hope that will help you
1) http://amitsalesforce.blogspot.com/search/label/Test%20Class
2) http://amitsalesforce.blogspot.com/2015/06/best-practice-for-test-classes-sample.html
Please try below code. i hope that will help you
@isTest
Private class UnitTest_AutoConvert 
{
	Static TestMethod void AutoConvert()
	{
	    // Create the Lead object
	    Lead testLead = new Lead(
			FirstName='Demo 100800',
			LastName = 'Demo 100800 UnitTest',
			Status='Qualified',
			company='Lacosta',
			street='1211 E I-40 Service Rd',
			city=' Oklahoma City',
			state='OK'
  	    );
	    insert 	testLead;
	   
		test.StartTest();
			
			Database.LeadConvert lc = new database.LeadConvert();
            lc.setLeadId(testLead.Id);
            LeadStatus convertStatus = [Select Id, MasterLabel from LeadStatus where IsConverted=true limit 1];
            lc.setConvertedStatus(convertStatus.MasterLabel);
            Database.LeadConvertResult lcr = Database.convertLead(lc);
            System.assert(lcr.isSuccess());

	    test.stopTest();
    }
}
Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

 
ThomasmThomasm
removing the insert got rid of the error but my coverage is only 27%