+ Start a Discussion
sfdotcomsfdotcom 

Test class for List controller

Hi,
Please help me on writing test class for below controller.

Controller:
public class ItemInsertDisplay {
    public Item__c newItem {get; set;}
  
    //Constructor
    public ItemInsertDisplay(){
        newItem = new Item__c();
    }
    public List<Item__c> existingItems{
        get{    
            existingItems = [Select Id, Name, Item_Name__c, Unit_Price__c from Item__c order by Item__c.Item_Name__c];
            return existingItems;
        }
        set;
    }
    
    public PageReference save(){
        try{
            insert newItem;
            newItem = new Item__c();
        }
        catch(Exception e)
        {
            ApexPages.addMessages(e);
        }
        return null;
    }
}

Thanks.
Best Answer chosen by sfdotcom
Amit Chaudhary 8Amit Chaudhary 8
Ohh Grt. Please try below code. I hope that will help you
@isTest
public class ItemInsertDisplay_Test 
{
    static testMethod void TestInsertItems()
	{
        Item__c item = new Item__c( Item_Name__c = 'Test', Unit_Price__c = 1000);
		// add all required field here
		insert item;
		
        ItemInsertDisplay ctr = new ItemInsertDisplay();
		List<Item__c>  lst = ctr.existingItems();
		
		ctr.newItem.Name = 'Test1';
		ctr.newItem.Unit_Price__c = 200;
		// Add all required field
        ctr.save();
    }

}
Please let us know if this will help you or not
 

All Answers

sfdotcomsfdotcom
I have wrote below test class. But i am not getting code coverage.
@isTest
public class ItemInsertDisplay_Test {
    static testMethod void TestInsertItems(){
        Item__c item = new Item__c( Item_Name__c = 'Test', Unit_Price__c = 1000);
        
        try{
        insert item;
            item = new Item__c();    
        }
        catch(Exception e)
        {
            ApexPages.addMessages(e);
        }
        List<Item__c> itemList;
        ItemInsertDisplay ctr = new ItemInsertDisplay();
        ctr.save();
        itemList = [Select Id, Name, Item_Name__c, Unit_Price__c from Item__c order by Item__c.Item_Name__c];
        
        ctr.existingItems = itemList ;
        ctr.newItem = item;
        
    }

}
Amit Chaudhary 8Amit Chaudhary 8
Please check below post. I hope that will help you
http://amitsalesforce.blogspot.in/search/label/Test%20Class
http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html

PLease try below test class. I hope that will help you
@isTest
public class ItemInsertDisplay_Test 
{
    static testMethod void TestInsertItems()
	{
        Item__c item = new Item__c( Item_Name__c = 'Test', Unit_Price__c = 1000);
		// add all required field here
		insert item;
		
        ItemInsertDisplay ctr = new ItemInsertDisplay();
		ctr.newItem = 'Test1';
		ctr.Unit_Price__c = 200;
		// Add all required field
        ctr.save();
    }

}
Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

 
sfdotcomsfdotcom
Hi Amit, I am getting below error:

[Error] Error: Compile Error: Illegal assignment from String to Item__c at line 11 column 9
sfdotcomsfdotcom
Hi, I am getting 61% coverage. below code is not getting covered

 get{    
            existingItems = [Select Id, Name, Item_Name__c, Unit_Price__c from Item__c order by Item__c.Item_Name__c];
            return existingItems;
        }
Amit Chaudhary 8Amit Chaudhary 8
Ohh Grt. Please try below code. I hope that will help you
@isTest
public class ItemInsertDisplay_Test 
{
    static testMethod void TestInsertItems()
	{
        Item__c item = new Item__c( Item_Name__c = 'Test', Unit_Price__c = 1000);
		// add all required field here
		insert item;
		
        ItemInsertDisplay ctr = new ItemInsertDisplay();
		List<Item__c>  lst = ctr.existingItems();
		
		ctr.newItem.Name = 'Test1';
		ctr.newItem.Unit_Price__c = 200;
		// Add all required field
        ctr.save();
    }

}
Please let us know if this will help you or not
 
This was selected as the best answer
sfdotcomsfdotcom
Hi Amit,
great thanks. Now i got 84 % coverage. 

I have done small modification in code as below. However I am not getting 100 % coverage.

@isTest
public class ItemInsertDisplay_Test 
{
    static testMethod void TestInsertItems()
    {
        Item__c item = new Item__c( Item_Name__c = 'Test', Unit_Price__c = 1000);
        // add all required field here
        try{
        insert item;
        }
        catch(Exception ex)
        {
        ApexPages.addMessages(ex);
        }
        ItemInsertDisplay ctr = new ItemInsertDisplay();
        List<Item__c>  lst = ctr.existingItems;
        
        ctr.newItem.Item_Name__c= 'Test1';
        ctr.newItem.Unit_Price__c = 200;
        // Add all required field
        ctr.save();
    }

}