Apex Code Development You need to sign in to do that
Don't have an account?
Wes McCarthy Help with Test Coverage
Hi there,
Im relatively new to APEX coding, and have been working on a Task trigger in my sandbox environment. All appears to be working ok there. I deployed the trigger to production, but cannot implement it as i do not have any test coverage. I have no idea how to do this, and am hoping somebody can provide some help. The trigger is as follows:
trigger TaskTrigger on Task (before insert, before update)
{
List<Id> OppIds=new List<Id>();
for(Task t:trigger.new)
{
if(t.Status=='Completed')
{
if(t.whatId != null && String.valueOf(t.whatId).startsWith('006')==TRUE) //check if the task is associated with an Opp
{
OppIds.add(t.whatId);
//System.debug('In here:' + t.whatid);
}//if 2
}//if 1
}//for
map<id,Opportunity> OpptaskMap = new map<id,Opportunity>([SELECT Id, Situation__c, Problem__c, Implication__c, Need_Payoff__c , StageName, (Select ID From OpportunityLineItems) FROM Opportunity WHERE Id IN :OppIds]);
List<OpportunityContactRole> OCR = [select id from OpportunityContactRole where OpportunityId IN :oppIds];
for(Task tsk:trigger.new)
{
if(OpptaskMap.keyset().contains(tsk.whatid))
{
if(tsk.Status == 'Completed' && tsk.Subject == 'Communicate with Client')
{
OpptaskMap.get(tsk.whatid).StageName = '2-Identified';
//System.debug('Communicate with Client:' + OpptaskMap.get(tsk.whatid).StageName);
}
Else if( tsk.Status == 'Completed' && tsk.Subject == 'Validate Opportunity')
{
If (OpptaskMap.get(tsk.whatid).Situation__c == Null || OpptaskMap.get(tsk.whatid).Problem__c == Null || OpptaskMap.get(tsk.whatid).Implication__c == Null || OpptaskMap.get(tsk.whatid).Need_Payoff__c == Null)
{
tsk.adderror('Task cannot be completed until the following Opportunity fields have been populated: Situation, Problem, Implication, Need & PayOff');
}
Else
{
OpptaskMap.get(tsk.whatid).StageName = '3-Validated';
}
}
// System.debug('1 condition:' + LeadtaskMap.get(tsk.whatid).Description == NULL);
// System.debug('2 condition:' + tsk.Status == 'Completed');
// System.debug('3 condition:' + tsk.Subject == 'Make contact with Lead');
// System.debug('task:' + tsk);
Else if(tsk.Status == 'Completed' && tsk.Subject == 'Qualify Opportunity and Identify Contact Roles')
{
If (OpptaskMap.get(tsk.whatid).OpportunityLineItems.isEmpty() || OCR.size()==0)
{
tsk.adderror('Task cannot be completed until Contact Roles AND Products have been added to the Opportunity');
}
Else
{
OpptaskMap.get(tsk.whatid).StageName = '4-Qualified';
}
}
Else if(tsk.Status == 'Completed' && tsk.Subject == 'Create quote and submit to Client')
{
OpptaskMap.get(tsk.whatid).StageName = '5-Proposal';
}
Else if(tsk.Status == 'Completed' && tsk.Subject == 'Proposal Outcome')
{
If (tsk.Proposal_Outcome__c == 'Commercial Agreement')
{
OpptaskMap.get(tsk.whatid).StageName = '6-Commercial Agreement';
}
Else If (tsk.Proposal_Outcome__c == 'Lost')
{
If (tsk.Loss_Abandonment_Reason__c == Null)
{
tsk.adderror('Please enter a reason for Loss / Abandonment');
}
Else
{
OpptaskMap.get(tsk.whatid).StageName = '9-Lost';
OpptaskMap.get(tsk.whatid).Opportunity_Loss_Abandoned_Reason__c = tsk.Loss_Abandonment_Reason__c;
OpptaskMap.get(tsk.whatid).Opp_Other_Loss_Abandonment_Comments__c = tsk.Other_Loss_Abandonment_Comments__c;
}
}
Else
{
If (tsk.Loss_Abandonment_Reason__c == Null)
{
tsk.adderror('Please enter a reason for Loss / Abandonment');
}
Else
{
OpptaskMap.get(tsk.whatid).StageName = '8-Abandoned';
OpptaskMap.get(tsk.whatid).Opportunity_Loss_Abandoned_Reason__c = tsk.Loss_Abandonment_Reason__c;
OpptaskMap.get(tsk.whatid).Opp_Other_Loss_Abandonment_Comments__c = tsk.Other_Loss_Abandonment_Comments__c;
}
}
}
Else if(tsk.Status == 'Completed' && tsk.Subject == 'Opportunity Outcome')
{
If (tsk.Opportunity_Outcome__c == 'Won')
{
OpptaskMap.get(tsk.whatid).StageName = '7-Won';
}
Else If (tsk.Opportunity_Outcome__c == 'Lost')
{
If (tsk.Loss_Abandonment_Reason__c == Null)
{
tsk.adderror('Please enter a reason for Loss / Abandonment');
}
Else
{
OpptaskMap.get(tsk.whatid).StageName = '9-Lost';
OpptaskMap.get(tsk.whatid).Opportunity_Loss_Abandoned_Reason__c = tsk.Loss_Abandonment_Reason__c;
OpptaskMap.get(tsk.whatid).Opp_Other_Loss_Abandonment_Comments__c = tsk.Other_Loss_Abandonment_Comments__c;
}
}
Else
{
If (tsk.Loss_Abandonment_Reason__c == Null)
{
tsk.adderror('Please enter a reason for Loss / Abandonment');
}
Else
{
OpptaskMap.get(tsk.whatid).StageName = '8-Abandoned';
OpptaskMap.get(tsk.whatid).Opportunity_Loss_Abandoned_Reason__c = tsk.Loss_Abandonment_Reason__c;
OpptaskMap.get(tsk.whatid).Opp_Other_Loss_Abandonment_Comments__c = tsk.Other_Loss_Abandonment_Comments__c;
}
}
}
Else
{
//OpptaskMap.get(tsk.whatid).StageName = '7-Won';
}
}
}
List<Opportunity> OppList = OpptaskMap.values();
update OppList;
}
Any help is much appreciated.
Thanks in advance.
Wes
@IsTest() public class TaskTriggerTest { static testmethod void MyUnitTest() { // Create an Opportunity record Opportunity opp = new Opportunity(Name='TestOpp',CloseDate=System.today(),StageName='Prospecting'); insert opp; // Create an Task record to test your Trigger and relate it with the Quote created Task t = new Task(Name='Test Task',Priority='Normal',whatId=opp.id,Subject='Communicate with Client',Status='Not Started'); insert t; t.Status ='Completed'; update t; t.Subject='Opportunity Outcome'l update t; } }http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.htmlPlease follow below salesforce Best Practice for Test Classes :-
1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .
Please let us know if this post will help you
All Answers
@IsTest() public class TaskTriggerTest { static testmethod void MyUnitTest() { // Create an Opportunity record Opportunity opp = new Opportunity(Name='TestOpp',CloseDate=System.today(),StageName='Prospecting'); insert opp; // Create an Task record to test your Trigger and relate it with the Quote created Task t = new Task(Name='Test Task',Priority='Normal',whatId=opp.id,Subject='Communicate with Client',Status='Not Started'); insert t; t.Status ='Completed'; update t; t.Subject='Opportunity Outcome'l update t; } }http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.htmlPlease follow below salesforce Best Practice for Test Classes :-
1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .
Please let us know if this post will help you